Ticket #5576 (closed: fixed)
Fix NormaliseByCurrent
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.2 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | #5592 | |
| Blocking: | Tester: | Michael Reuter |
Description
NormaliseByCurrent does not work properly for multi-period data. the log value used for the division is not specific to individual periods.
The algorithm needs updating so that it can work with a time series property filtered by period.
Change History
comment:3 Changed 8 years ago by Owen Arnold
refs #5576. New synthetic current_period log
Changeset: 0a8c49147b1e6ee48cc91a94cc95e6f36f2671d8
comment:5 Changed 8 years ago by Owen Arnold
refs #5576. Update NormaliseByCurrent.
There are also other fixes here to the data loading in order to pull-in addtional log values, and some general warning fixes I happened to see.
Changeset: 2f82cabc795b2817ce6391c24ac59177a06498a8
comment:6 Changed 8 years ago by Owen Arnold
refs #5576. Fix warnings.
Changeset: fc507cceeb69384d6b9e56517dce01cea5ac4bd1
comment:7 Changed 8 years ago by Owen Arnold
refs #5576. Wiki docs update.
Changeset: 7e77bf9e0d9f51520e1bb227870c7d271250428b
comment:8 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
I've created ticket #5595 to handle some incompatibilities with data loaded via ISIS Raw.
Tester: Unit tests should demonstrate this working for multiperiod data. If you want to extend testing beyond this, It will be a little tricky for you to configure input workspaces, but you might use the existing unit tests in NormaliseByCurrentTest as a guide.
comment:9 Changed 8 years ago by Owen Arnold
refs #5576. New synthetic current_period log
Changeset: 0a8c49147b1e6ee48cc91a94cc95e6f36f2671d8
comment:10 Changed 8 years ago by Owen Arnold
refs #5576. Update NormaliseByCurrent.
There are also other fixes here to the data loading in order to pull-in addtional log values, and some general warning fixes I happened to see.
Changeset: 2f82cabc795b2817ce6391c24ac59177a06498a8
comment:11 Changed 8 years ago by Owen Arnold
refs #5576. Fix warnings.
Changeset: fc507cceeb69384d6b9e56517dce01cea5ac4bd1
comment:12 Changed 8 years ago by Owen Arnold
refs #5576. Wiki docs update.
Changeset: 7e77bf9e0d9f51520e1bb227870c7d271250428b
comment:13 Changed 8 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:14 Changed 8 years ago by Michael Reuter
- Status changed from verifying to closed
This looks like it is working correctly.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6422
To fix this ticket, I'm also going to have to add another synthetic log value. This is so that I can pick up the current period from a workspace without having to calculate the key to use. Currently, there is a period {n} log, value, but as part of the filtering in NormaliseByCurrent, I won't know what the {n} value of the period {n} log is. A better approach will be to create a new log value called current_period, from which I can extract a single value integer property, which corresponds to the period index.