Ticket #5582 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

EQSANS: fix resolution calculation for low signal

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

The current version of the Q resolution calculation does the weighted average of the qQ for each event. When the signal goes negative because the background is bigger than the signal, the errors become a huge negative number. Only the signal events should be considered (only those with a positive weight).

Change History

comment:1 Changed 8 years ago by Mathieu Doucet

Re #5582 Fix problem with EQSANS Q resolution

Changeset: 80b675d3f2e4ac7ee941f4ab7cb19dad84112138

comment:2 Changed 8 years ago by Mathieu Doucet

Re #5582 Add system test for dQ calculation.

Changeset: 7911696c199e957ed59b87a39dd82e290d70a2e0

comment:3 Changed 8 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:4 Changed 8 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Mathieu Doucet

Re #5582 Fix problem with EQSANS Q resolution

Changeset: 80b675d3f2e4ac7ee941f4ab7cb19dad84112138

comment:6 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:7 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

The code looks like it makes the requested change correctly.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6428

Note: See TracTickets for help on using tickets.