Ticket #5592 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Size calculation on PropertyWithValue

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #5576 Tester: Peter Parker

Description

The size returned from a PropertyWithValue, and derived types such as ArrayProperty is always 1. This is clearly wrong and makes things very tricky with the current fixes Im working on to #5576.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

refs #5592. Calculates the correct sizes.

Changeset: 32301fdcaf0ac87c85364ee1d0a0029097b6eced

comment:3 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: This is quite a simple change. The additional unit tests should satisfy you that it is now doing the right thing in the presence of different types.

comment:4 Changed 8 years ago by Owen Arnold

refs #5592. Calculates the correct sizes.

Changeset: 32301fdcaf0ac87c85364ee1d0a0029097b6eced

comment:5 Changed 8 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:6 Changed 8 years ago by Peter Parker

Passing.

Opened #5691 to accommodate vectors of vectors.

comment:7 Changed 8 years ago by Peter Parker

  • Status changed from verifying to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6438

Note: See TracTickets for help on using tickets.