Ticket #5605 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create workflow algorithm for DGS convert to energy transfer

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

A new workflow algorithm will be created to handle the main steps in the convert to energy transfer process for direct geometry spectrometers.

Change History

comment:1 Changed 8 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Michael Reuter

Refs #5605. Initial work on algorithm.

Changeset: d2a6c4d8bb84cab60e1aae96de8dc95146463976

comment:3 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Changes to make reduction actually run.

Adding a lot of this pointers for clarification. Adding rebinning to energy transfer conversion. Other fixes to get reduction running.

Changeset: 61947ca5b4e0de26efcc99f8b7bab2cd2ff440d4

comment:4 Changed 8 years ago by Michael Reuter

Refs #5453, #5454 and #5605. Adding new option.

An option under the energy transfer range has been added to allow the final S(Phi, E) to be made a distribution.

Changeset: 11817b3ee5cc70845b967ec51eaa3e6f3cb2378a

comment:5 Changed 8 years ago by Michael Reuter

Refs #5605. Adding initial energy calculation for ARCS and SEQUOIA.

Changeset: a29b503c10ebb58facba74ce8466ae88c71e630e

comment:6 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Making Ei calculation for ARCS and SEQUOIA work.

Changeset: d94626041469ea613fda869838c85663bb7b49eb

comment:7 Changed 8 years ago by Michael Reuter

Refs #5605. Internal parameter name normalization.

Changeset: 5259233b7979c8cf19b72643c70fbb56fe9aec27

comment:8 Changed 8 years ago by Michael Reuter

Refs #5605. Adding incidnet beam parameter norm.

Changeset: 75729105a362c79a75fd1f9435c5e6b3f5e74418

comment:9 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Changing to hopefully clearer parameter names.

Changeset: e73f3e91ec5e189583e080583edf6386f9d20ac1

comment:10 Changed 8 years ago by Michael Reuter

Refs #5605. Initial work on algorithm.

Changeset: d2a6c4d8bb84cab60e1aae96de8dc95146463976

comment:11 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Changes to make reduction actually run.

Adding a lot of this pointers for clarification. Adding rebinning to energy transfer conversion. Other fixes to get reduction running.

Changeset: 61947ca5b4e0de26efcc99f8b7bab2cd2ff440d4

comment:12 Changed 8 years ago by Michael Reuter

Refs #5453, #5454 and #5605. Adding new option.

An option under the energy transfer range has been added to allow the final S(Phi, E) to be made a distribution.

Changeset: 11817b3ee5cc70845b967ec51eaa3e6f3cb2378a

comment:13 Changed 8 years ago by Michael Reuter

Refs #5605. Adding initial energy calculation for ARCS and SEQUOIA.

Changeset: a29b503c10ebb58facba74ce8466ae88c71e630e

comment:14 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Making Ei calculation for ARCS and SEQUOIA work.

Changeset: d94626041469ea613fda869838c85663bb7b49eb

comment:15 Changed 8 years ago by Michael Reuter

Refs #5605. Add change reminder.

Changeset: c4a869fa0eff68b2e322e88e73d5dae0cd6cba23

comment:16 Changed 8 years ago by Michael Reuter

Refs #5453, #5605 and #5623. Moving to property manager passing.

All workflow algorithms except for the top level (DgsReduction) will now only handle input and output workspaces and a property manager. There will be no other outward facing properties.

Changeset: 61a0838e8f76a8f200171dad93d334affaf952cd

comment:17 Changed 8 years ago by Michael Reuter

Refs #5605. Add change reminder.

Changeset: c4a869fa0eff68b2e322e88e73d5dae0cd6cba23

comment:18 Changed 8 years ago by Michael Reuter

Refs #5453, #5605 and #5623. Moving to property manager passing.

All workflow algorithms except for the top level (DgsReduction) will now only handle input and output workspaces and a property manager. There will be no other outward facing properties.

Changeset: 61a0838e8f76a8f200171dad93d334affaf952cd

comment:19 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Adding processing and use of detector vanadium.

Changeset: 1c309cebfcdf0f21a49d22081e3b101145f43f1a

comment:20 Changed 8 years ago by Michael Reuter

Refs #5605. More fixes.

Changeset: e053280f6d124504bd8dbbc3bd503c823be687e3

comment:21 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:22 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Adding processing and use of detector vanadium.

Changeset: 1c309cebfcdf0f21a49d22081e3b101145f43f1a

comment:23 Changed 8 years ago by Michael Reuter

Refs #5605. More fixes.

Changeset: e053280f6d124504bd8dbbc3bd503c823be687e3

comment:24 Changed 8 years ago by Michael Reuter

Refs #5605. Adding masking and grouping.

Changeset: 14281ba79e106fc170b7b6254bd2a1c374197d28

comment:25 Changed 8 years ago by Michael Reuter

Refs #5605. Add solid angle correction for grouping and no detvan.

Changeset: 3c0b99cce54f6e89cfdfedc57715bd1f69a811cc

comment:26 Changed 8 years ago by Michael Reuter

Refs #5605. Allow reverse running order.

Changeset: 17d4d9620dd98b02f31fa99147fe2d7c2a02f024

comment:27 Changed 8 years ago by Michael Reuter

Refs #5605. Making default et binning parameters.

Changeset: d9fe9591e6262783c80a80c034e07ee32e06727b

comment:28 Changed 8 years ago by Michael Reuter

Refs #5605. Fix preNeXus monitor loading.

Changeset: f63d23edf6671b3df07623e413e689fdf52f1ad4

comment:29 Changed 8 years ago by Michael Reuter

Refs #5605. Updating formatting.

Changeset: d2a8a9e9003b206725ca0ca23aec2514a25f3516

comment:30 Changed 8 years ago by Michael Reuter

Refs #5605. Changing default binning and mon specid retrieval.

Changeset: db123e39983c9858ea4c4d0a14857e098873c3c2

comment:31 Changed 8 years ago by Michael Reuter

Refs #5605. Make algorithm fail if Ei calc fails.

Changeset: ee62db137b349dd4dc046d85e59b08e5c91b4ad9

comment:32 Changed 8 years ago by Michael Reuter

Refs #5605. Adding calculated T0 as sample log.

Changeset: 9781f117aaabada3dbeb0a7a61dd14da638ff2ea

comment:33 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Adding a TZero guess.

Changeset: 1d59dc728eb40e3f3a6fbeb6a498f6e9ae4a1038

comment:34 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Adding monitor spectrum ID override.

Changeset: 086abf7ca06e564e2a614e47efdb5f06d9743739

comment:35 Changed 8 years ago by Michael Reuter

Refs #5605. Handle monitor spectra IDs.

Changeset: 0553c5f2bb6edd4e8d3f2a4b939d7e7ad40558cb

comment:36 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Let top-level alg handle output workspace.

Changeset: d96a641e46f2d0fd58ee0140601bbce589b167fc

comment:37 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655, #5678 and #5855. Workspace prop changes.

Lots of changes relating to output workspace space properties. Handling them in a consistent manner across all algorithms.

Changeset: 3cd13c6414d1262092dc84a299c447076e0155ed

comment:38 Changed 8 years ago by Michael Reuter

Refs #5605. Adding parameter for incident energy guess.

Changeset: 5b850d41a36783ee1d405264b03b0926689d16e1

comment:39 Changed 8 years ago by Michael Reuter

Refs #5605. Fix typo.

Changeset: 5641d869de2e032f60b75b33e56d4dd95dc58b9b

comment:40 Changed 8 years ago by Michael Reuter

Refs #5605 and #5655. Add property for abs units grouping.

Changeset: 82f34d611e3d91cbf6d4af6f8099b10fbc7309a2

comment:41 Changed 8 years ago by Michael Reuter

Refs #5605 and #5623. Passing TOF bin offset as algorithm param.

Changeset: e26d8243f52b0a5974b166d91ba471dcec0f7af0

comment:42 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655 and #5678. Removing enable history calls.

Changeset: 462c15295188e4fb197e7547417d7a8a86ea1a5f

comment:43 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Change behavior of tzero guess.

Changeset: 435c1f1b585124617258390f49f22679eb46f3c7

comment:44 Changed 8 years ago by Michael Reuter

Refs #5605. Keep monitor workspace internal.

Changeset: 6570c61cd8a10c24ecd746222e812b69058fe751

comment:45 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5655 amd #5678. More changes.

  • Switched to dividing by detector vanadium before grouping.
  • Eliminated grouping in processing the detector vanadium.
  • Adding some more intermediate workspaces.
  • Fixing internal workspace names for file saving.
  • Removing more things from the ADS. Changeset: 7887a021af527cedcbe06d03d1e0a7275a122427

comment:46 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Change handling of monitor and detcal file.

Changeset: d0981cbf1c2c441be8d86c5a694542d4f0a292ba

comment:47 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5623, #5655 and #5678. More changes.

comment:48 Changed 8 years ago by Michael Reuter

Refs #5605. Looking up energy for SNS.

Changeset: c45ad692c34278edb91fa8c594b9b0cab12ea97b

comment:49 Changed 8 years ago by Michael Reuter

Refs #5605. Shorten function call.

Changeset: c26df925d9707f30779a0acf50b75391ed94f09f

comment:50 Changed 8 years ago by Michael Reuter

Refs #5605. Removing formulas as this is handled elsewhere.

Changeset: 5f0d3d14cc995cd11ae02fe8bc55518173cc8e6e

comment:51 Changed 8 years ago by Michael Reuter

Refs #5605. Minor fixes.

Changeset: b61758019d5ddae52c4a1db4821b9cd945230884

comment:52 Changed 8 years ago by Michael Reuter

Refs #5605. Fix TIB algorithm execution.

Changeset: 53c4870619cdb9e347ce8d3b678d5864d2bb7be1

comment:53 Changed 8 years ago by Michael Reuter

Refs #5605. Removing unneeded code.

Changeset: 1f2594e2865da7fce665062acffca8306b95b5f9

comment:54 Changed 8 years ago by Michael Reuter

Refs #5605. Turning off event preservation in TIB proc.

Changeset: fc0de34b07de5338662e009f42ae74aea0015180

comment:55 Changed 8 years ago by Michael Reuter

Refs #5605. Cleaning events when SofPhiEIsDistribution is false.

Changeset: 2b826c90281e2362a3f47445bb52883af65804d4

comment:56 Changed 8 years ago by Michael Reuter

Refs #5605. Correcting property for workspace retrieval.

Changeset: fdf32931cbf698653fb3d3707e34cb7d88b958d3

comment:57 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Some changes.

comment:58 Changed 8 years ago by Michael Reuter

Refs #5605. Changing emax default boundary.

Changeset: 6d027e739fc735081e0531f291e7eea72f7dbe85

comment:59 Changed 8 years ago by Michael Reuter

Refs #5605. Update comment.

Changeset: 10caf345db6e31ee54cf5a6a568b6fe9b0c24962

comment:60 Changed 8 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

If you test either #5453 or #5454, this comes along for the ride.

comment:61 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:62 Changed 8 years ago by Andrei Savici

Tested as part of DGSReduction

comment:63 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:64 Changed 8 years ago by Michael Reuter

Refs #5605. Adding masking and grouping.

Changeset: 14281ba79e106fc170b7b6254bd2a1c374197d28

comment:65 Changed 8 years ago by Michael Reuter

Refs #5605. Add solid angle correction for grouping and no detvan.

Changeset: 3c0b99cce54f6e89cfdfedc57715bd1f69a811cc

comment:66 Changed 8 years ago by Michael Reuter

Refs #5605. Allow reverse running order.

Changeset: 17d4d9620dd98b02f31fa99147fe2d7c2a02f024

comment:67 Changed 8 years ago by Michael Reuter

Refs #5605. Making default et binning parameters.

Changeset: d9fe9591e6262783c80a80c034e07ee32e06727b

comment:68 Changed 8 years ago by Michael Reuter

Refs #5605. Fix preNeXus monitor loading.

Changeset: f63d23edf6671b3df07623e413e689fdf52f1ad4

comment:69 Changed 8 years ago by Michael Reuter

Refs #5605. Updating formatting.

Changeset: d2a8a9e9003b206725ca0ca23aec2514a25f3516

comment:70 Changed 8 years ago by Michael Reuter

Refs #5605. Changing default binning and mon specid retrieval.

Changeset: db123e39983c9858ea4c4d0a14857e098873c3c2

comment:71 Changed 8 years ago by Michael Reuter

Refs #5605. Make algorithm fail if Ei calc fails.

Changeset: ee62db137b349dd4dc046d85e59b08e5c91b4ad9

comment:72 Changed 8 years ago by Michael Reuter

Refs #5605. Adding calculated T0 as sample log.

Changeset: 9781f117aaabada3dbeb0a7a61dd14da638ff2ea

comment:73 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Adding a TZero guess.

Changeset: 1d59dc728eb40e3f3a6fbeb6a498f6e9ae4a1038

comment:74 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Adding monitor spectrum ID override.

Changeset: 086abf7ca06e564e2a614e47efdb5f06d9743739

comment:75 Changed 8 years ago by Michael Reuter

Refs #5605. Handle monitor spectra IDs.

Changeset: 0553c5f2bb6edd4e8d3f2a4b939d7e7ad40558cb

comment:76 Changed 8 years ago by Michael Reuter

Refs #5605. Major changes.

comment:77 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Let top-level alg handle output workspace.

Changeset: d96a641e46f2d0fd58ee0140601bbce589b167fc

comment:78 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655, #5678 and #5855. Workspace prop changes.

Lots of changes relating to output workspace space properties. Handling them in a consistent manner across all algorithms.

Changeset: 3cd13c6414d1262092dc84a299c447076e0155ed

comment:79 Changed 8 years ago by Michael Reuter

Refs #5605. Adding parameter for incident energy guess.

Changeset: 5b850d41a36783ee1d405264b03b0926689d16e1

comment:80 Changed 8 years ago by Michael Reuter

Refs #5605. Fix typo.

Changeset: 5641d869de2e032f60b75b33e56d4dd95dc58b9b

comment:81 Changed 8 years ago by Michael Reuter

Refs #5605 and #5655. Add property for abs units grouping.

Changeset: 82f34d611e3d91cbf6d4af6f8099b10fbc7309a2

comment:82 Changed 8 years ago by Michael Reuter

Refs #5605 and #5623. Passing TOF bin offset as algorithm param.

Changeset: e26d8243f52b0a5974b166d91ba471dcec0f7af0

comment:83 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655 and #5678. Removing enable history calls.

Changeset: 462c15295188e4fb197e7547417d7a8a86ea1a5f

comment:84 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Change behavior of tzero guess.

Changeset: 435c1f1b585124617258390f49f22679eb46f3c7

comment:85 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Adding parameter for ki/kf correction.

Changeset: dab1f58fcba69bc98b253edd5107647882d56343

comment:86 Changed 8 years ago by Michael Reuter

Refs #5605. Keep monitor workspace internal.

Changeset: 6570c61cd8a10c24ecd746222e812b69058fe751

comment:87 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5655 amd #5678. More changes.

  • Switched to dividing by detector vanadium before grouping.
  • Eliminated grouping in processing the detector vanadium.
  • Adding some more intermediate workspaces.
  • Fixing internal workspace names for file saving.
  • Removing more things from the ADS. Changeset: 7887a021af527cedcbe06d03d1e0a7275a122427

comment:88 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Change handling of monitor and detcal file.

Changeset: d0981cbf1c2c441be8d86c5a694542d4f0a292ba

comment:89 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5623, #5655 and #5678. More changes.

comment:90 Changed 8 years ago by Michael Reuter

Refs #5605. Looking up energy for SNS.

Changeset: c45ad692c34278edb91fa8c594b9b0cab12ea97b

comment:91 Changed 8 years ago by Michael Reuter

Refs #5605. Shorten function call.

Changeset: c26df925d9707f30779a0acf50b75391ed94f09f

comment:92 Changed 8 years ago by Michael Reuter

Refs #5605. Removing formulas as this is handled elsewhere.

Changeset: 5f0d3d14cc995cd11ae02fe8bc55518173cc8e6e

comment:93 Changed 8 years ago by Michael Reuter

Refs #5605. Minor fixes.

Changeset: b61758019d5ddae52c4a1db4821b9cd945230884

comment:94 Changed 8 years ago by Michael Reuter

Refs #5605. Fix TIB algorithm execution.

Changeset: 53c4870619cdb9e347ce8d3b678d5864d2bb7be1

comment:95 Changed 8 years ago by Michael Reuter

Refs #5605. Removing unneeded code.

Changeset: 1f2594e2865da7fce665062acffca8306b95b5f9

comment:96 Changed 8 years ago by Michael Reuter

Refs #5605. Turning off event preservation in TIB proc.

Changeset: fc0de34b07de5338662e009f42ae74aea0015180

comment:97 Changed 8 years ago by Michael Reuter

Refs #5605. Cleaning events when SofPhiEIsDistribution is false.

Changeset: 2b826c90281e2362a3f47445bb52883af65804d4

comment:98 Changed 8 years ago by Michael Reuter

Refs #5605. Correcting property for workspace retrieval.

Changeset: fdf32931cbf698653fb3d3707e34cb7d88b958d3

comment:99 Changed 8 years ago by Michael Reuter

Refs #5453 and #5605. Some changes.

comment:100 Changed 8 years ago by Michael Reuter

Refs #5605. Changing emax default boundary.

Changeset: 6d027e739fc735081e0531f291e7eea72f7dbe85

comment:101 Changed 8 years ago by Michael Reuter

Refs #5605. Update comment.

Changeset: 10caf345db6e31ee54cf5a6a568b6fe9b0c24962

comment:102 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6451

Note: See TracTickets for help on using tickets.