Ticket #5623 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create workflow algorithm for DGS data preprocessing

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

A workflow algorithm needs to be introduced that handles incident beam normalization. The algorithm should load data as well if it is not handed a workspace.

Change History

comment:1 Changed 8 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Michael Reuter

Refs #5623. First cut at algorithm.

Changeset: 45a778ac7ad27704dc82f7318e8addd37cbfa6cc

comment:3 Changed 8 years ago by Michael Reuter

Refs #5623. Missed a header.

Changeset: 8e19c3f61967b1af2d4cda438895467abdcde0d5

comment:4 Changed 8 years ago by Michael Reuter

Refs #5623. Minor changes.

Changeset: a755cdca28cb717e84a971c29707e78533237294

comment:5 Changed 8 years ago by Michael Reuter

Refs #5453, #5605 and #5623. Moving to property manager passing.

All workflow algorithms except for the top level (DgsReduction) will now only handle input and output workspaces and a property manager. There will be no other outward facing properties.

Changeset: 61a0838e8f76a8f200171dad93d334affaf952cd

comment:6 Changed 8 years ago by Michael Reuter

Refs #5453, #5605 and #5623. Moving to property manager passing.

All workflow algorithms except for the top level (DgsReduction) will now only handle input and output workspaces and a property manager. There will be no other outward facing properties.

Changeset: 61a0838e8f76a8f200171dad93d334affaf952cd

comment:7 Changed 8 years ago by Michael Reuter

Refs #5623. Recording and checking for preprocessing.

Changeset: 43a6d30367b109671c8b891dabfb94bba6a04f06

comment:8 Changed 8 years ago by Michael Reuter

Refs #5453, #5623, #5655 and #5678. Major changes.

I had to a lot of major changes to stop workspaces from getting stomped on. I had to turn off reliance on the ADS and pass workspace pointers around by hand to keep things separated.

Changeset: 346d66e4d08660082560658249d72915946d71ea

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:10 Changed 8 years ago by Michael Reuter

Refs #5623. Recording and checking for preprocessing.

Changeset: 43a6d30367b109671c8b891dabfb94bba6a04f06

comment:11 Changed 8 years ago by Michael Reuter

Refs #5453, #5623, #5655 and #5678. Major changes.

I had to a lot of major changes to stop workspaces from getting stomped on. I had to turn off reliance on the ADS and pass workspace pointers around by hand to keep things separated.

Changeset: 346d66e4d08660082560658249d72915946d71ea

comment:12 Changed 8 years ago by Michael Reuter

Refs #5453, #5623 and #5655. Trying to save proc detvan.

Changeset: cfd366cd0c7d007a65c687322fba987e51d85e83

comment:13 Changed 8 years ago by Michael Reuter

Refs #5623. Updating formatting.

Changeset: 46e600f3d3f1b6ed066900c850020be0ebdc0479

comment:14 Changed 8 years ago by Michael Reuter

Refs #5623. Fixing bug when no incident beam norm.

Changeset: 42fd1ccffe1a18739cc3a13c5bf0a2cde9ec863a

comment:15 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655, #5678 and #5855. Workspace prop changes.

Lots of changes relating to output workspace space properties. Handling them in a consistent manner across all algorithms.

Changeset: 3cd13c6414d1262092dc84a299c447076e0155ed

comment:16 Changed 8 years ago by Michael Reuter

Refs #5623. Removing unneeded code.

Changeset: 5d02feadf82a6a2860f1640fd2937b3eeceea803

comment:17 Changed 8 years ago by Michael Reuter

Refs #5623. Fixed bug in parameter check.

Changeset: f42b776383bb391073f439c3d352b588fbbee225

comment:18 Changed 8 years ago by Michael Reuter

Refs #5605 and #5623. Passing TOF bin offset as algorithm param.

Changeset: e26d8243f52b0a5974b166d91ba471dcec0f7af0

comment:19 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655 and #5678. Removing enable history calls.

Changeset: 462c15295188e4fb197e7547417d7a8a86ea1a5f

comment:20 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5623, #5655 and #5678. More changes.

comment:21 Changed 8 years ago by Michael Reuter

Refs #5623, #5655 and #5678. Using new helper function.

Changeset: 0375945966842fffed2c14440165eb2f62b32516

comment:22 Changed 8 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

If you test #5453 or #5454 this comes along for the ride.

comment:23 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:24 Changed 8 years ago by Andrei Savici

Tested as part of DGSReduction

comment:25 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:26 Changed 8 years ago by Michael Reuter

Refs #5453, #5623 and #5655. Trying to save proc detvan.

Changeset: cfd366cd0c7d007a65c687322fba987e51d85e83

comment:27 Changed 8 years ago by Michael Reuter

Refs #5623. Updating formatting.

Changeset: 46e600f3d3f1b6ed066900c850020be0ebdc0479

comment:28 Changed 8 years ago by Michael Reuter

Refs #5623. Fixing bug when no incident beam norm.

Changeset: 42fd1ccffe1a18739cc3a13c5bf0a2cde9ec863a

comment:29 Changed 8 years ago by Michael Reuter

Refs #5623. Fixes for property issues.

Changeset: 630b15a4467921a91fc0cd8cf42e2e5b45181a85

comment:30 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655, #5678 and #5855. Workspace prop changes.

Lots of changes relating to output workspace space properties. Handling them in a consistent manner across all algorithms.

Changeset: 3cd13c6414d1262092dc84a299c447076e0155ed

comment:31 Changed 8 years ago by Michael Reuter

Refs #5623. Removing unneeded code.

Changeset: 5d02feadf82a6a2860f1640fd2937b3eeceea803

comment:32 Changed 8 years ago by Michael Reuter

Refs #5623. Fixed bug in parameter check.

Changeset: f42b776383bb391073f439c3d352b588fbbee225

comment:33 Changed 8 years ago by Michael Reuter

Refs #5605 and #5623. Passing TOF bin offset as algorithm param.

Changeset: e26d8243f52b0a5974b166d91ba471dcec0f7af0

comment:34 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655 and #5678. Removing enable history calls.

Changeset: 462c15295188e4fb197e7547417d7a8a86ea1a5f

comment:35 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5623, #5655 and #5678. More changes.

comment:36 Changed 8 years ago by Michael Reuter

Refs #5623, #5655 and #5678. Using new helper function.

Changeset: 0375945966842fffed2c14440165eb2f62b32516

comment:37 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6469

Note: See TracTickets for help on using tickets.