Investigate CloneMDWorkspace

[Michael Reuter]

There seems to be an issue in CloneMDWorkspace. Using the script in #5292 and running CompareMDWorkspaces shows that the two resulting workspaces are not truly identical. The cloner should produce identical workspaces.

[Nick Draper]

Moved to milestone 2.4

[Alex Buts]

refs #5697 This should fix it

The volume calculations rearranged in the way to decrease the round-off errors. Intermediate volume calculations in copy constructor have been disabled.

Changeset: 1a17249a20ef05be650d1edd2998c05a9d654a64

[Alex Buts]

To tester:

The script which was failing before (see below) runs now. Really picky tester should try cloning different MD workspaces.

from mantid.simpleapi import *

A = CreateMDWorkspace(Dimensions='4',Extents='0,1,0,1,0,1,0,1',Names='A,B,C,T',Units='U,U,U,S')
FakeMDEventData(InputWorkspace='A',UniformParams='100000',RandomizeSignal='1')
B = CloneMDWorkspace(InputWorkspace='A')
result = CheckWorkspacesMatch(Workspace1=A, Workspace2=B)
if not result == "Success!":
        print result
        raise RuntimeError("Expected result to be 'success'")

[Alex Buts]

refs #5697 Temporary disabling failing tests to fix build

Changeset: be4ae82d0a313105db920a30b7e3456855e27585

[Alex Buts]

refs #5697 more tests disabled

Changeset: 0bb2fed087066a4ae0fff0e070f4f302737865f1

[Alex Buts]

refs #5697 Fixing error with inverse volume calculations

There was hidden error with inverse volume calculation which become apparent when volume calculation has been removed from copy constructor.

Changeset: eaf0af19497ecec4d09d7f8735b9a0ccbd4b33e4

[Alex Buts]

refs #5697 enabling tests failing due to volume problems

Changeset: 1024eeaf5e834e9c312bb441b14d3201ba469b2b

[Alex Buts]

refs #5697 fixed and enabled all MDGridBoxTests disabled earlier

Changeset: 1bb379b3819881026161c57300a3040d7899d0c0

[Alex Buts]

refs #5697 fixing induced error with MD workspace extents

and enabling corresponding tests

Changeset: 39fc72842bd79adfbed59b4ff93ea3fee0b02335

[Alex Buts]

refs #5697 fixed and enabled last failing test

Changeset: 61afd62be22d1fdcc2a0a46c0822a7454a3f02eb

[Alex Buts]

Ok, ticket is resolved and cloned workspace should be identical to a original workspace. The error propagation problem remains (attempted to be addressed by some of these changes) but this is the subject for another ticket.

[Alex Buts]

refs #5697 This should fix it

The volume calculations rearranged in the way to decrease the round-off errors. Intermediate volume calculations in copy constructor have been disabled.

Changeset: 1a17249a20ef05be650d1edd2998c05a9d654a64

[Alex Buts]

refs #5697 Temporary disabling failing tests to fix build

Changeset: be4ae82d0a313105db920a30b7e3456855e27585

[Alex Buts]

refs #5697 more tests disabled

Changeset: 0bb2fed087066a4ae0fff0e070f4f302737865f1

[Alex Buts]

refs #5697 Fixing error with inverse volume calculations

There was hidden error with inverse volume calculation which become apparent when volume calculation has been removed from copy constructor.

Changeset: eaf0af19497ecec4d09d7f8735b9a0ccbd4b33e4

[Alex Buts]

refs #5697 enabling tests failing due to volume problems

Changeset: 1024eeaf5e834e9c312bb441b14d3201ba469b2b

[Alex Buts]

refs #5697 fixed and enabled all MDGridBoxTests disabled earlier

Changeset: 1bb379b3819881026161c57300a3040d7899d0c0

[Alex Buts]

refs #5697 fixing induced error with MD workspace extents

and enabling corresponding tests

Changeset: 39fc72842bd79adfbed59b4ff93ea3fee0b02335

[Alex Buts]

refs #5697 fixing stupid Unix warnings.

Changeset: 99226db329899278274a772930e58b6d652052d0

[Alex Buts]

refs #5697 enabled LoadMDTest

Changeset: c51bf1041d90bef19558773bc8c781ced9c9e84d

[Alex Buts]

refs #5697 fixed and enabled last failing test

Changeset: 61afd62be22d1fdcc2a0a46c0822a7454a3f02eb

[Martyn Gigg]

Results look sensible now.

Is there a ticket number for the errors issue, I couldn't see one?

[Stuart Campbell]

This ticket has been transferred to github issue ​6543