Ticket #5697 (closed: fixed)
Investigate CloneMDWorkspace
Reported by: | Michael Reuter | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | Release 2.4 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
There seems to be an issue in CloneMDWorkspace. Using the script in #5292 and running CompareMDWorkspaces shows that the two resulting workspaces are not truly identical. The cloner should produce identical workspaces.
Change History
comment:2 Changed 8 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Alex Buts
comment:4 Changed 8 years ago by Alex Buts
refs #5697 This should fix it
The volume calculations rearranged in the way to decrease the round-off errors. Intermediate volume calculations in copy constructor have been disabled.
Changeset: 1a17249a20ef05be650d1edd2998c05a9d654a64
comment:5 Changed 8 years ago by Alex Buts
To tester:
The script which was failing before (see below) runs now. Really picky tester should try cloning different MD workspaces.
from mantid.simpleapi import * A = CreateMDWorkspace(Dimensions='4',Extents='0,1,0,1,0,1,0,1',Names='A,B,C,T',Units='U,U,U,S') FakeMDEventData(InputWorkspace='A',UniformParams='100000',RandomizeSignal='1') B = CloneMDWorkspace(InputWorkspace='A') result = CheckWorkspacesMatch(Workspace1=A, Workspace2=B) if not result == "Success!": print result raise RuntimeError("Expected result to be 'success'")
comment:6 Changed 8 years ago by Alex Buts
refs #5697 Temporary disabling failing tests to fix build
Changeset: be4ae82d0a313105db920a30b7e3456855e27585
comment:7 Changed 8 years ago by Alex Buts
refs #5697 more tests disabled
Changeset: 0bb2fed087066a4ae0fff0e070f4f302737865f1
comment:8 Changed 8 years ago by Alex Buts
refs #5697 Fixing error with inverse volume calculations
There was hidden error with inverse volume calculation which become apparent when volume calculation has been removed from copy constructor.
Changeset: eaf0af19497ecec4d09d7f8735b9a0ccbd4b33e4
comment:9 Changed 8 years ago by Alex Buts
refs #5697 enabling tests failing due to volume problems
Changeset: 1024eeaf5e834e9c312bb441b14d3201ba469b2b
comment:10 Changed 8 years ago by Alex Buts
refs #5697 fixed and enabled all MDGridBoxTests disabled earlier
Changeset: 1bb379b3819881026161c57300a3040d7899d0c0
comment:11 Changed 8 years ago by Alex Buts
refs #5697 fixing induced error with MD workspace extents
and enabling corresponding tests
Changeset: 39fc72842bd79adfbed59b4ff93ea3fee0b02335
comment:12 Changed 8 years ago by Alex Buts
refs #5697 fixed and enabled last failing test
Changeset: 61afd62be22d1fdcc2a0a46c0822a7454a3f02eb
comment:13 Changed 8 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
Ok, ticket is resolved and cloned workspace should be identical to a original workspace. The error propagation problem remains (attempted to be addressed by some of these changes) but this is the subject for another ticket.
comment:14 Changed 8 years ago by Alex Buts
refs #5697 This should fix it
The volume calculations rearranged in the way to decrease the round-off errors. Intermediate volume calculations in copy constructor have been disabled.
Changeset: 1a17249a20ef05be650d1edd2998c05a9d654a64
comment:15 Changed 8 years ago by Alex Buts
refs #5697 Temporary disabling failing tests to fix build
Changeset: be4ae82d0a313105db920a30b7e3456855e27585
comment:16 Changed 8 years ago by Alex Buts
refs #5697 more tests disabled
Changeset: 0bb2fed087066a4ae0fff0e070f4f302737865f1
comment:17 Changed 8 years ago by Alex Buts
refs #5697 Fixing error with inverse volume calculations
There was hidden error with inverse volume calculation which become apparent when volume calculation has been removed from copy constructor.
Changeset: eaf0af19497ecec4d09d7f8735b9a0ccbd4b33e4
comment:18 Changed 8 years ago by Alex Buts
refs #5697 enabling tests failing due to volume problems
Changeset: 1024eeaf5e834e9c312bb441b14d3201ba469b2b
comment:19 Changed 8 years ago by Alex Buts
refs #5697 fixed and enabled all MDGridBoxTests disabled earlier
Changeset: 1bb379b3819881026161c57300a3040d7899d0c0
comment:20 Changed 8 years ago by Alex Buts
refs #5697 fixing induced error with MD workspace extents
and enabling corresponding tests
Changeset: 39fc72842bd79adfbed59b4ff93ea3fee0b02335
comment:21 Changed 8 years ago by Alex Buts
refs #5697 fixing stupid Unix warnings.
Changeset: 99226db329899278274a772930e58b6d652052d0
comment:22 Changed 8 years ago by Alex Buts
refs #5697 enabled LoadMDTest
Changeset: c51bf1041d90bef19558773bc8c781ced9c9e84d
comment:23 Changed 8 years ago by Alex Buts
refs #5697 fixed and enabled last failing test
Changeset: 61afd62be22d1fdcc2a0a46c0822a7454a3f02eb
comment:24 Changed 8 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:25 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to closed
Results look sensible now.
Is there a ticket number for the errors issue, I couldn't see one?
comment:26 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6543
Moved to milestone 2.4