Ticket #5705 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

SaveFocusedXYE fails if instrument cannot find a detector

Reported by: Roman Tolchenov Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description


Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:4 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:5 Changed 7 years ago by Roman Tolchenov

Skip spectra that cannot be saved. Re #5705.

Changeset: 03eb464eabe741e1a008bdbf8f6ac30b6aa7ac55

comment:6 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

To tester

branch bugfix/5705_savefocusedxye

Load file HRP38692a.nxs into a workspace then save it with SaveFocusedXYE. There should be a couple of warnings that a spectrum was skipped. The algorithm shouldn't fail and the output file should be created.

comment:7 Changed 7 years ago by Roman Tolchenov

Skip spectra that cannot be saved. Re #5705.

Changeset: 03eb464eabe741e1a008bdbf8f6ac30b6aa7ac55

comment:8 Changed 7 years ago by Roman Tolchenov

Skip spectra that cannot be saved. Re #5705.

Changeset: 03eb464eabe741e1a008bdbf8f6ac30b6aa7ac55

comment:9 Changed 7 years ago by Roman Tolchenov

Skip spectra that cannot be saved. Re #5705.

Changeset: 03eb464eabe741e1a008bdbf8f6ac30b6aa7ac55

comment:10 Changed 7 years ago by Roman Tolchenov

Skip spectra that cannot be saved. Re #5705.

Changeset: 03eb464eabe741e1a008bdbf8f6ac30b6aa7ac55

comment:11 Changed 7 years ago by Roman Tolchenov

Skip spectra that cannot be saved. Re #5705.

Changeset: 03eb464eabe741e1a008bdbf8f6ac30b6aa7ac55

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:13 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The change appears to have the intended effect, though I don't know whether skipping is the right thing to do (it appears to only matter if headers are being written).

However, a couple of things need fixing:

  • Just catching all exceptions is lazy - it should catch the relevant one (NotFoundError, I think).
  • New unit test should not load data files. It should be trivial to use create2DWorkspaceWithFullInstrument and knock the detector off a spectrum or two.

comment:14 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:15 Changed 7 years ago by Roman Tolchenov

Merge branch 'bugfix/5705_savefocusedxye' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:16 Changed 7 years ago by Roman Tolchenov

Merge branch 'bugfix/5705_savefocusedxye' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:17 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:18 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:19 Changed 7 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.0

moved to Release 3.0 as these all seem to be active

comment:20 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:21 Changed 7 years ago by Samuel Jackson

  • Owner changed from Roman Tolchenov to Samuel Jackson

comment:22 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Refs #5705 Catch relevant exception.

Changeset: 528a5459f1a67f6a3ff29a4c30002b805d92c435

comment:23 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

I've added the relevant exception and created ticket #8227 to deal with the unit test issue.

Tester: See above.

comment:24 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester changed from Russell Taylor to Nick Draper

comment:25 Changed 7 years ago by Nick Draper

Change accepted, new ticket checked, functionality double checked

comment:26 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/5705_savefocusedxye'

Full changeset: ​3f86a08113a8741528405d90a34f478eebfbc037

comment:27 Changed 7 years ago by Roman Tolchenov

Skip spectra that cannot be saved. Re #5705.

Changeset: e5d5534c166ba1f175b76368bc757894eb22dee6

comment:28 Changed 7 years ago by Samuel Jackson

Refs #5705 Catch relevant exception.

Changeset: f3722f851834ddca3146435e80798b63552c346e

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6551

Note: See TracTickets for help on using tickets.