Ticket #5728 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Calling the cell(row, column) method on a TableWorkspace from python doesn't check the row for validity

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Release 2.2
Component: Python Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

The column value is checked, but you can put anything in the row argument (even a negative number) and it will return a garbage value or even crash Mantid.

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Russell Taylor

Re #5728. Use range-checking method of std::vector for safety.

Changeset: ed5eff5147426807ccc022daafe41a2d172353cb

comment:3 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Now you'll get a range error if the row is invalid.

comment:4 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:5 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to closed

Works for a TableWorkspace, but not a PeaksWorkspace. This should be a ticket for next release.

comment:6 Changed 8 years ago by Russell Taylor

Created #5729 for the PeaksWorkspace issue.

comment:7 Changed 8 years ago by Russell Taylor

Re #5728. Use range-checking method of std::vector for safety.

Changeset: ed5eff5147426807ccc022daafe41a2d172353cb

comment:8 Changed 8 years ago by Russell Taylor

Re #5728. Use range-checking method of std::vector for safety.

Changeset: ed5eff5147426807ccc022daafe41a2d172353cb

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6574

Note: See TracTickets for help on using tickets.