Ticket #5729 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

PeakColumn unimplemented methods

Reported by: Russell Taylor Owned by: Martyn Gigg
Priority: minor Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #6223 Tester: Stuart Campbell

Description

If you get hold of a PeaksWorkspace in python and try to do something like 

workspace.cell(1,1)

you get back 

RuntimeError: const version of void_pointer() not implemented. Looks to be unused?

Implement this method and check whether other unimplemented methods in this and other Peaks workspace classes should/could be implemented.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:2 Changed 8 years ago by Nick Draper

  • Owner set to Martyn Gigg
  • Status changed from new to assigned

comment:3 Changed 8 years ago by Martyn Gigg

  • Blocking 6223 added

comment:4 Changed 8 years ago by Martyn Gigg

  • Status changed from assigned to accepted

comment:5 Changed 8 years ago by Martyn Gigg

Implement relevant PeakColumn methods from table API. Refs #5729

Changeset: 34c4b58e2299b6ae884a40c6c958cef4f1e47020

comment:6 Changed 8 years ago by Martyn Gigg

Fix OS X build. Refs #5729

Changeset: 9bee49cda0dc168b9f9da3293df0c2f83d241ced

comment:7 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: The following script should no longer raise an error relating to the void_pointer method. 

LoadEventNexus(Filename=r'TOPAZ_3132_event.nxs',OutputWorkspace='TOPAZ_3131_nxs')
ConvertToDiffractionMDWorkspace(InputWorkspace='TOPAZ_3131_nxs',OutputWorkspace='TOPAZ_3131_md',LorentzCorrection='1')
FindPeaksMD(InputWorkspace='TOPAZ_3131_md',PeakDistanceThreshold='0.15',MaxPeaks='100',OutputWorkspace='peaks')

peaks_ws = mtd['peaks']

print peaks_ws.cell(0,0)
print peaks_ws.cell(2,5)

comment:8 Changed 8 years ago by Russell Taylor

Re #5729. Add critical section around filling of static variable.

Need for this highlighted by performance test failure (GetDetOffsetsMultiPeaksTestPerformance).

Changeset: f45a43325db5d399fa487680132a891fa87b6d9e

comment:9 Changed 8 years ago by Martyn Gigg

Add more info to debug message. Refs #5729

Changeset: 3591f3366bfa772a93d7aefae0e4b676ad0ca628

comment:10 Changed 8 years ago by Martyn Gigg

Avoid threading issue in PeakColumn map initialisation. Refs #5729

Should stop GetDetOffsetsMultiPeaks performance test from failing sporadically.

Changeset: 8a2fb4ec7519f8cacb0c0aacee8455ebc7f82fe2

comment:11 Changed 8 years ago by Martyn Gigg

Implement relevant PeakColumn methods from table API. Refs #5729

Changeset: 34c4b58e2299b6ae884a40c6c958cef4f1e47020

comment:12 Changed 8 years ago by Martyn Gigg

Fix OS X build. Refs #5729

Changeset: 9bee49cda0dc168b9f9da3293df0c2f83d241ced

comment:13 Changed 8 years ago by Russell Taylor

Re #5729. Add critical section around filling of static variable.

Need for this highlighted by performance test failure (GetDetOffsetsMultiPeaksTestPerformance).

Changeset: f45a43325db5d399fa487680132a891fa87b6d9e

comment:14 Changed 8 years ago by Martyn Gigg

Add more info to debug message. Refs #5729

Changeset: 3591f3366bfa772a93d7aefae0e4b676ad0ca628

comment:15 Changed 8 years ago by Martyn Gigg

Avoid threading issue in PeakColumn map initialisation. Refs #5729

Should stop GetDetOffsetsMultiPeaks performance test from failing sporadically.

Changeset: 8a2fb4ec7519f8cacb0c0aacee8455ebc7f82fe2

comment:16 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:17 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Python code snippet works ok.

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6575

Note: See TracTickets for help on using tickets.