Ticket #5772 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Update IntegratePeakTimeSlices to better deal with weaker and edge peaks

Reported by: Ruth Mikkelson Owned by: Ruth Mikkelson
Priority: minor Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

The current form has been specifically tweaked to deal well with strong peaks.

The update will now accept weaker time slices and also attempt to merge bad time slices with an adjacent good time slice.

The intensity and errors for edge peaks should be a combination of the Fitted values and the actual sample values.

Attachments

IntegrPkTimeSliceReport1_2013.txt​ (1.7 KB) - added by Ruth Mikkelson 8 years ago.
GSAS Results Jan 2013

Change History

comment:1 Changed 8 years ago by Ruth Mikkelson

  • Status changed from new to accepted
  • Owner set to Ruth Mikkelson

comment:2 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Initial update of code for new features

Changeset: 6f5e528715d9b260d41648e69268d47c08c5fdbf

comment:3 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Updated test programs, eliminated warning

Changeset: a0c71e8c79773a974e21cd14bcd8bac1cfeade49

comment:4 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Increased delta so test may pass

Changeset: a4c5edfd68ebe30cdbd1d351820830d068276528

comment:5 Changed 8 years ago by Ruth Mikkelson

Refs #5772 eliminated some boost imports

Changeset: 16b1ff1749b50c6ead808cd1d1ebcab8af648273

comment:6 Changed 8 years ago by Ruth Mikkelson

Refs #5772 Updated another delta for test to work on Windows

Changeset: 6d3f30b6c671752475be52a5a1b9ab18edfe63e2

comment:7 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Fixed error and documentation. Added consts

Changeset: 58213ef86ebbf6ac8ec97b466124abe9c6ee7fa3

comment:8 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Elim error in case of no data

Changeset: 5d8595dc0b7ebecaab82e54f0d98df72512ccef5

comment:9 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Initial update of code for new features

Changeset: 6f5e528715d9b260d41648e69268d47c08c5fdbf

comment:10 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Updated test programs, eliminated warning

Changeset: a0c71e8c79773a974e21cd14bcd8bac1cfeade49

comment:11 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Increased delta so test may pass

Changeset: a4c5edfd68ebe30cdbd1d351820830d068276528

comment:12 Changed 8 years ago by Ruth Mikkelson

Refs #5772 eliminated some boost imports

Changeset: 16b1ff1749b50c6ead808cd1d1ebcab8af648273

comment:13 Changed 8 years ago by Ruth Mikkelson

Refs #5772 Updated another delta for test to work on Windows

Changeset: 6d3f30b6c671752475be52a5a1b9ab18edfe63e2

comment:14 Changed 8 years ago by Ruth Mikkelson

Refs #5772 Fixed some errors

Changeset: 60f1a1a97fe4c88f9c70958881e30e0e399e3e25

comment:15 Changed 8 years ago by Ruth Mikkelson

Refs #5772 Tweaked cutoffs, etc., to better match ISAW results

Changeset: cd737593aba4ebfc049a003f18be6aaa2c348a11

comment:16 Changed 8 years ago by Russell Taylor

Re #5772. Clear OSX/Intel compiler warning.

Changeset: 0cfd9b4f2233851096a09b25a2ad1011308d1daa

comment:17 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:18 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:19 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to verify
  • Tester Vickie Lynch deleted

comment:20 Changed 8 years ago by Ruth Mikkelson

  • Status changed from verify to reopened
  • Resolution fixed deleted

Will reopen. Further testing is needed for edge peaks.

comment:21 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Still reopened on the day of release for Release 2.3. We cannot hold the release for a minor priority ticket. Moved to release 2.4

comment:22 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Fixed error and documentation. Added consts

Changeset: 58213ef86ebbf6ac8ec97b466124abe9c6ee7fa3

comment:23 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Elim error in case of no data

Changeset: 5d8595dc0b7ebecaab82e54f0d98df72512ccef5

comment:24 Changed 8 years ago by Ruth Mikkelson

Refs #5772 Fixed some errors

Changeset: 60f1a1a97fe4c88f9c70958881e30e0e399e3e25

comment:25 Changed 8 years ago by Ruth Mikkelson

Refs #5772 Tweaked cutoffs, etc., to better match ISAW results

Changeset: cd737593aba4ebfc049a003f18be6aaa2c348a11

comment:26 Changed 8 years ago by Russell Taylor

Re #5772. Clear OSX/Intel compiler warning.

Changeset: 0cfd9b4f2233851096a09b25a2ad1011308d1daa

comment:27 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Tweaked code to get edge peaks integrated better

Changeset: 4d5e02352f51c15696ba39c4add9af63cb3750da

comment:28 Changed 8 years ago by Ruth Mikkelson

Refs #5772 Tweaked to improve GSAS results

This is for both interior peaks and Edge peaks. Interior peaks now give GSAS results matching the best results from other methods. The Edge pixels are now not terrible, but still could need improvements.

Changeset: f323f15f24f6ce71d96de59dc0857c3e4d931095

comment:29 Changed 8 years ago by Ruth Mikkelson

  • Status changed from reopened to accepted

comment:30 Changed 8 years ago by Ruth Mikkelson

Refs #5772. Tweaked code to get edge peaks integrated better

Changeset: 4d5e02352f51c15696ba39c4add9af63cb3750da

comment:31 Changed 8 years ago by Ruth Mikkelson

Refs #5772 Tweaked to improve GSAS results

This is for both interior peaks and Edge peaks. Interior peaks now give GSAS results matching the best results from other methods. The Edge pixels are now not terrible, but still could need improvements.

Changeset: f323f15f24f6ce71d96de59dc0857c3e4d931095

comment:32 Changed 8 years ago by Ruth Mikkelson

Refs #5772 Improved results for peaks closer to the edge.

Peaks right on the edge of a panel are still off a lot.

Changeset: 4ffded53e1cc28cd8f36634ff3393cb854996bf6

Changed 8 years ago by Ruth Mikkelson

GSAS Results Jan 2013

comment:33 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to wontfix

comment:34 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:35 Changed 8 years ago by Nick Draper

This is not really a wontfix, as there is a lot of implmented code changes recorded in this ticket. Rather it is a "won't fix any more than I have already done, because it is good enough", however that is too long, so I'll adjust the status to fixed.

comment:36 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed
  • Resolution changed from wontfix to fixed
  • Tester Nick Draper deleted

comment:37 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6618

Note: See TracTickets for help on using tickets.