Ticket #5775 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

LoadEventNexus log filter by time fix

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

FilterByStartTime and FilterByEndTime properties on the LoadEventNexus algorithm are not being applied to the log filtering.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold 

metadataonly = False
ws = Load(Filename='CNCS_7860_event.nxs',MetaDataOnly=metadataonly,FilterByTimeStart='1',FilterByTimeStop='1000')
nlogs = ws.run().getLogData('SampleTemp').size()
print nlogs

correctly reports 14 entries by applying the filtering. Setting metadataonly to True, yields all 16 entries. This is wrong!

Last edited 8 years ago by Owen Arnold (previous) (diff)

comment:3 Changed 8 years ago by Owen Arnold

refs #5775. Add failing test case.

Changeset: 152b2de90fc48d004b8f0c8cd36c7befc365424e

comment:4 Changed 8 years ago by Owen Arnold

refs #5775. Fix failing test case and issue in general.

Changeset: 2202e030c029cbedb24ec15fb24e632d5bf40b2d

comment:5 Changed 8 years ago by Owen Arnold

The fix utilised here was simply to reshuffle the imperative order of execution such that the log time filtering was applied before forking the execution paths between metadataonly and full event loading.

comment:6 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 8 years ago by Owen Arnold

refs #5775. Fix warning in test.

Changeset: cfe2a8a93b118b9cf945563d466c01aa16b497ca

comment:8 Changed 8 years ago by Owen Arnold

refs #5775. Add failing test case.

Changeset: 152b2de90fc48d004b8f0c8cd36c7befc365424e

comment:9 Changed 8 years ago by Owen Arnold

refs #5775. Fix failing test case and issue in general.

Changeset: 2202e030c029cbedb24ec15fb24e632d5bf40b2d

comment:10 Changed 8 years ago by Owen Arnold

refs #5775. Fix warning in test.

Changeset: cfe2a8a93b118b9cf945563d466c01aa16b497ca

comment:11 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:12 Changed 8 years ago by Nick Draper

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The script above reports 14 for both now, however none of the filtered vaules are anywhere near the time filtering range. What is happening?

comment:13 Changed 8 years ago by Owen Arnold

  • Status changed from reopened to accepted

Should be filtering correctly now after Wenduo's changes yesterday.

comment:14 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 8 years ago by Nick Draper

Wenduo's changes are under the seperate ticket #6037

comment:16 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying

comment:17 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

Given the specific failure is now a separate ticket #6037 then this one passes

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6621

Note: See TracTickets for help on using tickets.