Ticket #5776 (closed: fixed)
ConvertToReflectometryQ copy experiment info
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | major | Milestone: | Release 2.3 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Gesner Passos |
Description
Cannot determine experiment info at the moment, including sample log data after conversion. This makes it impossible to use the new MultiPeriodGroupWorspace processing base class correctly.
Need to ensure that the experiment info is getting copied across.
Change History
comment:2 Changed 8 years ago by Owen Arnold
refs #5776. Copy across exp info and test
Changeset: ca846b9be0af01073877c2fe5af3132a6b3ee5b0
comment:3 Changed 8 years ago by Owen Arnold
refs #5754 #5744 #5776. Apply MultiPeriodGroupAlgorithm.
Note that there are some minor modifications to the accessibility of some of the member functions on the Algorithm class. This is to facilitate reuse with the MultiPeriodGroupAlgorithm sub-class, which requires similar functionality.
Changeset: 91be973779562c34fee50da5890960e518d0fba5
comment:4 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
comment:5 Changed 8 years ago by Owen Arnold
Tester: run ConvertToReflectometryQ (see ReflectometryISIS.py system test for help). Ensure that the log data is the same on the original input workspace as on the output workspace.
comment:6 Changed 8 years ago by Owen Arnold
refs #5776. Copy across exp info and test
Changeset: ca846b9be0af01073877c2fe5af3132a6b3ee5b0
comment:7 Changed 8 years ago by Owen Arnold
refs #5754 #5744 #5776. Apply MultiPeriodGroupAlgorithm.
Note that there are some minor modifications to the accessibility of some of the member functions on the Algorithm class. This is to facilitate reuse with the MultiPeriodGroupAlgorithm sub-class, which requires similar functionality.
Changeset: 91be973779562c34fee50da5890960e518d0fba5
comment:8 Changed 8 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:9 Changed 8 years ago by Gesner Passos
- Status changed from verifying to closed
As long I was not able to test the way i thought initially (ticket #6060), I checked that applying the ConvertToReflectometryQ, the initial workspace and the final workspace have equivalent 'Sample Logs ... ' (Right-click workspace menu). Assuming that to having the same Sample Logs implies in having the same LogData, this ticket passed.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6622