Ticket #5782 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Unit tests needed for CopyInstrumentParameters Algorithm

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Karl Palmen) (diff)

There'll need to be a test to successfully transfer a simple instrument whose parameters have been modified and see that the modified parameters show up in the output workspace.

Also a test to show it throws an exception if the output workspace has a different base instrument to the input workspace.

Finally ExperimentInfo may need a test for its new function replaceInstrument. This could be very simple, because the algorithm test would test its functionality.

TransferInstrument was created in ticket #5670 (and renamed CopyInstrumentParameters in #5904)

Change History

comment:1 Changed 8 years ago by Karl Palmen

  • Status changed from new to assigned
  • Owner set to Karl Palmen

comment:2 Changed 8 years ago by Karl Palmen

  • Cc anders.markvardsen@… added

comment:3 Changed 8 years ago by Anders Markvardsen

  • Priority changed from major to critical

comment:4 Changed 8 years ago by Karl Palmen

This is best done after renaming as in ticket #5904

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:6 Changed 8 years ago by Martyn Gigg

  • Description modified (diff)
  • Summary changed from Unit tests needed for TransferInstrument Algorithm to Unit tests needed for CopyInstrumentParameters Algorithm

comment:7 Changed 8 years ago by Karl Palmen

  • Milestone changed from Release 2.4 to Release 2.5

comment:8 Changed 7 years ago by Karl Palmen

  • Description modified (diff)

comment:9 Changed 7 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:10 Changed 7 years ago by Karl Palmen

skeleton test re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1d6d86a2596ca9598464c6b4b44e0e394cbb8ab0

comment:11 Changed 7 years ago by Karl Palmen

Add workspaces and test properties with them re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f6e0fbb531be0cfdb7ce686f1414baf59e124e13

comment:12 Changed 7 years ago by Karl Palmen

skeleton test re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1d6d86a2596ca9598464c6b4b44e0e394cbb8ab0

comment:13 Changed 7 years ago by Karl Palmen

Add workspaces and test properties with them re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f6e0fbb531be0cfdb7ce686f1414baf59e124e13

comment:14 Changed 7 years ago by Karl Palmen

Completer TestExec re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5f14a2dce2804decabd0e6ff2f6fd7c73aef0026

comment:15 Changed 7 years ago by Karl Palmen

Completer TestExec re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5f14a2dce2804decabd0e6ff2f6fd7c73aef0026

comment:16 Changed 7 years ago by Karl Palmen

Add test for exception if base instruments are different re #5782

Also in previous test, verified to two workspaces do have different instruments, even though the base instrument is the same.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6b555d89f51289e99fccd307ab10d23fe81633f

comment:17 Changed 7 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test, look at the code to check that CopyInstrumentPsarametersTest.h exists and actually tests the CopyInstrumentParameters algorithm.

comment:18 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:19 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The tests look fine and the they pass. The only thing that needs improving is that the temporary workspaces that have been created should be removed at the end of the test. This makes sure that things are as clean as possible when run in conjunction with other tests.

Something like dataStore.remove(wsName1) etc will do the trick.

comment:20 Changed 7 years ago by Karl Palmen

  • Status changed from reopened to accepted

comment:21 Changed 7 years ago by Karl Palmen

Remove workspaces after use re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b8366187852dd8e3424db2762c439e38e18f99fd

comment:22 Changed 7 years ago by Karl Palmen

Remove workspaces after use re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b8366187852dd8e3424db2762c439e38e18f99fd

comment:23 Changed 7 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:24 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester changed from Martyn Gigg to Owen Arnold

comment:25 Changed 7 years ago by Karl Palmen

skeleton test re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1d6d86a2596ca9598464c6b4b44e0e394cbb8ab0

comment:26 Changed 7 years ago by Karl Palmen

Add workspaces and test properties with them re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f6e0fbb531be0cfdb7ce686f1414baf59e124e13

comment:27 Changed 7 years ago by Karl Palmen

Completer TestExec re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5f14a2dce2804decabd0e6ff2f6fd7c73aef0026

comment:28 Changed 7 years ago by Karl Palmen

Add test for exception if base instruments are different re #5782

Also in previous test, verified to two workspaces do have different instruments, even though the base instrument is the same.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6b555d89f51289e99fccd307ab10d23fe81633f

comment:29 Changed 7 years ago by Karl Palmen

Remove workspaces after use re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b8366187852dd8e3424db2762c439e38e18f99fd

comment:30 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Tests pass. Changes suggest that issue raised by Martyn has been addressed.

comment:31 Changed 7 years ago by Karl Palmen

skeleton test re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1d6d86a2596ca9598464c6b4b44e0e394cbb8ab0

comment:32 Changed 7 years ago by Karl Palmen

Add workspaces and test properties with them re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f6e0fbb531be0cfdb7ce686f1414baf59e124e13

comment:33 Changed 7 years ago by Karl Palmen

Completer TestExec re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5f14a2dce2804decabd0e6ff2f6fd7c73aef0026

comment:34 Changed 7 years ago by Karl Palmen

Add test for exception if base instruments are different re #5782

Also in previous test, verified to two workspaces do have different instruments, even though the base instrument is the same.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6b555d89f51289e99fccd307ab10d23fe81633f

comment:35 Changed 7 years ago by Karl Palmen

Remove workspaces after use re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b8366187852dd8e3424db2762c439e38e18f99fd

comment:36 Changed 7 years ago by Karl Palmen

skeleton test re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1d6d86a2596ca9598464c6b4b44e0e394cbb8ab0

comment:37 Changed 7 years ago by Karl Palmen

Add workspaces and test properties with them re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f6e0fbb531be0cfdb7ce686f1414baf59e124e13

comment:38 Changed 7 years ago by Karl Palmen

Completer TestExec re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5f14a2dce2804decabd0e6ff2f6fd7c73aef0026

comment:39 Changed 7 years ago by Karl Palmen

Add test for exception if base instruments are different re #5782

Also in previous test, verified to two workspaces do have different instruments, even though the base instrument is the same.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6b555d89f51289e99fccd307ab10d23fe81633f

comment:40 Changed 7 years ago by Karl Palmen

Remove workspaces after use re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b8366187852dd8e3424db2762c439e38e18f99fd

comment:41 Changed 7 years ago by Karl Palmen

skeleton test re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1d6d86a2596ca9598464c6b4b44e0e394cbb8ab0

comment:42 Changed 7 years ago by Karl Palmen

Add workspaces and test properties with them re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f6e0fbb531be0cfdb7ce686f1414baf59e124e13

comment:43 Changed 7 years ago by Karl Palmen

Completer TestExec re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5f14a2dce2804decabd0e6ff2f6fd7c73aef0026

comment:44 Changed 7 years ago by Karl Palmen

Add test for exception if base instruments are different re #5782

Also in previous test, verified to two workspaces do have different instruments, even though the base instrument is the same.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6b555d89f51289e99fccd307ab10d23fe81633f

comment:45 Changed 7 years ago by Karl Palmen

Remove workspaces after use re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b8366187852dd8e3424db2762c439e38e18f99fd

comment:46 Changed 7 years ago by Karl Palmen

skeleton test re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1d6d86a2596ca9598464c6b4b44e0e394cbb8ab0

comment:47 Changed 7 years ago by Karl Palmen

Add workspaces and test properties with them re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f6e0fbb531be0cfdb7ce686f1414baf59e124e13

comment:48 Changed 7 years ago by Karl Palmen

Completer TestExec re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5f14a2dce2804decabd0e6ff2f6fd7c73aef0026

comment:49 Changed 7 years ago by Karl Palmen

Add test for exception if base instruments are different re #5782

Also in previous test, verified to two workspaces do have different instruments, even though the base instrument is the same.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6b555d89f51289e99fccd307ab10d23fe81633f

comment:50 Changed 7 years ago by Karl Palmen

Remove workspaces after use re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b8366187852dd8e3424db2762c439e38e18f99fd

comment:51 Changed 7 years ago by Karl Palmen

skeleton test re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1d6d86a2596ca9598464c6b4b44e0e394cbb8ab0

comment:52 Changed 7 years ago by Karl Palmen

Add workspaces and test properties with them re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f6e0fbb531be0cfdb7ce686f1414baf59e124e13

comment:53 Changed 7 years ago by Karl Palmen

Completer TestExec re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5f14a2dce2804decabd0e6ff2f6fd7c73aef0026

comment:54 Changed 7 years ago by Karl Palmen

Add test for exception if base instruments are different re #5782

Also in previous test, verified to two workspaces do have different instruments, even though the base instrument is the same.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6b555d89f51289e99fccd307ab10d23fe81633f

comment:55 Changed 7 years ago by Karl Palmen

Remove workspaces after use re #5782

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b8366187852dd8e3424db2762c439e38e18f99fd

comment:56 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6628

Note: See TracTickets for help on using tickets.