Ticket #5857 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Properly handle run start & run stop notifications from SMS

Reported by: Ross Miller Owned by: Ross Miller
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

We had been mostly ignoring these messages until now.

Change History

comment:1 Changed 8 years ago by Ross Miller

Parse the RunStatus packet for run start and run stop info

Refs #5857

Changeset: 963cfe4b2fd54b347afe626fdc2ae018b77fc4c7

comment:2 Changed 8 years ago by Ross Miller

Add a run_number property to workspaces from the live event listener

Refs #5857

Changeset: 92580e97b251f50c5e998f9917667f3ddea6b656

comment:3 Changed 8 years ago by Ross Miller

Create a new workspace for the live listener when a run starts

After a run ends (and extractData() has been called to retrieve the last events from the run), throw away the temporary workspace and create a new one. This ensures we don't have out-of-date geometry or log data left over from the previous run.

Refs #5857

Changeset: 6a8ce32ec95767eb7acbc169a7e2dd2a02eb7aa7

comment:4 Changed 8 years ago by Ross Miller

Properly handle redundant device descriptor packets

There are certain cases when SMS will send device descriptor packets more than once per run. Need to ignore the descriptions for devices we already have (because Mantid will throw an exception if you try to add a property to a workspace that already has one of the same name).

Refs #5857

Changeset: e3c3ebb3896155b594263bd9008a428b48440d56

comment:5 Changed 8 years ago by Ross Miller

Add a default exception handler to the live listener background thread

If the background thread ever throws an uncaught excetion, it will silently exit. The default handler catches everything and logs a fatal error before the thread exits.

Refs #5857

Changeset: b9f87adda151d6cc2c17ae319cd032fe054aef6b

comment:6 Changed 8 years ago by Ross Miller

  • Status changed from new to accepted

comment:7 Changed 8 years ago by Ross Miller

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:9 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

Closed at release

comment:10 Changed 8 years ago by Ross Miller

Parse the RunStatus packet for run start and run stop info

Refs #5857

Changeset: 963cfe4b2fd54b347afe626fdc2ae018b77fc4c7

comment:11 Changed 8 years ago by Ross Miller

Add a run_number property to workspaces from the live event listener

Refs #5857

Changeset: 92580e97b251f50c5e998f9917667f3ddea6b656

comment:12 Changed 8 years ago by Ross Miller

Create a new workspace for the live listener when a run starts

After a run ends (and extractData() has been called to retrieve the last events from the run), throw away the temporary workspace and create a new one. This ensures we don't have out-of-date geometry or log data left over from the previous run.

Refs #5857

Changeset: 6a8ce32ec95767eb7acbc169a7e2dd2a02eb7aa7

comment:13 Changed 8 years ago by Ross Miller

Properly handle redundant device descriptor packets

There are certain cases when SMS will send device descriptor packets more than once per run. Need to ignore the descriptions for devices we already have (because Mantid will throw an exception if you try to add a property to a workspace that already has one of the same name).

Refs #5857

Changeset: e3c3ebb3896155b594263bd9008a428b48440d56

comment:14 Changed 8 years ago by Ross Miller

Add a default exception handler to the live listener background thread

If the background thread ever throws an uncaught excetion, it will silently exit. The default handler catches everything and logs a fatal error before the thread exits.

Refs #5857

Changeset: b9f87adda151d6cc2c17ae319cd032fe054aef6b

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6703

Note: See TracTickets for help on using tickets.