Ticket #5856 (closed: duplicate)

Opened 8 years ago

Last modified 5 years ago

should we copy methadata where experiment info is copied

Reported by: Alex Buts Owned by: Alex Buts
Priority: minor Milestone: Release 2.5
Component: VATES Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Nick Draper

Description

ConvertToMD algorithm is the wrapper for two factories where the one is dealing with transformation and another -- with input and output workspaces.

Experimental info is copied to target MD workspace in ConvToMDBase initialize function. This allows it to be easy deployed in other types of algorithms.

Recent changes in quantification has added metadata to experiment info and copying of these metadata is currently occuring in ConvToMD algorithm body itself.

Should it be copied to ConvToMDBase ?

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:2 Changed 8 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Alex Buts

comment:3 Changed 8 years ago by Alex Buts

  • Milestone changed from Release 2.4 to Release 2.5

comment:4 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:5 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:6 Changed 7 years ago by Alex Buts

  • Status changed from assigned to accepted

comment:7 Changed 7 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to duplicate

as part of the ticket #6852, all methadata copying has been assembled together within the method CopyMethadata of ConvertToMD algorithm.

This ticket became part of #6852

Last edited 7 years ago by Alex Buts (previous) (diff)

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

approved

comment:10 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:11 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:12 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:13 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:14 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:15 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:16 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:17 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:18 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:19 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:20 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:21 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:22 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6702

Note: See TracTickets for help on using tickets.