Ticket #5872 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Small changes to improve code quality and decrease code duplication in MDAlgorithms

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.0
Component: GUI Keywords:
Cc: Toby.Perring@… Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Russell Taylor) (diff)

See comment:15

Old description:

To check one needs large MDWorksapce. Mine was 200meV iron dataset loaded from sqw as file-based MD workspace.

Trying to perform axis aligned cut takes ages, but trying to cancel it is very unresponsive. It stops slice eventually, but used needs to wait up to 1-2 minutes clicking cancel button until the algorithm stops

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:2 Changed 8 years ago by Nick Draper

  • Owner set to Alex Buts
  • Status changed from new to assigned

See if this can be improved

comment:3 Changed 8 years ago by Alex Buts

  • Milestone changed from Release 2.4 to Release 2.5

comment:4 Changed 7 years ago by Alex Buts

  • Milestone changed from Release 2.5 to Release 2.6

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from VATES to User Interface

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:8 Changed 7 years ago by Alex Buts

  • Status changed from new to inprogress
  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.0

comment:9 Changed 7 years ago by Alex Buts

refs #5872 removed loadExperimentInfo from LoadMD

it is not used there any more.

Changeset: 418f3171ed9b2e712e7ad5eebea42599c4fd9b68

comment:10 Changed 7 years ago by Alex Buts

refs #5872 Verified MD box volume by relative value rather then abs.

This substantially affects amount of logging done in debug mode

Changeset: 14753d0baa3b4f3de5f07ca3b87ae0fb7bb5b172

comment:11 Changed 7 years ago by Alex Buts

refs #5872 Modified Slice MD to use box controller

instead internal conditions

Changeset: b430e6035c21dd22a529bf9728afd19f5bd25a66

comment:12 Changed 7 years ago by Alex Buts

refs #5872 changed box size checks to reller rather then abserr

according to the changes in the LoadMD operations.

Changeset: ce7b5a0558358e8210c980ade055ca41c3575804

comment:13 Changed 7 years ago by Alex Buts

refs #5872 No -- this check error in the box volume

Changeset: 44b30be02a7fac57396eff7f3c32bd5db793d496

comment:14 Changed 7 years ago by Alex Buts

refs #5872 typing error

Changeset: 3e74d90b8ce3f9f74f29290beae86395b51b0f7e

comment:15 Changed 7 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester:

Initial ticket can be probably marked as invalid as previous changes to disk buffer and the algorithm itself have fixed wrong behaviour.

Preparing to working on this ticket I made small modifications to the MD algorithm code which improve code quality (e.g. relative error in loading box volumes rather than the absolute error and using splitting constant defined in box controller rather than algorithm-defined constant)

These changes went to this ticket so this ticket can be entitled “improve code quality and decrease code duplication in MDAlgorithms”

In this form the ticket can be passed after code review – changes are small.

comment:16 Changed 7 years ago by Alex Buts

refs #5872 Increased accuracy of Box tree loaders and

modify the CompareMDWorkspaces to check reller rather then abserr on large data.

This is because system test requesting 10-5 accuracy was failing on comparing boxes volumes.

The ultimate solution would be the changes in MDBox structure but it is subject to another ticket.

Changeset: c57be2cf00d41717edd2ad6d056d867c464fe3be

comment:17 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:18 Changed 7 years ago by Russell Taylor

  • Description modified (diff)
  • Summary changed from SliceMD can not be interrupted easity when working with file-based MD workspaces to Small changes to improve code quality and decrease code duplication in MDAlgorithms

comment:19 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/defect/5872_SliceMDInterupt'

Full changeset: ​63e7834312d059132844d0663afd35193f9cf5a1

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6718

Note: See TracTickets for help on using tickets.