Ticket #5875 (closed: fixed)
Write algorithm which would automatically calculate min-max values for ConvertToMD
| Reported by: | Alex Buts | Owned by: | Andrei Savici |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Alex Buts |
Description (last modified by Peter Peterson) (diff)
On the basis of pre-calculated detectors positions obtained from PreprocessDetectorsToMD? algorithm, it is easy to estimate the spawn of resulting MD workspace, obtained from ConvertToMD algorithm for any plugin, defining homogeneous transformation.
It will be substantial enhancement for the usability of the algorithm.
Change History
comment:2 Changed 8 years ago by Andrei Savici
- Status changed from new to accepted
- Owner set to Andrei Savici
comment:3 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:6 Changed 7 years ago by Andrei Savici
Helper for ConvertToMD. Refs #5875
Changeset: dd15210d5b659d62c69a772fc15c330fc8376afc
comment:7 Changed 7 years ago by Andrei Savici
Updated code to deal with indirect. Refs #5875.
Changeset: c14c672b5bcdfae3d4a12708f65c472f8ec462c8
comment:8 Changed 7 years ago by Andrei Savici
Unit test and wiki for ConvertToMDHelper. Refs #5875
Changeset: 3473b8e944e59f53d57a7ff2390713a99d1d5e4e
comment:9 Changed 7 years ago by Andrei Savici
Fix initializer in test. Refs #5875
Changeset: bb7f0bda5ed6ea22c2270c8bdfcedb1abbcad6b3
comment:10 Changed 7 years ago by Andrei Savici
Fix error. Refs #5875
Changeset: 44c1bef246ac2a18a8be32a50ef2b907d600b37a
comment:11 Changed 7 years ago by Andrei Savici
- Status changed from accepted to verify
- Resolution set to fixed
Branch feature/5875_ConvertToMDHelper.
Test if everuthing in the wiki help makes sense
comment:12 Changed 7 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:13 Changed 7 years ago by Peter Peterson
- Status changed from verifying to reopened
- Resolution fixed deleted
- Description modified (diff)
This works as advertised, but the help information needs serious formatting help. I'm bouncing this based on the "Description" section of the wiki.
comment:14 Changed 7 years ago by Andrei Savici
Changed wiki. Refs #5875.
Changeset: 8c2b32f37512878aacfcf6b8476ab865f64223ed
comment:15 Changed 7 years ago by Andrei Savici
- Status changed from reopened to verify
- Resolution set to fixed
comment:16 Changed 7 years ago by Alex Buts
- Status changed from verify to verifying
- Tester changed from Peter Peterson to Alex Buts
comment:17 Changed 7 years ago by Alex Buts
- Status changed from verifying to closed
well, the algorithm calculates "some" values. If one takes our favourite CNCS_7860_event, it would be:
limits=ConvertToMDHelper("CNCS_7860_event",'Q3D','Direct')
print limits
(array([-2.849459 , -2.849459 , -2.849459 , -2.61552638]), array([ 2.849459 , 2.849459 , 2.849459 , 2.61552638]))
Picture, showing the conversion result certainly displays X-coordinate in limits -0.5;2. and Y-coordinate does not go outside +-1.5.
It is within the limits provided, but do not think the algorithm in this form is really useful.
One can be as well satisfied with the suggestion to use default limits +-50 within ConvertToMD
After discussion I may understand that this approach has some merits, so pass with :(
comment:18 Changed 7 years ago by Alex Buts
Merge remote-tracking branch 'origin/feature/5875_ConvertToMDHelper'
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6721
Moved to milestone 2.4