Ticket #5874 (closed: fixed)
Support backward compatibility of Processed Nexus Files by Looking At Structure
| Reported by: | Karl Palmen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | Refactor |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
ExperimentInfo method of loading an instrument from a Nexus file currently uses a version number to ensure backward compatibility to an old type of Precessed Nexus file.
Instead, it would be neater to assume that the Nexus file is of the new version and if that fails go on to assume it's the old version.
Change History
comment:2 Changed 8 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Karl Palmen
comment:4 Changed 8 years ago by Karl Palmen
Make necessary changes in code for this re #5874
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6765973078816b9390ed9f98085601581b02c8ee
comment:5 Changed 8 years ago by Karl Palmen
This raised an issue in testing now covered by ticket #6252
comment:6 Changed 8 years ago by Karl Palmen
To test check that the both old a new versions load and show good instrument information. Both the files used by LoadNexusProcessedTest are of the old version and any file generated by SaveNexus will be of the new version. Also you may test with Raw files that have instrument information in them.
comment:7 Changed 8 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
comment:8 Changed 8 years ago by Karl Palmen
Make necessary changes in code for this re #5874
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6765973078816b9390ed9f98085601581b02c8ee
comment:9 Changed 8 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:10 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to closed
Confirmed old files still load and saving produces new-style files.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6720
Moved to milestone 2.4