LoadNexusProcessedTest does not test current version of file

[Karl Palmen]

When testing a fix to #5874, I found that both the files tested by LoadNexusProcessedTest are of an old version in which the instrument folders are arranged differently than are currently produced by SaveNexusProcessed.

One of the files (I suggested focussed.nxs) should be in the new format. I converted this file to the new format by loading and saving as Nexus and found the test worked. This I have not been able to commit, because the new file exceeds the 1024 KB size limit now imposed.

So one needs to either use a smaller file instead of focussed.nxs and modify the unit test accordingly or

override the size limit and run all tests that use this file.

[Martyn Gigg]

How about creating a temporary saved nexus file for the current version in the test and then removing it when the test is finished, that way we avoid having to add any files to the repository?

[Russell Taylor]

The very cryptically named ​LoadRSaveNLoadNcspTest.h already does this, although it could probably use updating to test more recent functionality.

[Karl Palmen]

Martyn's suggestion has the advantage that the latest version is always tested (should a newer version arise).

[Russell Taylor]

And as I say, that's exactly what LoadRSaveNLoadNcspTest does. When I mentioned updating I meant add more asserts to check what has been loaded back in.

[Martyn Gigg]

Ah yes, I'd forgotten about that beauty. How about a rename at the same time, I assume the CSP refers to the fact is uses a CSP file which doesn't really need to be in the name. Something like LoadRawSaveNxsLoadNxsTest.h would at least be slightly less cryptic?

[Karl Palmen]

Rename test as suggested and add comments re #6252

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6dce4727a6d8d9c172bea87a6c2eb69da0dffe76

[Karl Palmen]

To test, check that DataHandlingTest LoadNexusProcessedTest has a comment to the effect it handles old version Nexus processed files and tells you which test handles the current version of Nexus processed file. Verify that the test referred to is called LoadRawSaveNxsLoadNxsTest and it does test the loading of a newly created Nexus processed file.

You may wish to compare the folder structure of a test file of LoadNexusProcessedTest with a newly created Nexus processed file (e.g. by saving a workspace to Nexus) and see that the instrument_source and instrument_parameter_map folders have been moved inside the instrument folder in the current version. And so see both versions are different. This can be done with HDFview.

[Karl Palmen]

Rename test as suggested and add comments re #6252

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6dce4727a6d8d9c172bea87a6c2eb69da0dffe76

[Stuart Campbell]

This ticket has been transferred to github issue ​7098