Improved warning when no detector in IDF

[Anders Markvardsen]

This ticket should not be completed before #5900 has been completed.

The attached IDF_minimalistic.xml file contains an instrument which can be loaded successfully with LoadEmptyInstrument.

However if the is="detector" attribute is removed in that IDF, which then means there is no detectors in the file MantidPlot produces the error message:

"All arguments to init must be positive and non-zero Error in execution of algorithm LoadEmptyInstrument: All arguments to init must be positive and non-zero"

Change this so error message from LoadEmptyInstrument is generated:

"No detectors defined in IDF. LoadEmptyInstrument requires at least one detector to be defined in IDF at the moment. Since number of detectors equals number of histograms in the workspace created by LoadEmptyInstrument, and at the moment a workspace must contain at least one histogram."

[Karl Palmen]

A chat with Martyn has suggested that the fix for this should go into the LoadEmptyInstrument algorithm and not in the InstrumentDefinitionParser. The latter could then still be used to parse an instrument without detectors, which would require a ready made workspace to load.

[Karl Palmen]

I've tried out a fix for this and it works, but when I tried it with the XML file I used to test #5914 I found the same error message that I added for this turns up later on, amongst others.

I find this is because LoadEmptyInstrument does not give up when the LoadInstrument algorithm fails and so gives more error messages. I can't find a neat way of dealing with this.

[Karl Palmen]

I've found out that LoadInstrument throws a InstrumentDefinitionError, if there are issues with the content of XML instrument file. LoadEmptyInstument should also do so.

Any InstrumentDefinitionError thrown by the LoadInstrument subalgorithm should be rethrown and this exception should be thrown in this case.

[Karl Palmen]

Get appropriate error message logged re #5915

I find the error messaging for LoadEmptyInstrument.cpp is messy. It should throw the exceptions of the LoadInstrument sub-algorithm rather than try to continue. It should also throw an appropriate exeception in this case.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d4c13382c573ea69aee01de3b1ad006782fa0e0

[Karl Palmen]

Tidy up error messaging re #5914 re #5915

In particular, LoadEmptyInstrument does not attempt to continue running, if the LoadInstrument sub-algorithm has failed.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3e27f8d32ad9b180eca51928dcf7c8ec6ed9bf10

[Karl Palmen]

Fix for event workspaces too re #5915

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d2c48a3b60b273776d77928d8dc3e012a4952b5a

[Karl Palmen]

Added unit test for ticket re #5915

This necessitated an amendment of a make file to ensure scoped file is available to the test.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a20f87531db3dd30575ec057f562de2d19889247

[Owen Arnold]

This functionality is unit tested.

Running LoadEmptyInstrument on the provided XML file produces the expected results before an after the removal of the is="dectector" attribute.

[Karl Palmen]

Get appropriate error message logged re #5915

I find the error messaging for LoadEmptyInstrument.cpp is messy. It should throw the exceptions of the LoadInstrument sub-algorithm rather than try to continue. It should also throw an appropriate exeception in this case.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d4c13382c573ea69aee01de3b1ad006782fa0e0

[Karl Palmen]

Tidy up error messaging re #5914 re #5915

In particular, LoadEmptyInstrument does not attempt to continue running, if the LoadInstrument sub-algorithm has failed.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3e27f8d32ad9b180eca51928dcf7c8ec6ed9bf10

[Karl Palmen]

Fix for event workspaces too re #5915

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d2c48a3b60b273776d77928d8dc3e012a4952b5a

[Karl Palmen]

Added unit test for ticket re #5915

This necessitated an amendment of a make file to ensure scoped file is available to the test.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a20f87531db3dd30575ec057f562de2d19889247

[Stuart Campbell]

This ticket has been transferred to github issue ​6761