Ticket #6009 (closed: fixed)
PHI calculation in the instrument view.
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Owen Arnold) (diff)
The instrument view gives the option to plot the integrated intensity on a detector by detector basis along a tube. The position of the detector can be specified in spherical coordinates.
The psi integration in the mini-plot is not working out well for instruments like wish. Data in these plots is polarized to +pi / -pi due the the location of the detectors with respect to the reference frame. For certain tubes which have x values close to zero, the effect is compunded.
An approach requested by pascal is to offset the psi values by an offset. For psi < 0, phi = - (phi + pi) . For phi >= 0, phi = pi - phi.
This should be opt-in type behaviour.
Change History
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:7 Changed 7 years ago by Owen Arnold
refs #6009. switch in via parameter.
Changeset: 2c8615de3bca336c5f72c75023dc08e475d3e16c
comment:8 Changed 7 years ago by Owen Arnold
refs #6009. Ref results update.
Changeset: dad0e32c3c4e069c372b57456b7ad8117b8ea1d2
comment:9 Changed 7 years ago by Owen Arnold
Tester. You will need to merge the system test branch as well as the feature code branch into master. Both are called feature/6009_phi.
- Remove the added parameter from the parameter file for WISH.
- Load some wish data, such as the raw file in the system test data directory
- Set the miniplot up with integrated phi view.
- Note the plot displayed as you traverse over the tubes.
- Repeat the above, but re-enable the parameter taken out.
You should also look at the new unit tests provided in geometry for these features.
comment:10 Changed 7 years ago by Owen Arnold
refs #6009. Ref results update.
Changeset: dad0e32c3c4e069c372b57456b7ad8117b8ea1d2
comment:11 Changed 7 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Owen Arnold
- Tester set to Roman Tolchenov
I've set Roman to be the tester for this as he will best understand the changes.
comment:14 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
Works fine but the angle is called psi in the parameters file and phi everywhere else. I am not sure whether it was done intensionally or not.
comment:15 Changed 7 years ago by Owen Arnold
refs #6009. switch in via parameter.
Changeset: 2c8615de3bca336c5f72c75023dc08e475d3e16c
comment:16 Changed 7 years ago by Owen Arnold
refs #6009. switch in via parameter.
Changeset: 2c8615de3bca336c5f72c75023dc08e475d3e16c
comment:17 Changed 7 years ago by Owen Arnold
refs #6009. switch in via parameter.
Changeset: 2c8615de3bca336c5f72c75023dc08e475d3e16c
comment:18 Changed 7 years ago by Owen Arnold
refs #6009. switch in via parameter.
Changeset: 2c8615de3bca336c5f72c75023dc08e475d3e16c
comment:19 Changed 7 years ago by Owen Arnold
refs #6009. switch in via parameter.
Changeset: 2c8615de3bca336c5f72c75023dc08e475d3e16c
comment:20 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:21 Changed 7 years ago by Nick Draper
- Status changed from reopened to assigned
- Milestone changed from Release 2.6 to Release 2.5
comment:23 Changed 7 years ago by Owen Arnold
refs #6009. Label change.
Changeset: 26f8b2d964adf2d952bea1fa0ed5d3ca80258b73
comment:24 Changed 7 years ago by Owen Arnold
refs #6009. Label change.
Changeset: 26f8b2d964adf2d952bea1fa0ed5d3ca80258b73
comment:25 Changed 7 years ago by Owen Arnold
refs #6009. Fix error.
Changeset: 1a490043862a5ddf94c24527dceaf5b62dc90fb6
comment:26 Changed 7 years ago by Owen Arnold
refs #6009. Fix error.
Changeset: 1a490043862a5ddf94c24527dceaf5b62dc90fb6
comment:27 Changed 7 years ago by Owen Arnold
- Status changed from accepted to verify
- Priority changed from major to blocker
- Resolution set to fixed
Fixed Roman's observation. Please re-test.
comment:28 Changed 7 years ago by Owen Arnold
Needs to be merged into the release branch.
comment:30 Changed 7 years ago by Owen Arnold
refs #6009. switch in via parameter.
Changeset: 2c8615de3bca336c5f72c75023dc08e475d3e16c
comment:31 Changed 7 years ago by Owen Arnold
refs #6009. Label change.
Changeset: 26f8b2d964adf2d952bea1fa0ed5d3ca80258b73
comment:32 Changed 7 years ago by Owen Arnold
refs #6009. Fix error.
Changeset: 1a490043862a5ddf94c24527dceaf5b62dc90fb6
comment:34 Changed 7 years ago by Martyn Gigg
Update ref result for parameter map change. Refs #6009
Changeset: dabd5e9d03db648395b5935e0da25d6244f7433a
comment:35 Changed 7 years ago by Martyn Gigg
Update ref result for parameter map change. Refs #6009
Changeset: dabd5e9d03db648395b5935e0da25d6244f7433a
comment:36 Changed 7 years ago by Owen Arnold
refs #6009. Ref results update.
Changeset: dad0e32c3c4e069c372b57456b7ad8117b8ea1d2
comment:37 Changed 7 years ago by Martyn Gigg
Update ref result for parameter map change. Refs #6009
Changeset: dabd5e9d03db648395b5935e0da25d6244f7433a
comment:38 Changed 7 years ago by Owen Arnold
refs #6009. switch in via parameter.
Changeset: 2c8615de3bca336c5f72c75023dc08e475d3e16c
comment:39 Changed 7 years ago by Owen Arnold
refs #6009. Label change.
Changeset: 26f8b2d964adf2d952bea1fa0ed5d3ca80258b73
comment:40 Changed 7 years ago by Owen Arnold
refs #6009. Fix error.
Changeset: 1a490043862a5ddf94c24527dceaf5b62dc90fb6
comment:41 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6855
Moved to milestone 2.4