Ticket #6010 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Multi file loading can crash whole PC if too many files selected

Reported by: Nick Draper Owned by: Nick Draper
Priority: critical Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Nick Draper) (diff)

entries like these into load which can happen by mistake can crash not just mantid but lock the whole PC.

  • tsc13561:10
  • offspec1-13565

In each case they are handling a very large range of files which is almost certainly a mistake.

Add a limit to the number of files acceptable in a range to protect against this.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Description modified (diff)

comment:2 Changed 8 years ago by Nick Draper

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Nick Draper

re #6010 add a limit to the number of files default 100

Changeset: e34c0fdb24d55410b9160a46d1725c02d1cd6e55

comment:4 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

to test: Run load with one of the strings above, or any range that will load over 100 files.

Then check that loading a smaller range does work.

comment:5 Changed 8 years ago by Nick Draper

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:6 Changed 8 years ago by Nick Draper

re #6010 fix an operator precedence bug

Changeset: d749e08cf758691b6bba73b3baa83e0eb4e6f2e3

comment:7 Changed 8 years ago by Nick Draper

re #6010 warning hunting

Changeset: 3a02f354312be4d09fe170ee2862d78f284e0f95

comment:8 Changed 8 years ago by Nick Draper

  • Status changed from reopened to accepted

comment:9 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:11 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

Yes, this works. Error message generated when the request is too large. I can also use the loading.multifilelimit user property to control the limit.

comment:12 Changed 8 years ago by Nick Draper

re #6010 add a limit to the number of files default 100

Changeset: e34c0fdb24d55410b9160a46d1725c02d1cd6e55

comment:13 Changed 8 years ago by Nick Draper

re #6010 fix an operator precedence bug

Changeset: d749e08cf758691b6bba73b3baa83e0eb4e6f2e3

comment:14 Changed 8 years ago by Nick Draper

re #6010 warning hunting

Changeset: 3a02f354312be4d09fe170ee2862d78f284e0f95

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6856

Note: See TracTickets for help on using tickets.