Ticket #6034 (closed: worksforme)

Opened 8 years ago

Last modified 5 years ago

Installer is shipping some pyc without related py

Reported by: Gesner Passos Owned by: Martyn Gigg
Priority: minor Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

I've generated a script that list all the mismatches. They are all related to the script/Interface/templates that should not distribute the pyc files.

But, some pyc files are being distributed without their counterpart py files, they are:

  • plugins/PythonAlgs/FindCurrentLiveNexusFile.pyc
  • plugins/PythonAlgs/GenerateMaskWorkspace.pyc
  • plugins/PythonAlgs/InvertMask.pyc
  • plugins/PythonAlgs/Stitch1D.pyc
  • scripts/Reflectometry/Quick.pyc

Test done inside Ubuntu 12.4 - download: mantid_2.2_1080_amd64.deb

For Windows 7, other than those seem in Ubuntu, it has some extra pyc, as well,

scripts/Inelastic/osiris_diffraction_reducer.pyc

And inside plugins/PythonAlgs:

  • FindSNSNeXus.pyc
  • RefMReduction.pyc
  • SNSPowderReduction2.pyc
  • WorkflowAlgorithms/ReflectivityReduction.pyc
  • WorkflowAlgorithms/RefLoad.pyc

Related to re #5192

In order to check for Ubuntu: 

cd /opt/Mantid
find . -name *.py | sort > all_py
find . -name *.pyc| sort | sed 's/pyc/py' > all_py_noc
diff all_py all_py_noc

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to worksforme

With the latest installer this seems correct. 

--- all_py_noc.txt	2012-12-21 13:32:06.196192770 +0000
+++ all_py.txt	2012-12-21 13:28:32.100199982 +0000
@@ -197,6 +197,10 @@
 ./scripts/Interface/reduction_gui/widgets/util.py
 ./scripts/Interface/setup.py
 ./scripts/Interface/templates/generate_stubs.py
+./scripts/Interface/templates/interface_template.py
+./scripts/Interface/templates/script_elements_template.py
+./scripts/Interface/templates/script_elements_widget_template.py
+./scripts/Interface/templates/scripter_template.py
 ./scripts/Interface/test/utest_reduction.py
 ./scripts/Interface/ui/inelastic/__init__.py
 ./scripts/Interface/ui/inelastic/ui_dgs_absolute_units.py

The only files shipped without .pyc files are the templates that are not actual modules but as suggested templates to be used with generate_stubs.

comment:3 Changed 8 years ago by Stuart Campbell

On RHEL6 I got: 

80d79
< ./plugins/PythonAlgs/WorkflowAlgorithms/RefLoad.py
126d124
< ./scripts/Inelastic/osiris_diffraction_reducer.py
211a210,213
> ./scripts/Interface/templates/interface_template.py
> ./scripts/Interface/templates/script_elements_template.py
> ./scripts/Interface/templates/script_elements_widget_template.py
> ./scripts/Interface/templates/scripter_template.py

Does this make sense ?

Last edited 8 years ago by Stuart Campbell (previous) (diff)

comment:4 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:5 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6880

Note: See TracTickets for help on using tickets.