Ticket #6105 (closed: fixed)
Probable issue with LoadInstrument
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Karl Palmen |
Description
LoadInstrument may not reload the IDF unless the IDF file modification date is different. This would screw-up the logic of the VTP, XML file loading preferences. This might be what Pascal is seeing.
Change History
comment:2 Changed 8 years ago by Owen Arnold
refs #6105. Use actual modified date instead.
Changeset: 86fcf7ca4b749342846ee0dd20eb6ae063509a5a
comment:3 Changed 8 years ago by Owen Arnold
Revert "refs #6105. Use actual modified date instead."
This reverts commit 86fcf7ca4b749342846ee0dd20eb6ae063509a5a.
Changeset: 978d95bf07607bf1b3a8a5d27f5cd347394efcf7
comment:4 Changed 8 years ago by Owen Arnold
refs #6105. Fix old-style mangled names.
Changeset: 3ab9b121bee5f65c391294febde2320ee55e5db3
comment:5 Changed 8 years ago by Owen Arnold
Revert "refs #6105. Fix old-style mangled names."
This reverts commit 3ab9b121bee5f65c391294febde2320ee55e5db3.
Changeset: b03454e4051f7ff03c0d949830d2611a2afcccb9
comment:6 Changed 8 years ago by Owen Arnold
refs #6105. Fix IDFObject test.
Changeset: 2e3e5c70bc55f75514f643ec03346e088bca68c2
comment:7 Changed 8 years ago by Owen Arnold
Revert "refs #6105. Fix IDFObject test."
This reverts commit 2e3e5c70bc55f75514f643ec03346e088bca68c2.
Changeset: 0e379fa5de5519182f6b242e7b2f46b6e772adbd
comment:8 Changed 8 years ago by Owen Arnold
Revert "Revert "refs #6105. Fix IDFObject test.""
This reverts commit 0e379fa5de5519182f6b242e7b2f46b6e772adbd.
Changeset: 04117b342e2e8b3f37ba3fb2eae9d3cb983abfe7
comment:9 Changed 8 years ago by Owen Arnold
refs #6105. Using microseconds
Changeset: 747f5148921508bcddd30d3284e8b4b1eeaf11f1
comment:10 Changed 8 years ago by Owen Arnold
refs #6105. Remove fragile test
Changeset: 679b3a7d5f3d613048986d2b8fb88e294c982aff
comment:11 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester: This is how you can test this ticket.
- Load the WISH data file from the system tests data directory WISH00016748.nxs
- Now run LoadInstrument on the workspace you have just loaded using the same Instrument definition file as defaulted to in Load on the previous step. Note how long it took to run.
- Make a minor modification to the IDF file file i.e. add a comment line, but do not change any of the xml itself.
- Re-run LoadInstrument. Notice that loading should take much longer than when you last ran LoadInstrument as the Load algorithm should have decided to reload the instrument into the IDS.
comment:12 Changed 8 years ago by Owen Arnold
refs #6105. Use actual modified date instead.
Changeset: 86fcf7ca4b749342846ee0dd20eb6ae063509a5a
comment:13 Changed 8 years ago by Owen Arnold
Revert "refs #6105. Use actual modified date instead."
This reverts commit 86fcf7ca4b749342846ee0dd20eb6ae063509a5a.
Changeset: 978d95bf07607bf1b3a8a5d27f5cd347394efcf7
comment:14 Changed 8 years ago by Owen Arnold
refs #6105. Fix old-style mangled names.
Changeset: 3ab9b121bee5f65c391294febde2320ee55e5db3
comment:15 Changed 8 years ago by Owen Arnold
Revert "refs #6105. Fix old-style mangled names."
This reverts commit 3ab9b121bee5f65c391294febde2320ee55e5db3.
Changeset: b03454e4051f7ff03c0d949830d2611a2afcccb9
comment:16 Changed 8 years ago by Owen Arnold
refs #6105. Fix IDFObject test.
Changeset: 2e3e5c70bc55f75514f643ec03346e088bca68c2
comment:17 Changed 8 years ago by Owen Arnold
Revert "refs #6105. Fix IDFObject test."
This reverts commit 2e3e5c70bc55f75514f643ec03346e088bca68c2.
Changeset: 0e379fa5de5519182f6b242e7b2f46b6e772adbd
comment:18 Changed 8 years ago by Owen Arnold
Revert "Revert "refs #6105. Fix IDFObject test.""
This reverts commit 0e379fa5de5519182f6b242e7b2f46b6e772adbd.
Changeset: 04117b342e2e8b3f37ba3fb2eae9d3cb983abfe7
comment:19 Changed 8 years ago by Owen Arnold
refs #6105. Using microseconds
Changeset: 747f5148921508bcddd30d3284e8b4b1eeaf11f1
comment:20 Changed 8 years ago by Owen Arnold
refs #6105. Remove fragile test
Changeset: 679b3a7d5f3d613048986d2b8fb88e294c982aff
comment:21 Changed 8 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:22 Changed 8 years ago by Karl Palmen
- Status changed from verifying to closed
I ran with another WISH nexus file. I found LoadInstrument was very fast (0.01 seconds) if reran on an IDF file previously used and since not modified, but if modified since last LoadInstrument run, it takes longer (about 1.7 seconds) and so I conclude the test is passed.
comment:23 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6951
