Ticket #6133 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Remove toolbar buttons and hide toolbars that are not in frequent use

Reported by: Nick Draper Owned by: Owen Arnold
Priority: critical Milestone: Release 2.4
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: #6153 Tester: Nick Draper

Description (last modified by Nick Draper) (diff)

The following are notes taken from the 2012 Mantid Developer meeting

Get rid of black box in workspace Keep font controls but not necessarily in the default shown menus

On the File toolbar get rid of most of the buttons but

  • Keep load File
  • Keep load Project
  • Keep manage User Directory
  • PDF export appears to be broken also print appears to be broken (they will be removed anyway from the toolbar). Additional ticket to check/fix the underlying code?
  • Show Analysis Results
  • Scripting Window toolbar buttons

From the Edit toolbar

  • Remove undo and Redo
  • Remove delete Selection

For some reason, Cut is not on the Edit menu? Evaluate what should be done about this with Nick. ND: Most of our data items would not allow cut type operations anyway, so do not add this, leave it as it currently is.

  • Remove the whole of the Table toolbar
  • Remove the whole of the Column toolbar
  • Remove the whole of the 3D Plotting toolbar

From the Plot Bar

  • Remove Layer Buttons (first 3)
  • Remove add and remove error bar buttons
  • Remove add and remove curve buttons

From the Plot tool bar

  • Turn Magnifying glass into a pan (hand) icon
  • Keep the zoom in and out
  • Keep the arrow and line buttons
  • Keep text label draw
  • Remove time stamp
  • Remove image button

Flag up any buttons that don't work equally well via the menus and the toolbars with Nick. These can be dealt with by separate tickets.

Changes made by this ticket will require thorough testing prior to the next release. We will be judged very badly if users find things broken by a so-called improvement. In fact, it might be wise to open a BLOCKER ticket just to test the features fixed here.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to assigned
  • Owner changed from Owen Arnold to Karl Palmen
  • Description modified (diff)

comment:2 Changed 8 years ago by Owen Arnold

  • Blocking 6153 added

comment:3 Changed 8 years ago by Karl Palmen

  • Milestone changed from Release 2.4 to Release 2.5

comment:4 Changed 8 years ago by Karl Palmen

Ticket #915 could be dealt with here.

comment:5 Changed 8 years ago by Nick Draper

  • Owner changed from Karl Palmen to Owen Arnold
  • Milestone changed from Release 2.5 to Release 2.4

Returned to Release 2.4 for group effort. Assigned to Owen to lead.

comment:6 Changed 8 years ago by Nick Draper

  • Description modified (diff)
  • Summary changed from Hide toolbars that are not in frequent use to Remove toolbar buttons and hide toolbars that are not in frequent use

comment:7 Changed 8 years ago by Owen Arnold

  • Status changed from assigned to accepted

comment:8 Changed 8 years ago by Owen Arnold

refs #6133 Remove Edit Toolbar Actions.

The actions themselves still live in the ApplicationWindow, but have been removed from the edit menu and toolbar.

Changeset: 665b67c43de0682a970bb09eb31027f045af747d

comment:9 Changed 8 years ago by Owen Arnold

refs #6133 Remove Table Toolbars.

Should be entirely gone now.

Changeset: 74a1b3625f11fafa2d5a9b1b2a4b5c4ca50d3d97

comment:10 Changed 8 years ago by Karl Palmen

In the file toolbar I have located all the items set for removal either in the file menu or window menu, but have not found

 Import Data Files (should be in file menu)
 Print Window (should be in window menu)
 Show project Explorer (should be in view menu)

ND

  • Import data files = File->Import ascii
  • Print Window = File->Print
  • Show Project Explorer = View->project Explorer
Last edited 8 years ago by Nick Draper (previous) (diff)

comment:11 Changed 8 years ago by Owen Arnold

refs #6133 Remove Column Toolbars.

Should be entirely gone now. Did not remove associated actions.

Changeset: 2cf116781a8a59699fa7b1de54c9808e4d8e917e

comment:12 Changed 8 years ago by Karl Palmen

I cannot find alternative means of accessing items in the Table, Column and 3D potting toolbars.

ND These all are available in menus that become visible when you have a 3Dplot or table selected, or as context menus when right clicking on a column

Last edited 8 years ago by Nick Draper (previous) (diff)

comment:13 Changed 8 years ago by Karl Palmen

All items to be removed from the plot toolbar are available in the Graph menu.

comment:14 Changed 8 years ago by Owen Arnold

refs #6133. Remove 3D Plot Toolbar.

Changeset: 18bcf75224d12910ac23623fd402f3cbfdbf7c6a

comment:15 Changed 8 years ago by Karl Palmen

I found most of the commands of the Table toolbar available by creating a table selecting one or more Y columns right clicking on the selected column headers and selecting plot in the resulting menu.

comment:16 Changed 8 years ago by Karl Palmen

I haven't found any of the functionality associated with the 3D surface toolbar by right clicking a 3D surface plot (unlike table).

comment:17 Changed 8 years ago by Owen Arnold

refs #6133. Remove items from File Menu.

Changeset: 651b726d171399915c631ed8da4347d4afeb82d7

comment:18 Changed 8 years ago by Owen Arnold

refs #6133. Remove selected from Plot Toolbar.

Changeset: 5110b240fc80a3c9f4f9fe07b527651be9282c32

comment:19 Changed 8 years ago by Owen Arnold

refs #6133. Edit + File Toolbars = Standard Toolbar.

Changeset: 818b42146b45fd36d6d544a5c59728559ca3e0ec

comment:20 Changed 8 years ago by Martyn Gigg

Change magnifying glass to pan tool icon. Refs #6133

Changeset: 04a92cdbd70d9a270e9a2d4f3532d58969d34de1

comment:21 Changed 8 years ago by Martyn Gigg

Change "Best Fit" tool tip to "Zoom to show all" Refs #6133

A bit more reflective of what it does.

Changeset: 20edd8446511ddf8adb85ea6e57463c77e28bfca

comment:22 Changed 8 years ago by Nick Draper

re #6133 new project icons

Changeset: 921fad5814efb37d24983048cda45bb7567faf10

comment:23 Changed 8 years ago by Nick Draper

re #6133 new open file icon

Changeset: 952ea63d42c6b26b383f0761dc978e02b90bc12e

comment:24 Changed 8 years ago by Martyn Gigg

Move 3D surface toolbar to format menu. Refs #6133

Changeset: f512ca14c3d5df6288794472dfa2fdbe7a7d60e2

comment:25 Changed 8 years ago by Owen Arnold

refs #6133. Use new icons.

Changeset: e04ae47b5ce6ff0cf713befd244380676759d321

comment:26 Changed 8 years ago by Owen Arnold

refs #6133. Tweak layout positions.

Changeset: 1c9a748bc74c8dc9c2a0902f5b8c6a193a8371dc

comment:27 Changed 8 years ago by Owen Arnold

refs #6133 Remove Edit Toolbar Actions.

The actions themselves still live in the ApplicationWindow, but have been removed from the edit menu and toolbar.

Changeset: 217026218335cca77a6364e91e45b3ccffa478ae

comment:28 Changed 8 years ago by Owen Arnold

refs #6133 Remove Table Toolbars.

Should be entirely gone now.

Changeset: 70ee2e3151276af6b6c7e86e4e42908b381e4d05

comment:29 Changed 8 years ago by Owen Arnold

refs #6133 Remove Column Toolbars.

Should be entirely gone now. Did not remove associated actions.

Changeset: 25401b9db10f3c2a92885d4a4059f32cd3003250

comment:30 Changed 8 years ago by Owen Arnold

refs #6133. Remove 3D Plot Toolbar.

Changeset: b4a46e6f68bb9613af7d562ed9386875538ddcf1

comment:31 Changed 8 years ago by Owen Arnold

refs #6133. Remove items from File Menu.

Changeset: 9661743b3ae68a61aaca5254075674f7e764d77b

comment:32 Changed 8 years ago by Owen Arnold

refs #6133. Remove items from File Menu.

Changeset: 232124da970b56289c2faa10c4d93ff2757f96bd

comment:33 Changed 8 years ago by Owen Arnold

refs #6133. Remove selected from Plot Toolbar.

Changeset: ea291885ba31cd46b51bba393c93857911ad252d

comment:34 Changed 8 years ago by Owen Arnold

refs #6133. Edit + File Toolbars = Standard Toolbar.

Changeset: 69885415132e4505b10fc14a415389cdfffd9045

comment:35 Changed 8 years ago by Martyn Gigg

Change magnifying glass to pan tool icon. Refs #6133

Changeset: 23ad6608b3fa8524db4883f9b1f700c21675f28c

comment:36 Changed 8 years ago by Martyn Gigg

Change "Best Fit" tool tip to "Zoom to show all" Refs #6133

A bit more reflective of what it does.

Changeset: 4b000d8c40f667beb76ec49a1be944df3f3e6e59

comment:37 Changed 8 years ago by Nick Draper

re #6133 new project icons

Changeset: d43d82ca890cbdb201c5f6100125e400f92342f5

comment:38 Changed 8 years ago by Nick Draper

re #6133 new open file icon

Changeset: a9ea2022812ecb56ed4b78e95d41b515fd73b0d9

comment:39 Changed 8 years ago by Martyn Gigg

Move 3D surface toolbar to format menu. Refs #6133

Changeset: 01351e97ca63d693d6065c2d099e5d30d31c5de7

comment:40 Changed 8 years ago by Owen Arnold

refs #6133. Use new icons.

Changeset: 28ed60288c66827473c0cf9d70e45a9c46fc6b61

comment:41 Changed 8 years ago by Owen Arnold

refs #6133. Tweak layout positions.

Changeset: 73152dec43076632f0d2e112c98a077e9747ce54

comment:42 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:43 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Milestone changed from Release 2.5 to Release 2.4

comment:44 Changed 8 years ago by Dereck Kachere

  • Status changed from verify to verifying
  • Tester set to Dereck Kachere

comment:45 Changed 8 years ago by Dereck Kachere

  • Status changed from verifying to reopened
  • Resolution fixed deleted

There are a few inconsistencies between the names - including the use of capitals - of objects in toolbars and corresponding menus:

  • Pointer -> Disable tools.
  • Panning tool (zoom with mouse wheel) -> Zoom In/Out and Drag Canvas.
  • Zoom to show all -> Rescale to Show All.
  • Data reader -> Data Reader.
  • Draw arrow -> Draw Arrow.
  • Draw line -> Draw Line.
  • Add new legend -> New Legend.

'Load Mantid project', 'Show analysis results', 'Copy selection' and 'Paste selection' should be consistent in use of capitals by using one at the beginning of each word

The 'Select Multiple Peaks' option is also only available from the toolbars section. Should 'Open a new project' be 'Create New Project'?

comment:46 Changed 8 years ago by Owen Arnold

refs #6133. Fix all names highlighted.

Changeset: 80035a64dc2df92c82dc852d65b8e4d6d765bd5f

comment:47 Changed 8 years ago by Owen Arnold

  • Status changed from reopened to accepted

comment:48 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Dereck should pick this up for testing.

comment:49 Changed 8 years ago by Dereck Kachere

  • Status changed from verify to verifying

comment:50 Changed 8 years ago by Dereck Kachere

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Noticed another one! View -> Results Log is also different.

comment:51 Changed 8 years ago by Owen Arnold

  • Status changed from reopened to accepted

comment:52 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:53 Changed 8 years ago by Owen Arnold

refs #6133. Made correction of results log.

Changeset: b82991c25b88dbc82423ef7a80eaa9486ca375b2

comment:54 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester changed from Dereck Kachere to Nick Draper

comment:55 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

passed

comment:56 Changed 8 years ago by Owen Arnold

refs #6133. Fix all names highlighted.

Changeset: 80035a64dc2df92c82dc852d65b8e4d6d765bd5f

comment:57 Changed 8 years ago by Owen Arnold

refs #6133. Made correction of results log.

Changeset: b82991c25b88dbc82423ef7a80eaa9486ca375b2

comment:58 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6979

Note: See TracTickets for help on using tickets.