Ticket #6142 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

CPD and cppcheck fixes

Reported by: Nick Draper Owned by: Nick Draper
Priority: blocker Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By: #6572
Blocking: Tester: Martyn Gigg

Description


Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

comment:2 Changed 8 years ago by Nick Draper

  • Priority changed from critical to blocker

comment:3 Changed 8 years ago by Nick Draper

  • Summary changed from Organize Doxygen day to CPD and cppcheck fixes

comment:4 Changed 8 years ago by Nick Draper

refs #6142 cppcheck error uninitiallised vairable fitsuccess

Changeset: ca1aeefa62cff36eb67f9fb47fcb716d0a106cc1

comment:5 Changed 8 years ago by Nick Draper

refs #6142 fix for Unusual pointer arithmetic.

Changeset: cafe45ebda22eb9befc1a30c2361e51957dd5a6f

comment:6 Changed 8 years ago by Nick Draper

refs #6142 ignore boost files

Changeset: 525c5a927a51ba02b892c9f9e18283eee5c86fa1

comment:7 Changed 8 years ago by Nick Draper

refs #6142 fix memleakOnRealloc

Changeset: 397131b1609c6e1a49a8d288105987cc6ae15708

comment:8 Changed 8 years ago by Nick Draper

refs #6142 fix stlOutOfBounds

Changeset: 5e6e4f3e829b8842ce0f226fe176a814e7d3e04c

comment:9 Changed 8 years ago by Nick Draper

refs #6142 fix uninitMemberVar

Changeset: b0128199682b22a55612d35e45c8f889df701d7f

comment:10 Changed 8 years ago by Nick Draper

refs #6142 fix uninitMemberVar

Changeset: 629ce6e2901ad8998fd94ae4486577e6bd1ec784

comment:11 Changed 8 years ago by Nick Draper

refs #6142 fix uninitMemberVar

Changeset: 9767ed388c69d877e922c211a4103fb275964676

comment:12 Changed 8 years ago by Nick Draper

refs #6142 fix uninitMemberVar

Changeset: 4df84d350174e0741fd16dbbff3261a7cfd759cf

comment:13 Changed 8 years ago by Nick Draper

refs #6142 fix uninitMemberVar

Changeset: e27135c736bbdbcd483cbb393cdd2b515a8a4376

comment:14 Changed 8 years ago by Nick Draper

refs #6142 fix publicAllocationError

Changeset: 850647db79079d7a0caadea5eaf0de2f2fe03a11

comment:15 Changed 8 years ago by Nick Draper

refs #6142 fix uninitMemberVar

Changeset: 26ac83b23cdd738c6c36a9dccaf378c7881d3539

comment:16 Changed 8 years ago by Nick Draper

refs #6142 fix redundantAssignInSwitch

Changeset: c997e478263bfa663a136aa3be41d10bf636ee51

comment:17 Changed 8 years ago by Nick Draper

refs #6142 fix uselessCallsRemove

Changeset: 858309a8a177c221483e863b8fce0077a828eda2

comment:18 Changed 8 years ago by Nick Draper

refs #6142 2nd attempt to ignore boost headers

Changeset: 6a425aa12bd09a668a9b0724a64f97a203ab33af

comment:19 Changed 8 years ago by Mathieu Doucet

comment:20 Changed 8 years ago by Mathieu Doucet

comment:21 Changed 8 years ago by Mathieu Doucet

comment:22 Changed 8 years ago by Wenduo Zhou

Fix a cpp check warning. Refs #6142.

Changeset: 01df312ec183ab381b885d87c6cb0471a0b85bd3

comment:23 Changed 8 years ago by Russell Taylor

Re #6142. PluginFit cppcheck warnings.

Changeset: a6605fb7c01e79fcad4a3d6f9aee1e3fd28c174b

comment:24 Changed 8 years ago by Russell Taylor

Re #6142. QwtHistogram cppcheck warnings.

Changeset: da2d71c8a33d6718b69d71d8c0cb5928175abbb6

comment:25 Changed 8 years ago by Stuart Campbell

refs #6142 - fix postfixOperator

Changeset: 8947d37d0a6b205887e7b965525b6212d6540c15

comment:26 Changed 8 years ago by Stuart Campbell

refs #6142 - remove redundant assignment.

Changeset: 8454b5e3a193bf293ce3eca7bc3b285ba7f0f083

comment:27 Changed 8 years ago by Andrei Savici

Cppcheck warnings. Refs #6142

Changeset: dd10edcaed461a73da89293b8c9ce24857d3a517

comment:28 Changed 8 years ago by Peter Peterson

This should really be part of #6484 or separate tickets for the different bits of refactoring.

comment:29 Changed 8 years ago by Russell Taylor

  • Blocked By 6572 added

comment:30 Changed 8 years ago by Nick Draper

re #6142 last couple of warnings

Changeset: 50aeeca775b21c2d1304f442203f6f29eebcf9b5

comment:31 Changed 8 years ago by Andrei Savici

cppcheck warnings. Refs #6142

Changeset: 004a366ff37e61255b276aaa18ca95d20d222e53

comment:32 Changed 8 years ago by Andrei Savici

fix header for boost::math::isnan. Refs #6142

Changeset: 49e7fc66887e7a227eec31dc67134b557f91fbe0

comment:33 Changed 8 years ago by Andrei Savici

A few more cppcheck warnings. Refs #6142

Changeset: 0e789f9b85fcd45fcc13ad9305c0e08c8c26fe36

comment:34 Changed 8 years ago by Russell Taylor

Re #6142. Remove ICatHelper::doISISSearch method.

It was 100% identical to the ICatHelper::doAdvancedSearch method!

Changeset: f5a3c7f4528e2600197365ffe654ec6332f2749a

comment:35 Changed 8 years ago by Russell Taylor

Re #6142. Remove unused (and duplicate) method.

Changeset: 79000f03dc949f1eab3c7fe7e9f334edb1f4bfd1

comment:36 Changed 8 years ago by Nick Draper

  • Status changed from new to accepted

comment:37 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

closed after the end of the quality day

comment:38 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added options for finer control

Refs #6591 Changed the name of IndexOptimizePeaks to OptimizeCrystalPlacement Refs #6142 Eliminated(hopefully) several warnings or explained them.

Changeset: e49c6b5a87e7c8f3b167d581d25a498522353b9c

comment:39 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:40 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

The cppcheck job has 0 messages marked error or warning which was the aim of the ticket.

comment:41 Changed 8 years ago by Ruth Mikkelson

Refs #6142 Elim compiler warning

Changeset: ba3e5753e8e1fe0acd5dd62d9108db7cac65c47c

comment:42 Changed 8 years ago by Ruth Mikkelson

Refs #6142 Elim compiler warning

Changeset: ba3e5753e8e1fe0acd5dd62d9108db7cac65c47c

comment:43 Changed 8 years ago by Ruth Mikkelson

Refs #6142 Elim compiler warning

Changeset: 509436fb53f9b4d98c660c883395bd86f32d546f

comment:44 Changed 8 years ago by Ruth Mikkelson

Refs #6142 Elim compiler warning

Changeset: 509436fb53f9b4d98c660c883395bd86f32d546f

comment:45 Changed 8 years ago by Ruth Mikkelson

Refs #6142 Elim compiler warning

Changeset: 509436fb53f9b4d98c660c883395bd86f32d546f

comment:46 Changed 8 years ago by Ruth Mikkelson

Refs #6142 Elim compiler warning

Changeset: 509436fb53f9b4d98c660c883395bd86f32d546f

comment:47 Changed 7 years ago by Ruth Mikkelson

Refs #6142 Elim compiler warning

Changeset: 509436fb53f9b4d98c660c883395bd86f32d546f

comment:48 Changed 7 years ago by Ruth Mikkelson

Refs #6142 Elim compiler warning

Changeset: 509436fb53f9b4d98c660c883395bd86f32d546f

comment:49 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6988

Note: See TracTickets for help on using tickets.