Ticket #6550 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Calibrate for sample orientation and position for Rectangular Detectors

Reported by: Ruth Mikkelson Owned by: Ruth Mikkelson
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Ruth Mikkelson) (diff)

Several instruments cannot locate the sample "exactly enough" or determine the sample orientation relative to other runs "exactly enough". This necessitates and algorithm to handle these cases.

Often the errors are caused by the goniometer being tilted. This algorithm allows for finding the tilt.

Change History

comment:1 Changed 8 years ago by Ruth Mikkelson

  • Owner set to Ruth Mikkelson
  • Status changed from new to accepted

comment:2 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Initial checkin for this ticket

Changeset: 9a3d26bc1337eccbb795f9a98bce7c673b7118ad

comment:3 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Rest of the files

Changeset: 422d71e4e9a7e61569e14ba5561032725d34abd1

comment:4 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Eliminated compiler error in Windows

Changeset: 61d3fe5b10828b117f1f66d5f24ed91c5728564c

comment:5 Changed 8 years ago by Russell Taylor

Re #6550. Really fix on windows so that I can push stuff.

BTW - this test takes WAY too long to run.

Changeset: 742042b266f2065037bf63ee85be2dda304f8f57

comment:6 Changed 8 years ago by Ruth Mikkelson

refs #6550 Hopefully fixes wind prob

Changeset: 83328cf8f49e65345447c64b9171dec5e7fb1756

comment:7 Changed 8 years ago by Ruth Mikkelson

Refs #6550. Sped up the unit test

Changeset: c146a7c5f1880965a51681ad2b28bda41482f397

comment:8 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added options for finer control

Refs #6591 Changed the name of IndexOptimizePeaks to OptimizeCrystalPlacement Refs #6142 Eliminated(hopefully) several warnings or explained them.

Changeset: e49c6b5a87e7c8f3b167d581d25a498522353b9c

comment:9 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added properties to OptimizeCrystalPlacement

-Properties to select the peaks used in fitting were added. -A boolean property was added to select whether sample offsets are to be

considered in fitting

-Changed the names of several properties and gave longer prompts -Eliminated IndexPeaks optionq -Sped up the test program a lot. The LoadIsawPeaks now takes almost all the time.

Refs #6086 Added Documentation and explanations

Changeset: 99221a0b46a2f8b61df09c57e761c0ffe6000bec

comment:10 Changed 8 years ago by Ruth Mikkelson

Refs #6550 out has 3 entries per peak. Tilt parameters added

Before the one output per peak was the integer offset of the h,k and l value

that was the max in absolute value.

Now the output for each peak is the integer offset of the h value, then the integer offset of the k value, then the 3rd is the integer offset of the l value.

Changeset: 822776e3a50a759dab15f5f80d07a219afa1e4f6

comment:11 Changed 8 years ago by Ruth Mikkelson

Refs #6550 out has 3 entries per peak. Tilt parameters added

Before the one output per peak was the integer offset of the h,k and l value

that was the max in absolute value.

Now the output for each peak is the integer offset of the h value, then the integer offset of the k value, then the 3rd is the integer offset of the l value.

Changeset: 822776e3a50a759dab15f5f80d07a219afa1e4f6

comment:12 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Description modified (diff)

Tester:

The file in AutoTestData, TOPAZ_5637_8.peaks will work well for testing. There are 2 runs, 5627 and 5638. Allowing everything to change results in large errors in the parameters. Before running Use FindUBFFT then indexPeaks to get into proper form for this algorithm

1St test: KeepGoniometerFixed:5637,5638. OptimizeGoniometerTilt=true, Result->Peak1

2nd test:Use Peak1 from Test 1 , KeepGoniometerFixed: , all options false, Result->Peak2. ......

You can save the PeaksWorkspaces to see differences. The PeaksWorkspaces could also be reindexed, to see any(probably no) differences. There should be few changes since this peaks workspace came from well calibrated experiments.

Last edited 8 years ago by Ruth Mikkelson (previous) (diff)

comment:13 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:14 Changed 8 years ago by Owen Arnold

Which Branch?

comment:15 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added Tilt parameter and 3 output values per peak

Also includes some cpp warning fixes and wiki updates

Changeset: 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1

comment:16 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added Tilt parameter and 3 output values per peak

Also includes some cpp warning fixes and wiki updates

Changeset: 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1

comment:17 Changed 8 years ago by Ruth Mikkelson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:18 Changed 8 years ago by Ruth Mikkelson

  • Status changed from reopened to accepted

comment:19 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added a test program

Changeset: a1fac66778b85e628455eda5a93981db28782699

comment:20 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added a test program for OptimizeCrystalPlacement

Changeset: bd9cd19c6f8ac4c29050e0d68c14c178d802af49

comment:21 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Eliminated commits to redo

Revert "Merge branch 'feature/6550_OptCrystPos' into develop"

This reverts commit e59d1765743f7d525417128cde2228fb4c22cf2a, reversing changes made to dee0a70882860d52a1733362df8baa3916d56803.

Changeset: 636508ae4979910b586c214403e9fbbeee54e6a4

comment:22 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Published a revert already

"Refs #6550 Added a test program"

This reverts commit a1fac66778b85e628455eda5a93981db28782699.

Changeset: 1a6738c886201a20f78d7b5acd8f1639a91491a8

comment:23 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Reverted this commit elsewhere.

Revert "Refs #6550 Added Tilt parameter and 3 output values per peak"

This reverts commit 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1.

Changeset: aac3eea02aee8f41400b5c439b11f005654dcffe

comment:24 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:25 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying

comment:26 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added Tilt parameter and 3 output values per peak

Also includes some cpp warning fixes and wiki updates

Changeset: 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1

comment:27 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added a test program

Changeset: a1fac66778b85e628455eda5a93981db28782699

comment:28 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Published a revert already

"Refs #6550 Added a test program"

This reverts commit a1fac66778b85e628455eda5a93981db28782699.

Changeset: 1a6738c886201a20f78d7b5acd8f1639a91491a8

comment:29 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Reverted this commit elsewhere.

Revert "Refs #6550 Added Tilt parameter and 3 output values per peak"

This reverts commit 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1.

Changeset: aac3eea02aee8f41400b5c439b11f005654dcffe

comment:30 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

I actually merged this into master last week, but forgot to close the ticket.

comment:31 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added Tilt parameter and 3 output values per peak

Also includes some cpp warning fixes and wiki updates

Changeset: 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1

comment:32 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Added a test program

Changeset: a1fac66778b85e628455eda5a93981db28782699

comment:33 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Published a revert already

"Refs #6550 Added a test program"

This reverts commit a1fac66778b85e628455eda5a93981db28782699.

Changeset: 1a6738c886201a20f78d7b5acd8f1639a91491a8

comment:34 Changed 8 years ago by Ruth Mikkelson

Refs #6550 Reverted this commit elsewhere.

Revert "Refs #6550 Added Tilt parameter and 3 output values per peak"

This reverts commit 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1.

Changeset: aac3eea02aee8f41400b5c439b11f005654dcffe

comment:35 Changed 7 years ago by Ruth Mikkelson

Refs #6550 Added Tilt parameter and 3 output values per peak

Also includes some cpp warning fixes and wiki updates

Changeset: 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1

comment:36 Changed 7 years ago by Ruth Mikkelson

Refs #6550 Added a test program

Changeset: a1fac66778b85e628455eda5a93981db28782699

comment:37 Changed 7 years ago by Ruth Mikkelson

Refs #6550 Published a revert already

"Refs #6550 Added a test program"

This reverts commit a1fac66778b85e628455eda5a93981db28782699.

Changeset: 1a6738c886201a20f78d7b5acd8f1639a91491a8

comment:38 Changed 7 years ago by Ruth Mikkelson

Refs #6550 Reverted this commit elsewhere.

Revert "Refs #6550 Added Tilt parameter and 3 output values per peak"

This reverts commit 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1.

Changeset: aac3eea02aee8f41400b5c439b11f005654dcffe

comment:39 Changed 7 years ago by Ruth Mikkelson

Refs #6550 Added Tilt parameter and 3 output values per peak

Also includes some cpp warning fixes and wiki updates

Changeset: 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1

comment:40 Changed 7 years ago by Ruth Mikkelson

Refs #6550 Added a test program

Changeset: a1fac66778b85e628455eda5a93981db28782699

comment:41 Changed 7 years ago by Ruth Mikkelson

Refs #6550 Published a revert already

"Refs #6550 Added a test program"

This reverts commit a1fac66778b85e628455eda5a93981db28782699.

Changeset: 1a6738c886201a20f78d7b5acd8f1639a91491a8

comment:42 Changed 7 years ago by Ruth Mikkelson

Refs #6550 Reverted this commit elsewhere.

Revert "Refs #6550 Added Tilt parameter and 3 output values per peak"

This reverts commit 9e1bb6137bdd8b1ad1c6a15f3e1d2cca028228e1.

Changeset: aac3eea02aee8f41400b5c439b11f005654dcffe

comment:43 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7396

Note: See TracTickets for help on using tickets.