Ticket #6176 (closed: fixed)
Script repository uploads from Mantid
| Reported by: | Nick Draper | Owned by: | Gesner Passos |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | #6174 | |
| Blocking: | #6894 | Tester: | Nick Draper |
Description
Change History
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:3 Changed 7 years ago by Gesner Passos
- Blocked By 6174 added
(In #6174) branch : feature/6174_script_repo_design
Tester: Read the documentation, specially the sections Script Repository GUI and Uploading Strategy. You should agree with this document, and them merge it to master. If you agree, this will be the implemented version of ScriptRepository. (The ScriptRepository Service has already been implemented in #6175).
Attention: the git macros will not work here. You will have to merge using the git commands:
git checkout master git fetch -p git pull --rebase git merge --no-ff origin/feature/6174_script_repo_design
If you agree with the document, publish it:
git fetch git rebase --preserve-merges origin/master git push origin master git push origin :feature/6174_script_repo_design
comment:4 Changed 7 years ago by Gesner Passos
The implementation of upload
It will send the upload form to submit the upload to the script repository.
re #6176
Changeset: c048cb96bb5d7e9dfb204fee7d6d52930821d80d
comment:5 Changed 7 years ago by Gesner Passos
Process the json file received
Instead of returning a HTML it receives the json file and process. It is easier to parse and get the information on exceptions.
re #6176
Changeset: 3efa3358bd4f48d68035a3b4d5f9176dd1914ecc
comment:6 Changed 7 years ago by Gesner Passos
Configure the URL for the uploder for scriptrepository
It will point to the publish_debug for testing, and to publish at production.
re #6176
Changeset: 2ab769ea81986a11a12f24c1e0a2e732be100c22
comment:8 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/6905_script_repository_download_folder' into feature/6176_upload_scripts
Necessary to get differences of #6905
re #6176
Changeset: 751650fd29b976b6746bff93fe0b3176eeea2ce0
comment:9 Changed 7 years ago by Gesner Passos
Solve small issues when upload receive status from server
Some times it is receiveing 500 from the server, but it is nice the answe, and it has uploaded correctly. In this case, we will test the message also.
This commit also corrected a issue with the local json, now it updates correctly the entries.
re #6176
Changeset: 21e620b12a0a419241ba278f87f36ca6ce407fb9
comment:10 Changed 7 years ago by Gesner Passos
- Status changed from new to accepted
Tester:
You should now be able to upload any file to the repository. The framework will get the URL to upload from the Mantid Property: UploaderWebServer. In order to setup a test, we have created another repository: https://github.com/mantidproject/sandbox. If the UploaderWebServer is http://upload.mantidproject.org/scriptrepository/payload/publish_debug, them it will upload the file to the sandbox repository. If the UploaderWebServer = http://upload.mantidproject.org/scriptrepository/payload/publish, (without suffix debug), them it will publish the file to the correct repository: https://github.com/mantidproject/scripts.
This was done, so not to upload useless files to the production repository, which could confuse the users. The correct property will be set on production and the users will be able to upload to the correct place.
If you really want to upload to the correct place, just change that variable in your Mantid.user.properties setting it to publish.
A known issue is that after asking to upload, Mantid will seem 'blocked'. This issue will be dealt with at #6894. For this reason also, I may ask someone to test this ticket before friday.
comment:11 Changed 7 years ago by Gesner Passos
- Status changed from accepted to verify
- Resolution set to fixed
- Blocking 6894 added
comment:12 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:13 Changed 7 years ago by Nick Draper
- Status changed from verifying to reopened
- Resolution fixed deleted
This seems to work fine for files in the root directory and existing directories, but has a problem with new directories.
I created a new directory with a new file in it.
- uploading the new directory gave me an error (permissions error)
- uploading the file ran as if it worked, but nothing was created on the server.
comment:14 Changed 7 years ago by Gesner Passos
The issue presented by @Nick was mainly related to the server part, this commit solves the problem payload_commit.
comment:15 Changed 7 years ago by Gesner Passos
The implementation of upload
It will send the upload form to submit the upload to the script repository.
re #6176
Changeset: c048cb96bb5d7e9dfb204fee7d6d52930821d80d
comment:16 Changed 7 years ago by Gesner Passos
Process the json file received
Instead of returning a HTML it receives the json file and process. It is easier to parse and get the information on exceptions.
re #6176
Changeset: 3efa3358bd4f48d68035a3b4d5f9176dd1914ecc
comment:17 Changed 7 years ago by Gesner Passos
Configure the URL for the uploder for scriptrepository
It will point to the publish_debug for testing, and to publish at production.
re #6176
Changeset: 2ab769ea81986a11a12f24c1e0a2e732be100c22
comment:18 Changed 7 years ago by Gesner Passos
comment:19 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/6905_script_repository_download_folder' into feature/6176_upload_scripts
Necessary to get differences of #6905
re #6176
Changeset: 751650fd29b976b6746bff93fe0b3176eeea2ce0
comment:20 Changed 7 years ago by Gesner Passos
Solve small issues when upload receive status from server
Some times it is receiveing 500 from the server, but it is nice the answe, and it has uploaded correctly. In this case, we will test the message also.
This commit also corrected a issue with the local json, now it updates correctly the entries.
re #6176
Changeset: 21e620b12a0a419241ba278f87f36ca6ce407fb9
comment:22 Changed 7 years ago by Gesner Passos
The implementation of upload
It will send the upload form to submit the upload to the script repository.
re #6176
Changeset: c048cb96bb5d7e9dfb204fee7d6d52930821d80d
comment:23 Changed 7 years ago by Gesner Passos
Process the json file received
Instead of returning a HTML it receives the json file and process. It is easier to parse and get the information on exceptions.
re #6176
Changeset: 3efa3358bd4f48d68035a3b4d5f9176dd1914ecc
comment:24 Changed 7 years ago by Gesner Passos
Configure the URL for the uploder for scriptrepository
It will point to the publish_debug for testing, and to publish at production.
re #6176
Changeset: 2ab769ea81986a11a12f24c1e0a2e732be100c22
comment:25 Changed 7 years ago by Gesner Passos
comment:26 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/6905_script_repository_download_folder' into feature/6176_upload_scripts
Necessary to get differences of #6905
re #6176
Changeset: 751650fd29b976b6746bff93fe0b3176eeea2ce0
comment:27 Changed 7 years ago by Gesner Passos
Solve small issues when upload receive status from server
Some times it is receiveing 500 from the server, but it is nice the answe, and it has uploaded correctly. In this case, we will test the message also.
This commit also corrected a issue with the local json, now it updates correctly the entries.
re #6176
Changeset: 21e620b12a0a419241ba278f87f36ca6ce407fb9
comment:28 Changed 7 years ago by Gesner Passos
Disable upload of entire new folders.
It requires to upload file one-by-one. At least in this version.
re #6176
Changeset: 6239a26ccfd9cd587fa096b2fc7e4d7d2c4e0dcf
comment:29 Changed 7 years ago by Gesner Passos
Improve the way we process information from server
re #6176
Changeset: d30afe8a1e848122ef9bbb28e1c2a11c4cd9899d
comment:30 Changed 7 years ago by Gesner Passos
Get the pub_date from the upload
The upload server now provides the pub_date of the file inside its local folder. This allows ScriptRepository to correctly identifies the status of the uploaded files.
re #6176
Changeset: a61f8f5244629857f0025443c74982e9065a384d
comment:31 Changed 7 years ago by Gesner Passos
Deal with warning issue of defined but not used
Removing the notImplemented function.
re #6176
Changeset: ff78ebdf59a232c96aa03473f223617ef25a84c0
comment:32 Changed 7 years ago by Gesner Passos
- Status changed from accepted to verify
- Resolution set to fixed
comment:33 Changed 7 years ago by Gesner Passos
The implementation of upload
It will send the upload form to submit the upload to the script repository.
re #6176
Changeset: c048cb96bb5d7e9dfb204fee7d6d52930821d80d
comment:34 Changed 7 years ago by Gesner Passos
Process the json file received
Instead of returning a HTML it receives the json file and process. It is easier to parse and get the information on exceptions.
re #6176
Changeset: 3efa3358bd4f48d68035a3b4d5f9176dd1914ecc
comment:35 Changed 7 years ago by Gesner Passos
Configure the URL for the uploder for scriptrepository
It will point to the publish_debug for testing, and to publish at production.
re #6176
Changeset: 2ab769ea81986a11a12f24c1e0a2e732be100c22
comment:36 Changed 7 years ago by Gesner Passos
comment:37 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/6905_script_repository_download_folder' into feature/6176_upload_scripts
Necessary to get differences of #6905
re #6176
Changeset: 751650fd29b976b6746bff93fe0b3176eeea2ce0
comment:38 Changed 7 years ago by Gesner Passos
Solve small issues when upload receive status from server
Some times it is receiveing 500 from the server, but it is nice the answe, and it has uploaded correctly. In this case, we will test the message also.
This commit also corrected a issue with the local json, now it updates correctly the entries.
re #6176
Changeset: 21e620b12a0a419241ba278f87f36ca6ce407fb9
comment:39 Changed 7 years ago by Gesner Passos
Disable upload of entire new folders.
It requires to upload file one-by-one. At least in this version.
re #6176
Changeset: 6239a26ccfd9cd587fa096b2fc7e4d7d2c4e0dcf
comment:40 Changed 7 years ago by Gesner Passos
Improve the way we process information from server
re #6176
Changeset: d30afe8a1e848122ef9bbb28e1c2a11c4cd9899d
comment:41 Changed 7 years ago by Gesner Passos
Get the pub_date from the upload
The upload server now provides the pub_date of the file inside its local folder. This allows ScriptRepository to correctly identifies the status of the uploaded files.
re #6176
Changeset: a61f8f5244629857f0025443c74982e9065a384d
comment:42 Changed 7 years ago by Gesner Passos
Deal with warning issue of defined but not used
Removing the notImplemented function.
re #6176
Changeset: ff78ebdf59a232c96aa03473f223617ef25a84c0
comment:43 Changed 7 years ago by Gesner Passos
Disable upload of entire new folders.
It requires to upload file one-by-one. At least in this version.
re #6176
Changeset: 6239a26ccfd9cd587fa096b2fc7e4d7d2c4e0dcf
comment:44 Changed 7 years ago by Gesner Passos
Improve the way we process information from server
re #6176
Changeset: d30afe8a1e848122ef9bbb28e1c2a11c4cd9899d
comment:45 Changed 7 years ago by Gesner Passos
Get the pub_date from the upload
The upload server now provides the pub_date of the file inside its local folder. This allows ScriptRepository to correctly identifies the status of the uploaded files.
re #6176
Changeset: a61f8f5244629857f0025443c74982e9065a384d
comment:46 Changed 7 years ago by Gesner Passos
Deal with warning issue of defined but not used
Removing the notImplemented function.
re #6176
Changeset: ff78ebdf59a232c96aa03473f223617ef25a84c0
comment:47 Changed 7 years ago by Gesner Passos
The implementation of upload
It will send the upload form to submit the upload to the script repository.
re #6176
Changeset: c048cb96bb5d7e9dfb204fee7d6d52930821d80d
comment:48 Changed 7 years ago by Gesner Passos
Process the json file received
Instead of returning a HTML it receives the json file and process. It is easier to parse and get the information on exceptions.
re #6176
Changeset: 3efa3358bd4f48d68035a3b4d5f9176dd1914ecc
comment:49 Changed 7 years ago by Gesner Passos
Configure the URL for the uploder for scriptrepository
It will point to the publish_debug for testing, and to publish at production.
re #6176
Changeset: 2ab769ea81986a11a12f24c1e0a2e732be100c22
comment:50 Changed 7 years ago by Gesner Passos
comment:51 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/6905_script_repository_download_folder' into feature/6176_upload_scripts
Necessary to get differences of #6905
re #6176
Changeset: 751650fd29b976b6746bff93fe0b3176eeea2ce0
comment:52 Changed 7 years ago by Gesner Passos
Solve small issues when upload receive status from server
Some times it is receiveing 500 from the server, but it is nice the answe, and it has uploaded correctly. In this case, we will test the message also.
This commit also corrected a issue with the local json, now it updates correctly the entries.
re #6176
Changeset: 21e620b12a0a419241ba278f87f36ca6ce407fb9
comment:53 Changed 7 years ago by Gesner Passos
Disable upload of entire new folders.
It requires to upload file one-by-one. At least in this version.
re #6176
Changeset: 6239a26ccfd9cd587fa096b2fc7e4d7d2c4e0dcf
comment:54 Changed 7 years ago by Gesner Passos
Improve the way we process information from server
re #6176
Changeset: d30afe8a1e848122ef9bbb28e1c2a11c4cd9899d
comment:55 Changed 7 years ago by Gesner Passos
Get the pub_date from the upload
The upload server now provides the pub_date of the file inside its local folder. This allows ScriptRepository to correctly identifies the status of the uploaded files.
re #6176
Changeset: a61f8f5244629857f0025443c74982e9065a384d
comment:56 Changed 7 years ago by Gesner Passos
Deal with warning issue of defined but not used
Removing the notImplemented function.
re #6176
Changeset: ff78ebdf59a232c96aa03473f223617ef25a84c0
comment:58 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
tested with sub folder and files with spaces
comment:59 Changed 7 years ago by Gesner Passos
The implementation of upload
It will send the upload form to submit the upload to the script repository.
re #6176
Changeset: c048cb96bb5d7e9dfb204fee7d6d52930821d80d
comment:60 Changed 7 years ago by Gesner Passos
Process the json file received
Instead of returning a HTML it receives the json file and process. It is easier to parse and get the information on exceptions.
re #6176
Changeset: 3efa3358bd4f48d68035a3b4d5f9176dd1914ecc
comment:61 Changed 7 years ago by Gesner Passos
Configure the URL for the uploder for scriptrepository
It will point to the publish_debug for testing, and to publish at production.
re #6176
Changeset: 2ab769ea81986a11a12f24c1e0a2e732be100c22
comment:62 Changed 7 years ago by Gesner Passos
comment:63 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/6905_script_repository_download_folder' into feature/6176_upload_scripts
Necessary to get differences of #6905
re #6176
Changeset: 751650fd29b976b6746bff93fe0b3176eeea2ce0
comment:64 Changed 7 years ago by Gesner Passos
Solve small issues when upload receive status from server
Some times it is receiveing 500 from the server, but it is nice the answe, and it has uploaded correctly. In this case, we will test the message also.
This commit also corrected a issue with the local json, now it updates correctly the entries.
re #6176
Changeset: 21e620b12a0a419241ba278f87f36ca6ce407fb9
comment:65 Changed 7 years ago by Gesner Passos
Disable upload of entire new folders.
It requires to upload file one-by-one. At least in this version.
re #6176
Changeset: 6239a26ccfd9cd587fa096b2fc7e4d7d2c4e0dcf
comment:66 Changed 7 years ago by Gesner Passos
Improve the way we process information from server
re #6176
Changeset: d30afe8a1e848122ef9bbb28e1c2a11c4cd9899d
comment:67 Changed 7 years ago by Gesner Passos
Get the pub_date from the upload
The upload server now provides the pub_date of the file inside its local folder. This allows ScriptRepository to correctly identifies the status of the uploaded files.
re #6176
Changeset: a61f8f5244629857f0025443c74982e9065a384d
comment:68 Changed 7 years ago by Gesner Passos
Deal with warning issue of defined but not used
Removing the notImplemented function.
re #6176
Changeset: ff78ebdf59a232c96aa03473f223617ef25a84c0
comment:69 Changed 7 years ago by Gesner Passos
The implementation of upload
It will send the upload form to submit the upload to the script repository.
re #6176
Changeset: c048cb96bb5d7e9dfb204fee7d6d52930821d80d
comment:70 Changed 7 years ago by Gesner Passos
Process the json file received
Instead of returning a HTML it receives the json file and process. It is easier to parse and get the information on exceptions.
re #6176
Changeset: 3efa3358bd4f48d68035a3b4d5f9176dd1914ecc
comment:71 Changed 7 years ago by Gesner Passos
Configure the URL for the uploder for scriptrepository
It will point to the publish_debug for testing, and to publish at production.
re #6176
Changeset: 2ab769ea81986a11a12f24c1e0a2e732be100c22
comment:72 Changed 7 years ago by Gesner Passos
comment:73 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/6905_script_repository_download_folder' into feature/6176_upload_scripts
Necessary to get differences of #6905
re #6176
Changeset: 751650fd29b976b6746bff93fe0b3176eeea2ce0
comment:74 Changed 7 years ago by Gesner Passos
Solve small issues when upload receive status from server
Some times it is receiveing 500 from the server, but it is nice the answe, and it has uploaded correctly. In this case, we will test the message also.
This commit also corrected a issue with the local json, now it updates correctly the entries.
re #6176
Changeset: 21e620b12a0a419241ba278f87f36ca6ce407fb9
comment:75 Changed 7 years ago by Gesner Passos
Disable upload of entire new folders.
It requires to upload file one-by-one. At least in this version.
re #6176
Changeset: 6239a26ccfd9cd587fa096b2fc7e4d7d2c4e0dcf
comment:76 Changed 7 years ago by Gesner Passos
Improve the way we process information from server
re #6176
Changeset: d30afe8a1e848122ef9bbb28e1c2a11c4cd9899d
comment:77 Changed 7 years ago by Gesner Passos
Get the pub_date from the upload
The upload server now provides the pub_date of the file inside its local folder. This allows ScriptRepository to correctly identifies the status of the uploaded files.
re #6176
Changeset: a61f8f5244629857f0025443c74982e9065a384d
comment:78 Changed 7 years ago by Gesner Passos
Deal with warning issue of defined but not used
Removing the notImplemented function.
re #6176
Changeset: ff78ebdf59a232c96aa03473f223617ef25a84c0
comment:79 Changed 7 years ago by Gesner Passos
The implementation of upload
It will send the upload form to submit the upload to the script repository.
re #6176
Changeset: c048cb96bb5d7e9dfb204fee7d6d52930821d80d
comment:80 Changed 7 years ago by Gesner Passos
Process the json file received
Instead of returning a HTML it receives the json file and process. It is easier to parse and get the information on exceptions.
re #6176
Changeset: 3efa3358bd4f48d68035a3b4d5f9176dd1914ecc
comment:81 Changed 7 years ago by Gesner Passos
Configure the URL for the uploder for scriptrepository
It will point to the publish_debug for testing, and to publish at production.
re #6176
Changeset: 2ab769ea81986a11a12f24c1e0a2e732be100c22
comment:82 Changed 7 years ago by Gesner Passos
comment:83 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/6905_script_repository_download_folder' into feature/6176_upload_scripts
Necessary to get differences of #6905
re #6176
Changeset: 751650fd29b976b6746bff93fe0b3176eeea2ce0
comment:84 Changed 7 years ago by Gesner Passos
Solve small issues when upload receive status from server
Some times it is receiveing 500 from the server, but it is nice the answe, and it has uploaded correctly. In this case, we will test the message also.
This commit also corrected a issue with the local json, now it updates correctly the entries.
re #6176
Changeset: 21e620b12a0a419241ba278f87f36ca6ce407fb9
comment:85 Changed 7 years ago by Gesner Passos
Disable upload of entire new folders.
It requires to upload file one-by-one. At least in this version.
re #6176
Changeset: 6239a26ccfd9cd587fa096b2fc7e4d7d2c4e0dcf
comment:86 Changed 7 years ago by Gesner Passos
Improve the way we process information from server
re #6176
Changeset: d30afe8a1e848122ef9bbb28e1c2a11c4cd9899d
comment:87 Changed 7 years ago by Gesner Passos
Get the pub_date from the upload
The upload server now provides the pub_date of the file inside its local folder. This allows ScriptRepository to correctly identifies the status of the uploaded files.
re #6176
Changeset: a61f8f5244629857f0025443c74982e9065a384d
comment:88 Changed 7 years ago by Gesner Passos
Deal with warning issue of defined but not used
Removing the notImplemented function.
re #6176
Changeset: ff78ebdf59a232c96aa03473f223617ef25a84c0
comment:89 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7022
