Ticket #6894 (closed: fixed)
ScriptRepository not responsive when downloading big files
Reported by: | Gesner Passos | Owned by: | Gesner Passos |
---|---|---|---|
Priority: | blocker | Milestone: | Release 2.5 |
Component: | Mantid | Keywords: | ScriptRepository |
Cc: | alex.buts@…, nick.draper@… | Blocked By: | #6176 |
Blocking: | Tester: | Nick Draper |
Description
Try to download big files from ScriptRepository and it becomes un-responsible, in Windows, it will appear a message that MantidPlot has crashed.
Change History
comment:4 Changed 7 years ago by Gesner Passos
Separation of download/upload in thread
To speed up the interaction with the user, it executes the downloading and uploading in another thread.
re #6894
Changeset: 138288f65d9d73dd24e8ebf89d87eb241a0e5a24
comment:5 Changed 7 years ago by Gesner Passos
Merge branch 'feature/6176_upload_scripts' into feature/6894_responsiveness_script_repo
This was necessary to allow us to speed up the interaction with the upload and fetch the changes on download as well.
re #6894
Changeset: cf54c899f238ddb0ae9d9ee1a7c970b6812d68a2
comment:6 Changed 7 years ago by Gesner Passos
Add a new icon for the ScriptRepository
re #6894
Changeset: b33b65f20cea04d777256551717a18f234cccea2
comment:7 Changed 7 years ago by Gesner Passos
Show the icon of running processing
This helps the user to identify that download and uploading is running.
re #6894
Changeset: f4169a4d7ebf14247b746595a357bd672c7b1781
comment:8 Changed 7 years ago by Gesner Passos
Solve warnings at cppcheck for ScriptRepositoryImpl
re #6894
Changeset: cd968a021dbed72de3711a171a4ff639db050807
comment:9 Changed 7 years ago by Gesner Passos
Separation of download/upload in thread
To speed up the interaction with the user, it executes the downloading and uploading in another thread.
re #6894
Changeset: 138288f65d9d73dd24e8ebf89d87eb241a0e5a24
comment:10 Changed 7 years ago by Gesner Passos
Merge branch 'feature/6176_upload_scripts' into feature/6894_responsiveness_script_repo
This was necessary to allow us to speed up the interaction with the upload and fetch the changes on download as well.
re #6894
Changeset: cf54c899f238ddb0ae9d9ee1a7c970b6812d68a2
comment:11 Changed 7 years ago by Gesner Passos
Add a new icon for the ScriptRepository
re #6894
Changeset: b33b65f20cea04d777256551717a18f234cccea2
comment:12 Changed 7 years ago by Gesner Passos
Show the icon of running processing
This helps the user to identify that download and uploading is running.
re #6894
Changeset: f4169a4d7ebf14247b746595a357bd672c7b1781
comment:13 Changed 7 years ago by Gesner Passos
Solve warnings at cppcheck for ScriptRepositoryImpl
re #6894
Changeset: cd968a021dbed72de3711a171a4ff639db050807
comment:14 Changed 7 years ago by Gesner Passos
- Cc alex.buts@…, nick.draper@… added
The upload is also implemented in a separate thread, so you should be able to upload, and not be 'frozen'.
I've added a new icon to tell that it is processing, and changed the ToolTip to say that it is downloading or uploading.
And that is it.
comment:15 Changed 7 years ago by Gesner Passos
- Status changed from accepted to verify
- Resolution set to fixed
Now, when the user asks to download or upload, he will be served from a separate thread. Giving him the opportunity to do any other thing. This allows the QT application to serve the events, and them, it will not say anymore that it is blocked, or suggest it has crashed.
comment:16 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:17 Changed 7 years ago by Gesner Passos
Separation of download/upload in thread
To speed up the interaction with the user, it executes the downloading and uploading in another thread.
re #6894
Changeset: 138288f65d9d73dd24e8ebf89d87eb241a0e5a24
comment:18 Changed 7 years ago by Gesner Passos
Merge branch 'feature/6176_upload_scripts' into feature/6894_responsiveness_script_repo
This was necessary to allow us to speed up the interaction with the upload and fetch the changes on download as well.
re #6894
Changeset: cf54c899f238ddb0ae9d9ee1a7c970b6812d68a2
comment:19 Changed 7 years ago by Gesner Passos
Add a new icon for the ScriptRepository
re #6894
Changeset: b33b65f20cea04d777256551717a18f234cccea2
comment:20 Changed 7 years ago by Gesner Passos
Show the icon of running processing
This helps the user to identify that download and uploading is running.
re #6894
Changeset: f4169a4d7ebf14247b746595a357bd672c7b1781
comment:21 Changed 7 years ago by Gesner Passos
Solve warnings at cppcheck for ScriptRepositoryImpl
re #6894
Changeset: cd968a021dbed72de3711a171a4ff639db050807
comment:22 Changed 7 years ago by Gesner Passos
Separation of download/upload in thread
To speed up the interaction with the user, it executes the downloading and uploading in another thread.
re #6894
Changeset: 138288f65d9d73dd24e8ebf89d87eb241a0e5a24
comment:23 Changed 7 years ago by Gesner Passos
Merge branch 'feature/6176_upload_scripts' into feature/6894_responsiveness_script_repo
This was necessary to allow us to speed up the interaction with the upload and fetch the changes on download as well.
re #6894
Changeset: cf54c899f238ddb0ae9d9ee1a7c970b6812d68a2
comment:24 Changed 7 years ago by Gesner Passos
Add a new icon for the ScriptRepository
re #6894
Changeset: b33b65f20cea04d777256551717a18f234cccea2
comment:25 Changed 7 years ago by Gesner Passos
Show the icon of running processing
This helps the user to identify that download and uploading is running.
re #6894
Changeset: f4169a4d7ebf14247b746595a357bd672c7b1781
comment:26 Changed 7 years ago by Gesner Passos
Solve warnings at cppcheck for ScriptRepositoryImpl
re #6894
Changeset: cd968a021dbed72de3711a171a4ff639db050807
comment:28 Changed 7 years ago by Gesner Passos
Separation of download/upload in thread
To speed up the interaction with the user, it executes the downloading and uploading in another thread.
re #6894
Changeset: 138288f65d9d73dd24e8ebf89d87eb241a0e5a24
comment:29 Changed 7 years ago by Gesner Passos
Merge branch 'feature/6176_upload_scripts' into feature/6894_responsiveness_script_repo
This was necessary to allow us to speed up the interaction with the upload and fetch the changes on download as well.
re #6894
Changeset: cf54c899f238ddb0ae9d9ee1a7c970b6812d68a2
comment:30 Changed 7 years ago by Gesner Passos
Add a new icon for the ScriptRepository
re #6894
Changeset: b33b65f20cea04d777256551717a18f234cccea2
comment:31 Changed 7 years ago by Gesner Passos
Show the icon of running processing
This helps the user to identify that download and uploading is running.
re #6894
Changeset: f4169a4d7ebf14247b746595a357bd672c7b1781
comment:32 Changed 7 years ago by Gesner Passos
Solve warnings at cppcheck for ScriptRepositoryImpl
re #6894
Changeset: cd968a021dbed72de3711a171a4ff639db050807
comment:33 Changed 7 years ago by Gesner Passos
Separation of download/upload in thread
To speed up the interaction with the user, it executes the downloading and uploading in another thread.
re #6894
Changeset: 138288f65d9d73dd24e8ebf89d87eb241a0e5a24
comment:34 Changed 7 years ago by Gesner Passos
Merge branch 'feature/6176_upload_scripts' into feature/6894_responsiveness_script_repo
This was necessary to allow us to speed up the interaction with the upload and fetch the changes on download as well.
re #6894
Changeset: cf54c899f238ddb0ae9d9ee1a7c970b6812d68a2
comment:35 Changed 7 years ago by Gesner Passos
Add a new icon for the ScriptRepository
re #6894
Changeset: b33b65f20cea04d777256551717a18f234cccea2
comment:36 Changed 7 years ago by Gesner Passos
Show the icon of running processing
This helps the user to identify that download and uploading is running.
re #6894
Changeset: f4169a4d7ebf14247b746595a357bd672c7b1781
comment:37 Changed 7 years ago by Gesner Passos
Solve warnings at cppcheck for ScriptRepositoryImpl
re #6894
Changeset: cd968a021dbed72de3711a171a4ff639db050807
comment:38 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7740
Tester: