Ticket #6180 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

IDF: replace mark-as by is

Reported by: Nick Draper Owned by: Anders Markvardsen
Priority: critical Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

Also update existing IDFs

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Priority changed from major to critical

comment:2 Changed 8 years ago by Anders Markvardsen

In IDF replace mark-as by is. re #6180

Note have updated all the existing IDF to the best of my ability to use is="monitor" rather than mark-as="monitor"

Changeset: 5b9ffe8223318260e1201b5e036c480077433b91

comment:3 Changed 8 years ago by Michael Reuter

Refs #6180. Fixing filename to make RPM build happy.

Is this file really necessary?

Changeset: 36f9e847c3c07cc1b2e560197de12eec31d92f84

comment:4 Changed 8 years ago by Anders Markvardsen

Erase vtp file added by mistake. re #6180

Changeset: da43f0f5483e8f7abebdda960303aedea4a2ae35

comment:5 Changed 8 years ago by Anders Markvardsen

In IDF replace mark-as by is. re #6180

Note have updated all the existing IDF to the best of my ability to use is="monitor" rather than mark-as="monitor"

Changeset: 5b9ffe8223318260e1201b5e036c480077433b91

comment:6 Changed 8 years ago by Michael Reuter

Refs #6180. Fixing filename to make RPM build happy.

Is this file really necessary?

Changeset: 36f9e847c3c07cc1b2e560197de12eec31d92f84

comment:7 Changed 8 years ago by Anders Markvardsen

Erase vtp file added by mistake. re #6180

Changeset: da43f0f5483e8f7abebdda960303aedea4a2ae35

comment:8 Changed 8 years ago by Anders Markvardsen

  • Status changed from new to accepted

To test do a search in instrument folder for mark-as and you should find zero hits

comment:9 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:11 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I don't know how important this is but there appear to be a couple left:

grep -n 'mark-as' Code/Mantid/instrument/* 

Code/Mantid/instrument/IN5_Definition.xml:44:	<component type="monitor" mark-as="monitor">
Code/Mantid/instrument/POWGEN_Definition_2012-11-27.xml:39:    <component type="monitor" mark-as="monitor">

comment:12 Changed 8 years ago by Anders Markvardsen

Couple more mark-as removed. Re #6180

Changeset: a3f5154a0cc037773ac5228065b6ab6aca9a4442

comment:13 Changed 8 years ago by Anders Markvardsen

  • Status changed from reopened to accepted

comment:14 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester changed from Martyn Gigg to Nick Draper

comment:16 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

tested with grepwin, the instrument directory came up clear

comment:17 Changed 8 years ago by Anders Markvardsen

Couple more mark-as removed. Re #6180

Changeset: a3f5154a0cc037773ac5228065b6ab6aca9a4442

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7026

Note: See TracTickets for help on using tickets.