Ticket #6181 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

IDF: support locations tag

Reported by: Nick Draper Owned by: Anders Markvardsen
Priority: critical Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

To allow lists of locations to be specified, as discussed at the developer workshop

Change History

comment:1 Changed 8 years ago by Anders Markvardsen

Some structure in place to support <locations> tag. re #6181

Changeset: 1b515d4159af2810cba98a38cf1b5b723982d7df

comment:2 Changed 8 years ago by Anders Markvardsen

Revert "Some structure in place to support <locations> tag. re #6181"

This reverts commit 1b515d4159af2810cba98a38cf1b5b723982d7df.

Changeset: 79a55640cb8064ae590057874bf5eb516a874236

comment:3 Changed 8 years ago by Anders Markvardsen

The reason for the revert above was the following systemtests unmotivated failed:

SystemTests.DirectInelasticDiagnostic.DirectInelasticDiagnostic 20 min 2 SystemTests.ISISDirectInelastic.LETReduction 0 ms 2 SystemTests.LoadLotsOfInstruments.LoadLotsOfInstruments

comment:4 Changed 8 years ago by Anders Markvardsen

Some structure in place to support <locations> tag. re #6181

Changeset: 3f3d06c2c7bf009095cea671ed0ebdd6f6b5b93b

comment:5 Changed 8 years ago by Anders Markvardsen

Revert "Some structure in place to support <locations> tag. re #6181"

This reverts commit 1b515d4159af2810cba98a38cf1b5b723982d7df.

Changeset: f8daf1950c452ffc785ef9125ebc5f3bd4ae3d22

comment:6 Changed 8 years ago by Anders Markvardsen

Remove what a none active idlist in SANS_Definition.xml. re #6181

Changeset: c6800c32ca9a02678eaa2d3556b11579ab91266b

comment:7 Changed 8 years ago by Anders Markvardsen

Code to <locations> resubmitted. re #6181

Changeset: 2c8edd11e1717f704813d35c6d1351f744b86e74

comment:8 Changed 8 years ago by Anders Markvardsen

Remove what a none active idlist in SANS_Definition.xml. re #6181

Changeset: c6800c32ca9a02678eaa2d3556b11579ab91266b

comment:9 Changed 8 years ago by Anders Markvardsen

Code to <locations> resubmitted. re #6181

Changeset: 2c8edd11e1717f704813d35c6d1351f744b86e74

comment:10 Changed 8 years ago by Anders Markvardsen

Some cleanup - adding const to arg lists. re #6181

And a change in code to enable this

Changeset: 8fb63e5ff4fa217404caccbbe9c248d6eb036d66

comment:11 Changed 8 years ago by Anders Markvardsen

More structure to handle <locations>. re #6181

Changeset: a515bb564c0094f2e6945451eafd2e48c169c44b

comment:12 Changed 8 years ago by Anders Markvardsen

When it comes to testing, what is expected from this ticket is to support shorthand notation like:

<locations r="2.5" t="121.19498" t-end="135.69059" n-elements="1024" name="tube_1_/>

which is short for 1024 <location> elements from 't' to 't-end' including these two end points. This means that the spacing in t-value is 't' - 't-end' / (1024-1)

Last edited 8 years ago by Anders Markvardsen (previous) (diff)

comment:13 Changed 8 years ago by Anders Markvardsen

code for <locations> plus ut. re #6181

Changeset: b2e21373bbe73959f20b3de0d0ab2d2158b5b1ba

comment:14 Changed 8 years ago by Anders Markvardsen

Remove what a none active idlist in SANS_Definition.xml. re #6181

Changeset: 72b8241887534d35ad99e921e6ba697b9f0b4d9e

comment:15 Changed 8 years ago by Anders Markvardsen

Code to <locations> resubmitted. re #6181

Changeset: dccded80246a0512a8c9f920acf7c7eb4dde9052

comment:16 Changed 8 years ago by Anders Markvardsen

Some cleanup - adding const to arg lists. re #6181

And a change in code to enable this

Changeset: 04b1a54c668685ef2dc331b429e1a6d4208f4998

comment:17 Changed 8 years ago by Anders Markvardsen

More structure to handle <locations>. re #6181

Changeset: 9881ff0e86876b3ec2ece631edc9f91dbcf055ab

comment:18 Changed 8 years ago by Anders Markvardsen

code for <locations> plus ut. re #6181

Changeset: 879a73e041b3d87d3aec6919c2fc7fcf41b423bb

comment:19 Changed 8 years ago by Anders Markvardsen

Remembered to also handle name case. Re #6181

Changeset: c89c66349fb51a49bfbfcf470c7481ae63349d30

comment:20 Changed 8 years ago by Anders Markvardsen

make locations work regardless of where in three used. re #6181

by fixing a bug had introduced

Changeset: d5d74d4679cd28d1dcbf6f4720854e761a9a2164

comment:21 Changed 8 years ago by Anders Markvardsen

Use <locations> in LET. re #6181

Changeset: 4484576f223270f290fba3a6d6b82affd01038e0

comment:22 Changed 8 years ago by Anders Markvardsen

Add attribute to set start count of name. Re #6181

Changeset: ebfc6e3b35351df3eec25a409eb7df5d568b3585

comment:23 Changed 8 years ago by Anders Markvardsen

  • Status changed from new to accepted

Wiki page doc created: http://www.mantidproject.org/InstrumentDefinitionFile#Using_.3Clocations.3E

Option for test

  1. Take any instrument IDF which contains tube or otherwise repeat detectors
  2. Change the IDF to use <locations> as specified in Wiki doc

pass if instrument is the same before and after

comment:24 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:25 Changed 8 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:26 Changed 8 years ago by Karl Palmen

  • Status changed from verifying to closed

I did the test with the MERLIN standard tube and it worked for the full 3-D view, but for the 2D view it no longer showed the DAT file calibration of the tubes.

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7027

Note: See TracTickets for help on using tickets.