Ticket #6187 (inprogress)

Opened 8 years ago

Last modified 5 years ago

Currently there are two ways to set a WS name, there should be 1

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: critical Milestone: Backlog
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: #6797 Tester:

Description


Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Milestone changed from Release 2.4 to Release 2.5

comment:2 Changed 8 years ago by Nick Draper

  • Priority changed from critical to blocker

comment:3 Changed 8 years ago by Martyn Gigg

  • Milestone changed from Release 2.5 to Release 2.6

comment:4 Changed 8 years ago by Russell Taylor

  • Blocking 6797 added

comment:5 Changed 7 years ago by Nick Draper

  • Keywords Maintenance added
  • Priority changed from blocker to critical

comment:6 Changed 7 years ago by Martyn Gigg

  • Milestone changed from Release 2.6 to Release 2.7

Batch move to 2.7

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.7 to Backlog

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:9 Changed 7 years ago by Martyn Gigg

  • Milestone changed from Backlog to Release 3.0

comment:10 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

Added a nameOfObject method to the DataService

It does a simple linear search of the service for a matching object. Refs #6187

Changeset: fcdb1b5591317ad964b32f002893320dae00d87d

comment:11 Changed 7 years ago by Martyn Gigg

Remove Workspace::setName method

The name is now a pure lookup into the ADS. The rename/remove methods no longer need to be overloaded in the ADS so have been removed. The add/addOrReplace are still required for the additional WorkspaceGroup behaviour. The add/addOrReplace methods have been refactored and a bug fixed where the name on the workspace could be updated even if the DataService method was going to throw. Refs #6187

Changeset: fcf4731d006fa238e7700014615699eacc3fd479

comment:12 Changed 7 years ago by Martyn Gigg

Remove unused and confusing method on ITableWorkspace.

It was doing far too many things with the ADS. Refs #6187

Changeset: f3a62bc05774f1d168e50504a2c56e467212af99

comment:13 Changed 7 years ago by Martyn Gigg

Tidyup/remove many usages of getName in algorithms.

Use setProperty and workspace pointer for child algorithms and getPropertyValue for other situations. Refs #6187

Changeset: 28e7156fd100c832de8d901b16ea1c45b9ea98d3

comment:14 Changed 7 years ago by Martyn Gigg

Checkpointing. LoadTest doesn't work yet. Refs #6187

Changeset: 38c26693fd405d774200def8e0864237ce95e96b

comment:15 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.0 to Backlog

Moved out to backlog as not enough time in R3.0

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7033

Note: See TracTickets for help on using tickets.