Ticket #6193 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

slim down binary tests, possibly introduce system test

Reported by: Nick Draper Owned by: Russell Taylor
Priority: major Milestone: Release 3.0
Component: Framework Keywords: Maintenance
Cc: Blocked By: #2738
Blocking: Tester: Michael Reuter

Description


Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:2 Changed 8 years ago by Russell Taylor

  • Blocked By 2738 added

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:4 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:5 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:6 Changed 7 years ago by Russell Taylor

  • Keywords Maintenance added
  • Milestone changed from Backlog to Release 3.0

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #6193. Remove longer test put in when we had some failures.

...since resolved.

Changeset: a4c1911b4e1e9f408c450479db1b3fc9a4d0f748

comment:8 Changed 7 years ago by Russell Taylor

Re #6193. Reduce the sizes of the workspaces tested.

Also re-use workspaces where possible rather than creating identical ones over and over again. Note that this is not always possible as in some instances the input workspace is modified.

Changeset: fd01fa2d6766581fcd70ca806ecb8c428044429c

comment:9 Changed 7 years ago by Russell Taylor

Re #6193. Reduce the sizes of the workspaces tested.

Also re-use workspaces where possible rather than creating identical ones over and over again. Note that this is not always possible as in some instances the input workspace is modified.

Changeset: 9baf767f9c610ebbdd7826e73ecc2bb8529370a9

comment:10 Changed 7 years ago by Russell Taylor

Re #6193. Slim down 'grouped' tests.

Fewer pixels & events, otherwise unchanged.

Changeset: c8cb191ff99a653f77e46326fe441fdaff395ae0

comment:11 Changed 7 years ago by Russell Taylor

Re #6193. Slim down BinaryOperationTest.

There's no way that last test needed to be that big.

Changeset: c89e072b8acb93bec300b97a3da6b82caa9c5daa

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester: Branch is feature/6193_slim_down_binary_op_tests

The tests are mostly using smaller datasets as input now. Only a couple of tests have been removed that were duplicating others.

I'm entirely comfortable that these algorithms are already adequately covered within existing system tests. Here is how many times each of them is called directly (and there'll be more places where they're called indirectly): Plus - 15, Minus - 7, Multiply - 4, Divide - 30.

comment:13 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:14 Changed 7 years ago by Michael Reuter

It looks like quite a size reduction went on here.

comment:15 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/6193_slim_down_binary_op_tests'

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7039

Note: See TracTickets for help on using tickets.