Ticket #6194 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Replace the usage of sub algorithm with child algorithm

Reported by: Nick Draper Owned by: Nick Draper
Priority: critical Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Let us just have one term for this purpose.

Both in code and documentation

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner changed from Peter Peterson to Nick Draper

I'm giving this a go with a simple search and replace

comment:2 Changed 8 years ago by Nick Draper

  • updated wiki based on simple search
  • Updated code with searches on subAlg, sub-Alg and sub alg
  • Renamed a couple of sub alg filenames
  • Updated design document

comment:3 Changed 8 years ago by Nick Draper

comment:4 Changed 8 years ago by Nick Draper

refs #6194 sub-alg to child alg name change

Changeset: beffd5056926e4decd421954f3b4598be8b4c7ac

comment:5 Changed 8 years ago by Nick Draper

  • Status changed from assigned to accepted

comment:6 Changed 8 years ago by Nick Draper

To test search the code for sub algorithm, or more important take a specific look at the algorithm class

comment:7 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Nick Draper

refs #6194 sub-alg to child alg name change

Changeset: 5efbeea5470612b2bb74106254179a0efa7c6456

comment:9 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:10 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

There is still mention of sub algorithm in two files. The first one must be removed:

Mantid/Framework/PythonInterface/PythonAlgorithms/LoadVesuvio.py:557

# More verbose until the sub algorithm stuff is sorted

The seccond one may stay, because it does not directly mentions that it is dealing with a child algorithm. But, I would remove as well:

Mantid/Framework/PythonAPI/test/PythonAlgorithmTest.py: sub_alg

# Get the algorithm property
sub_alg = self._getAlgorithmProperty("Algo")
sub_alg.execute()
self.setPropertyValue("OutputWorkspace", sub_alg.getPropertyValue("OutputWorkspace"))

comment:11 Changed 8 years ago by Nick Draper

re #6194 caught a couple of straggler sub algorithm references

Changeset: aeaddad080a89f7f4a290c9e14f6d1d513c1e512

comment:12 Changed 8 years ago by Nick Draper

  • Status changed from reopened to assigned

comment:13 Changed 8 years ago by Nick Draper

  • Status changed from assigned to accepted

comment:14 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

Both instances above dealt with

comment:15 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Gesner Passos to Martyn Gigg

comment:16 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed that sub-alg, subAlg etc references seem to be gone.

comment:17 Changed 8 years ago by Nick Draper

re #6194 caught a couple of straggler sub algorithm references

Changeset: aeaddad080a89f7f4a290c9e14f6d1d513c1e512

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7040

Note: See TracTickets for help on using tickets.