Workspace mapping methods must handle grouped detectors

[Nick Draper]

These are the methods that I think Stuart added to create vectors of detector_id given workspaces indexes and the other similar methods.

There was some concern that they might not all be capable of handling grouped detectors correctly.

Please check and expand as necessary.

[Stuart Campbell]

I don't remember adding anything - can you be more specific to where in the code to look?

[Nick Draper]

Moved at the code freeze for release 2.4

[Stuart Campbell]

I haven't had chance to learn about this at all.

[Nick Draper]

Both functions in MatrixWorkspace already have boolean properties that make them work as we want.

Set a default so that the default is to handle groups properly.

Added a hasGroupedDetectors method as people were using the mapping methods to answer that question which was misleading.

Changed all usages where the default was specified to use the default.

Next steps are to hunt down all usages where the algorithm is written to throw on groups and improve, then remove the throw on groups option and code as is leads to lazy development.

[Nick Draper]

re #6197 changed default for getDetectorIDToWorkspaceIndexMap

Changeset: 526705a8a65ed1e941f1d379eab2a56c2c320a26

[Nick Draper]

#7241 created to deal with remaining ussages of true

[Michael Reuter]

Missed setting the default for getDetectorIDToWorkspaceIndexMap in a few classes:

Code/Mantid/Framework/DataHandling/src/SaveToSNSHistogramNexus.cpp
Code/Mantid/Framework/DataHandling/src/LoadCalFile.cpp
Code/Mantid/Framework/Crystal/src/IntegratePeakTimeSlices.cpp

[Nick Draper]

Ah, people left spaces around false on those ones.

[Nick Draper]

re #6197 get missing default usages

Changeset: 9b34998cfe3063281ece534206222d573c21bc02

[Russell Taylor]

Note that there's a gcc warning at line 563 of MatrixWorkspaceTest: ​https://builds.sns.gov/job/ornl_clean_rhel6_develop/1987/warnings22Result/ (The line just needs deleting.)

[Nick Draper]

re #6197 clear warning

Changeset: d11e93635df6bcd0c5b5d018138f570df683116d

[Nick Draper]

(In #6067) Subtickets for this are in the Blocked By list.

This ticket is complete when they are!

[Gesner Passos]

Missed setting the default for getDetectorIDToWorkspaceIndexMap in one class

Code/Mantid/Framework/Algorithms/src/MaskBinsFromTable.cpp:270

[Nick Draper]

Merge remote-tracking branch 'origin/feature/6197_group_handling'

[Stuart Campbell]

This ticket has been transferred to github issue ​7043