Ticket #6199 (closed: invalid)

Opened 8 years ago

Last modified 5 years ago

workspace Tree storage in ADS +groups +dock

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.6
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: #6443 Tester: Owen Arnold

Description

We need to consider what to do about update signals, particularly for the members of groups

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Keywords Maintenance added

comment:2 Changed 7 years ago by Nick Draper

  • Blocking 6443 added

(In #6443) This may well be fixed by #6199

comment:3 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:4 Changed 7 years ago by Russell Taylor

Just to note that I'm doing some work in #6803 that may impact this. I am likely to move the suppression of hidden workspaces from the DataService class to MantidDock. Add the ticket as a blocker if you want to be safe.

comment:5 Changed 7 years ago by Roman Tolchenov

Started changes to WorkspaceGroup with simple use cases.

Re #6199.

Changeset: e37fdb5a998ae9fd02ee754d7223eb230586942d

comment:6 Changed 7 years ago by Roman Tolchenov

More work on adding workspaces to groups. Re #6199.

Changeset: 5d9b994b1246fc795d4d3adfec9827599b1088b4

comment:7 Changed 7 years ago by Roman Tolchenov

Added find method to AnalysisDataService. More group tests. Re #6199.

Changeset: 46d0480e35e3859f050944fe32610b24c28b34d7

comment:8 Changed 7 years ago by Roman Tolchenov

Changes to removing methods of WorkspaceGroup. Re #6199

Changeset: e0f8a5044db3045d2da722b1187f4cddee6ca276

comment:9 Changed 7 years ago by Roman Tolchenov

Re #6199. deepRemove removes all workspace copies from ADS.

Changeset: 10ebba9b41b5761dc70ea32ea0886f4e106591f5

comment:10 Changed 7 years ago by Roman Tolchenov

Changes to setName method to support ADS consistency. Re #6199

Changeset: 77036d21babb30787ae7f19cdbf2e0579f111f4f

comment:11 Changed 7 years ago by Roman Tolchenov

APITest passes for me. Re #6199

Changeset: 87dd437f6bd441726f2e3a3caf7acde0b40b9cf3

comment:12 Changed 7 years ago by Roman Tolchenov

Removed notification observation from workspace group. Re #6199.

Changeset: e9fb37eb8435a882c33249b5d37b872d66d0f467

comment:13 Changed 7 years ago by Roman Tolchenov

Made setName private in Workspace and WorkspaceGroup. Re #6199.

Changeset: 9ef86c600ca5968757f030ab2a6eb5bd019635b6

comment:14 Changed 7 years ago by Roman Tolchenov

API and Algoriths tests pass. Re #6199.

Changeset: 7a1a8f59eb965cf9e76d4654ac5b932d31783a2b

comment:15 Changed 7 years ago by Roman Tolchenov

DataObjects and DataHandling tests pass. Re #6199

Exceptions are SaveCanSAS1DTest(2) which I cannot understand how to fix.

Changeset: 009565beb12393b0d4f98268dc45dc13e02a4713

comment:16 Changed 7 years ago by Roman Tolchenov

Changes to Crystal tests. Re #6199

Changeset: 0faf3bde49fa9738401019c9721090a2bafb4536

comment:17 Changed 7 years ago by Roman Tolchenov

Crystal tests pass. Re #6199

Changeset: 7433107eb861024d6da8b2c8c13188746164a30d

comment:18 Changed 7 years ago by Roman Tolchenov

Added methods to the ADS for working with groups. Re #6199

Changeset: 61ccd448ded6e426d2b3b631d3b8e7fd45f432da

comment:19 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to invalid

The idea of having a tree structure in the ADS has been abandoned. Work on workspace groups is continued in #7253

comment:20 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:21 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

The new method in #7253 looks like it's been widely approved. So this can be abandoned. None of these changes will make it to Master.

comment:22 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7045

Note: See TracTickets for help on using tickets.