Ticket #6212 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Inst View: Move grouping functions to Mask tab

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: doucetm@…, alex.buts@… Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Martyn Gigg) (diff)

The grouping functionality in the pick tab would be better off in the masking tab. This would give better control of grouping, make more usability sense and consolidate the underlying source code.

Changes:

  1. Rename Mask tab to Mask/Group
  2. Add a Toggle button at the top for "Mask/Group"
  3. In group mode the text for the save as need to change to include/exclude as opposed to ROI/mask
  4. Remove grouping context menu options from pick mode (Group, Mask, Create Grouping File)
  5. Update wiki documentation
  6. As per #6128, the grouping file should not be hardcoded to save to the install bin directory
  7. Check with Mathieu Doucet that these changes are OK as he hosts this tab in one of the sane interfaces.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:2 Changed 8 years ago by Martyn Gigg

  • Description modified (diff)

comment:3 Changed 8 years ago by Alex Buts

  • Cc alex.buts@… added

comment:4 Changed 8 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:5 Changed 8 years ago by Roman Tolchenov

Moving grouping functionality to Mask/Group tab.

Re #6212.

Changeset: de59bda8f09dc0913dfbd2b6fd44621c19b2fd08

comment:6 Changed 8 years ago by Roman Tolchenov

Other changes:

  1. Use different colour for the shapes border when masking and grouping.
  2. Add hot keys to switch between tools.
  3. Add navigation button to Pick tab.

comment:7 Changed 8 years ago by Roman Tolchenov

Moved all grouping to Mask/Group tab. Re #6212.

Changeset: a85ff0403f8521b83b9b37f78c523ca557a1a216

comment:8 Changed 8 years ago by Roman Tolchenov

Added shortcuts. Re #6212.

Changeset: e7f6a060868438ae25e9915ab8167c592aab4c43

comment:9 Changed 8 years ago by Roman Tolchenov

Change 10 will be implemented in separate ticket #6761.

comment:10 Changed 8 years ago by Roman Tolchenov

Improved pick image drawing. Re #6212.

Changeset: 97a663195e606165da895aa0e238b8d61505d361

comment:11 Changed 8 years ago by Roman Tolchenov

Moving grouping functionality to Mask/Group tab.

Re #6212.

Changeset: de59bda8f09dc0913dfbd2b6fd44621c19b2fd08

comment:12 Changed 8 years ago by Roman Tolchenov

Moved all grouping to Mask/Group tab. Re #6212.

Changeset: a85ff0403f8521b83b9b37f78c523ca557a1a216

comment:13 Changed 8 years ago by Roman Tolchenov

Added shortcuts. Re #6212.

Changeset: e7f6a060868438ae25e9915ab8167c592aab4c43

comment:14 Changed 8 years ago by Roman Tolchenov

Improved pick image drawing. Re #6212.

Changeset: 97a663195e606165da895aa0e238b8d61505d361

comment:15 Changed 8 years ago by Roman Tolchenov

Merge branch 'feature/6212_grouping_functions_in_mask_tab' into develop. Re #6212

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/InstrumentWindow.cpp

Changeset: 5d675031be4dcae64f6078048e718aa0a5f06ee9

comment:16 Changed 8 years ago by Roman Tolchenov

Fix doxygen warning. Re #6212.

Changeset: cb82c1c62d954fdd832c5af655e4fa073d04d90c

comment:17 Changed 8 years ago by Roman Tolchenov

Fix doxygen warning. Re #6212.

Changeset: cb82c1c62d954fdd832c5af655e4fa073d04d90c

comment:18 Changed 8 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:19 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:20 Changed 8 years ago by Roman Tolchenov

Moving grouping functionality to Mask/Group tab.

Re #6212.

Changeset: de59bda8f09dc0913dfbd2b6fd44621c19b2fd08

comment:21 Changed 8 years ago by Roman Tolchenov

Moved all grouping to Mask/Group tab. Re #6212.

Changeset: a85ff0403f8521b83b9b37f78c523ca557a1a216

comment:22 Changed 8 years ago by Roman Tolchenov

Added shortcuts. Re #6212.

Changeset: e7f6a060868438ae25e9915ab8167c592aab4c43

comment:23 Changed 8 years ago by Roman Tolchenov

Improved pick image drawing. Re #6212.

Changeset: 97a663195e606165da895aa0e238b8d61505d361

comment:24 Changed 8 years ago by Roman Tolchenov

Fix doxygen warning. Re #6212.

Changeset: cb82c1c62d954fdd832c5af655e4fa073d04d90c

comment:25 Changed 8 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/6212_grouping_functions_in_mask_tab' Refs #6212

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/InstrumentWindow.cpp

Changeset: 314f706883c37288eebf36e6fe15e6c00bd0613d

comment:26 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

Tested with MERLIN data from the system test folder and everything seems to work as suggested with the exception of point 10 in comment 6 which will be implemented under #6761.

comment:27 Changed 7 years ago by Roman Tolchenov

Moving grouping functionality to Mask/Group tab.

Re #6212.

Changeset: de59bda8f09dc0913dfbd2b6fd44621c19b2fd08

comment:28 Changed 7 years ago by Roman Tolchenov

Moved all grouping to Mask/Group tab. Re #6212.

Changeset: a85ff0403f8521b83b9b37f78c523ca557a1a216

comment:29 Changed 7 years ago by Roman Tolchenov

Added shortcuts. Re #6212.

Changeset: e7f6a060868438ae25e9915ab8167c592aab4c43

comment:30 Changed 7 years ago by Roman Tolchenov

Improved pick image drawing. Re #6212.

Changeset: 97a663195e606165da895aa0e238b8d61505d361

comment:31 Changed 7 years ago by Roman Tolchenov

Fix doxygen warning. Re #6212.

Changeset: cb82c1c62d954fdd832c5af655e4fa073d04d90c

comment:32 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/6212_grouping_functions_in_mask_tab' Refs #6212

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/InstrumentWindow.cpp

Changeset: 314f706883c37288eebf36e6fe15e6c00bd0613d

comment:33 Changed 7 years ago by Roman Tolchenov

Moving grouping functionality to Mask/Group tab.

Re #6212.

Changeset: de59bda8f09dc0913dfbd2b6fd44621c19b2fd08

comment:34 Changed 7 years ago by Roman Tolchenov

Moved all grouping to Mask/Group tab. Re #6212.

Changeset: a85ff0403f8521b83b9b37f78c523ca557a1a216

comment:35 Changed 7 years ago by Roman Tolchenov

Added shortcuts. Re #6212.

Changeset: e7f6a060868438ae25e9915ab8167c592aab4c43

comment:36 Changed 7 years ago by Roman Tolchenov

Improved pick image drawing. Re #6212.

Changeset: 97a663195e606165da895aa0e238b8d61505d361

comment:37 Changed 7 years ago by Roman Tolchenov

Fix doxygen warning. Re #6212.

Changeset: cb82c1c62d954fdd832c5af655e4fa073d04d90c

comment:38 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/6212_grouping_functions_in_mask_tab' Refs #6212

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/InstrumentWindow.cpp

Changeset: 314f706883c37288eebf36e6fe15e6c00bd0613d

comment:39 Changed 7 years ago by Roman Tolchenov

Moving grouping functionality to Mask/Group tab.

Re #6212.

Changeset: de59bda8f09dc0913dfbd2b6fd44621c19b2fd08

comment:40 Changed 7 years ago by Roman Tolchenov

Moved all grouping to Mask/Group tab. Re #6212.

Changeset: a85ff0403f8521b83b9b37f78c523ca557a1a216

comment:41 Changed 7 years ago by Roman Tolchenov

Added shortcuts. Re #6212.

Changeset: e7f6a060868438ae25e9915ab8167c592aab4c43

comment:42 Changed 7 years ago by Roman Tolchenov

Improved pick image drawing. Re #6212.

Changeset: 97a663195e606165da895aa0e238b8d61505d361

comment:43 Changed 7 years ago by Roman Tolchenov

Fix doxygen warning. Re #6212.

Changeset: cb82c1c62d954fdd832c5af655e4fa073d04d90c

comment:44 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/6212_grouping_functions_in_mask_tab' Refs #6212

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/InstrumentWindow.cpp

Changeset: 314f706883c37288eebf36e6fe15e6c00bd0613d

comment:45 Changed 7 years ago by Roman Tolchenov

Moving grouping functionality to Mask/Group tab.

Re #6212.

Changeset: de59bda8f09dc0913dfbd2b6fd44621c19b2fd08

comment:46 Changed 7 years ago by Roman Tolchenov

Moved all grouping to Mask/Group tab. Re #6212.

Changeset: a85ff0403f8521b83b9b37f78c523ca557a1a216

comment:47 Changed 7 years ago by Roman Tolchenov

Added shortcuts. Re #6212.

Changeset: e7f6a060868438ae25e9915ab8167c592aab4c43

comment:48 Changed 7 years ago by Roman Tolchenov

Improved pick image drawing. Re #6212.

Changeset: 97a663195e606165da895aa0e238b8d61505d361

comment:49 Changed 7 years ago by Roman Tolchenov

Fix doxygen warning. Re #6212.

Changeset: cb82c1c62d954fdd832c5af655e4fa073d04d90c

comment:50 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/6212_grouping_functions_in_mask_tab' Refs #6212

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/InstrumentWindow.cpp

Changeset: 314f706883c37288eebf36e6fe15e6c00bd0613d

comment:51 Changed 7 years ago by Roman Tolchenov

Improved pick image drawing. Re #6212.

Changeset: 97a663195e606165da895aa0e238b8d61505d361

comment:52 Changed 7 years ago by Roman Tolchenov

Fix doxygen warning. Re #6212.

Changeset: cb82c1c62d954fdd832c5af655e4fa073d04d90c

comment:53 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/6212_grouping_functions_in_mask_tab' Refs #6212

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/InstrumentWindow.cpp

Changeset: 314f706883c37288eebf36e6fe15e6c00bd0613d

comment:54 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7058

Note: See TracTickets for help on using tickets.