SANS: Display / 1D Analysis allow selecting deleted workspaces

[Gesner Passos]

The Display tab on SANS interface (that will be renamed to 1D Analysis #6226 ) shows in the workspace combobox deleted workspaces.

In fact, its filtering is not working well. It should show only 1D workspaces (I believe we should assume a workspace with just one spectra), but, right now, it allows the user to select many spectra workspaces, deleted workspaces, but but some times does not show the ones it should

To reproduce the defect do the following:

• Open SANS Interface (Menu->Interfaces->SANS ISIS)
• Select LOQ instrument (combobox -> Run Numbers tab)
• Load User file ([systemtest]/Data/LOQ/MASK.CENTER)
• Change to Geometry Tab
• Set the BeamCentre radio to 'front' or 'hab'
• Change the max iterations to 3 (to speed up the process)
• Change to the Display/1DAnalysis tab
• Open the workspace combobox

You will see for example Down_tmp that is not available on the Workspaces MantidPlot, but will not see Down (the one you should see, because it is a reduced file)

[Nick Draper]

Moved at the code freeze for release 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Nick Draper]

Moved to backlog at the code freeze for R2.6

[Gesner Passos]

Run this with the SANS interface opened, and you will see three lines with 'left' workspace written in the Workspace input at Sans Analysis interface.

for i in range(3):
	left_tmp = CreateWorkspace([1], [1])
	left = RenameWorkspace(left_tmp)

[Gesner Passos]

Correct WorkspaceSelector to avoid duplicate workspace names

re #6227

Changeset: 61d324ecdc7a78b24c1b444eb617415be3300727

[Gesner Passos]

Tester:

The easiest way to check that this ticket has been fixed is running the script in comment:11. But you may want to run the description as well, which has triggered the ticket. What is important is that the WorkspaceSelector should not display the same name twice.

[Jay Rainey]

Merge remote-tracking branch 'origin/bugfix/6227_sans_1d_analysis'

[Jay Rainey]

Testing

• The 1D Analysis tab no longer shows deleted workspaces & only shows 1D workspaces.
• Tested on Ubuntu 12.04

Code Review

• Clean, and easy to understand (well written) code.

[Stuart Campbell]

This ticket has been transferred to github issue ​7073