Ticket #6232 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Have ShowDetectors option on PeaksWorkspace

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description (last modified by Martyn Gigg) (diff)

Add a Show Detectors option to the peaks workspace context menu in MantiPlot. This keeps it consistent with seeing detectors in other workspaces

The table will simply be a two column table of index & DetID where index will give the row in the corresponding PeaksWorkspace table.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Martyn Gigg

Allow peak to store contributing detectors. Refs #6232

Changeset: db4305fe44eba29cfc1d6b5f7390add3a0875615

comment:3 Changed 8 years ago by Martyn Gigg

  • Description modified (diff)
  • Summary changed from Extend FindPeaksMD to output table of contributing detectors to Have ShowDetectors option on PeaksWorkspace

comment:4 Changed 8 years ago by Martyn Gigg

PeaksWorkspace can create a detector table. Refs #6232

Lists the contributing detectors for each peak.

Changeset: b2e99a34ff73026beff51d6d4af147f888ff1829

comment:5 Changed 8 years ago by Martyn Gigg

Missed other files from previous commit. Refs #6232

Changeset: 10fc07867b0db9a5e3ec0b279dbbd970a296500f

comment:6 Changed 8 years ago by Martyn Gigg

FakeMDEventData now adds detector Ids for full events. Refs #6232

Changeset: 8142a6ab42bf26096064a1c50fc083a4f431d2da

comment:7 Changed 8 years ago by Martyn Gigg

FindPeaksMD keeps track of detector IDs for full events. Refs #6232

Changeset: 3b1f4fe99e198d69f6135d84cb9209bc1efa6bc8

comment:8 Changed 8 years ago by Martyn Gigg

Remove test stub. Refs #6232

Changeset: ab87ec5defa7db8b68e59316150d8fc5939f4650

comment:9 Changed 8 years ago by Martyn Gigg

Add Show Detectors option to peaks workspace. Refs #6232

It will only show the centre detector for lean events & histo workspaces.

Changeset: daedba7daac09cfe931ded52e882e530dd5c47a1

comment:10 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 8 years ago by Martyn Gigg

Tester: Run the following script

LoadEventNexus(Filename=r'TOPAZ_3132_event.nxs',OutputWorkspace='TOPAZ_3131_nxs')
ConvertToMD(InputWorkspace='TOPAZ_3131_nxs',OutputWorkspace='TOPAZ_3131_md',LorentzCorrection='1',QDimensions='Q3D',dEAnalysisMode='Elastic',QConversionScales='HKL',MinValues='-1000,-1000,-1000',MaxValues='1000,1000,1000')
FindPeaksMD(InputWorkspace='TOPAZ_3131_md',PeakDistanceThreshold='0.15',MaxPeaks='100',OutputWorkspace='peaks')

which will produce a peaks workspace called 'peaks'. Right click on the entry in the dock and you should see a new "Show Detectors" option (the same as the standard option). Click it and it should open the table view of the PeaksWorkspace along with a new table listing the detector IDs for each peak.

comment:12 Changed 8 years ago by Martyn Gigg

Allow peak to store contributing detectors. Refs #6232

Changeset: db4305fe44eba29cfc1d6b5f7390add3a0875615

comment:13 Changed 8 years ago by Martyn Gigg

PeaksWorkspace can create a detector table. Refs #6232

Lists the contributing detectors for each peak.

Changeset: b2e99a34ff73026beff51d6d4af147f888ff1829

comment:14 Changed 8 years ago by Martyn Gigg

Missed other files from previous commit. Refs #6232

Changeset: 10fc07867b0db9a5e3ec0b279dbbd970a296500f

comment:15 Changed 8 years ago by Martyn Gigg

FakeMDEventData now adds detector Ids for full events. Refs #6232

Changeset: 8142a6ab42bf26096064a1c50fc083a4f431d2da

comment:16 Changed 8 years ago by Martyn Gigg

FindPeaksMD keeps track of detector IDs for full events. Refs #6232

Changeset: 3b1f4fe99e198d69f6135d84cb9209bc1efa6bc8

comment:17 Changed 8 years ago by Martyn Gigg

Remove test stub. Refs #6232

Changeset: ab87ec5defa7db8b68e59316150d8fc5939f4650

comment:18 Changed 8 years ago by Martyn Gigg

Add Show Detectors option to peaks workspace. Refs #6232

It will only show the centre detector for lean events & histo workspaces.

Changeset: daedba7daac09cfe931ded52e882e530dd5c47a1

comment:19 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:20 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I see two tables when doing show detectors which is not at all what I expected. I get the peaks table as well as the detectors table.

comment:21 Changed 8 years ago by Martyn Gigg

Micheal, the two tables was the idea. To follow suit with the current show detectors option on MatrixWorkspaces. The idea was that most wouldn't want to see the detector IDs except for "debugging" and have a separate table seemed cleaner to do that rather than polluting the main table.

Happy to keep it open if the feeling is that's not what we want?

comment:22 Changed 8 years ago by Michael Reuter

It's OK with me. I just wasn't expecting that. You can go ahead are reclose this.

comment:23 Changed 8 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:24 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:25 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:26 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

This works correctly.

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7078

Note: See TracTickets for help on using tickets.