Ticket #6247 (closed: fixed)
Make PeakOverlays Work in QLab and QSample
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | #5167 | |
| Blocking: | Tester: | Vickie Lynch |
Description
Addition to the PeaksOverlays in the SliceViewer
Query the MD Workspace to find the most appropriate coordinate system to use from the PeaksWorkspace.
Change History
comment:2 Changed 8 years ago by Owen Arnold
refs #6247 existing PeakTransform -> PeakTransformHKL
Changeset: ca597260b14f483ecc9030fa1c73575bf30920ba
comment:3 Changed 8 years ago by Owen Arnold
refs #6247. Refactor common code to base class.
Changeset: 61701e50e2c0943493d9db9a64189c5a79dcf887
comment:4 Changed 8 years ago by Owen Arnold
refs #6247. Make Factories for PeakTransforms.
Changeset: 6fd54ba74204aa6d8e1d22a1489f7bf93b5a8f71
comment:5 Changed 8 years ago by Owen Arnold
refs #6247. Use PeakTransformFactory everwhere.
Will still need a mechanism to select the factory. PeakTransformSelector will do this.
Changeset: d0f546db5d7b4ccd17af962f6474c3be5f2fcf34
comment:6 Changed 8 years ago by Owen Arnold
refs #6247. PeakTransformSelector created.
Changeset: 2c234dbfc1087ed9973a53931f446bdd46d27971
comment:7 Changed 8 years ago by Owen Arnold
refs #6247. PeakTransformSelector wired-in.
Vertical stripe through new functionality complete. All that remains is to add and register the new PeakTransforms and factories.
Changeset: fa269bc53054f5392e613b9c8abd6c2cd2dc23a5
comment:8 Changed 8 years ago by Owen Arnold
refs #6247. Specialize for PeakTransformQLab.
Changeset: 141b20bcd9a4454e7163e83eb8d42d7f7d5bb8fb
comment:9 Changed 8 years ago by Owen Arnold
refs #6247. Specialize for PeakTransformQSample.
Changeset: 320aa280518f231a6b13bfbf3d0ec1510c9efbc8
comment:10 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC error.
Changeset: 61d97c6a7bc93fc36c7f0e856b380c8e53f3f00d
comment:11 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC error.
Changeset: b759be6891cc87747dbdc8182fd0a4de883805a0
comment:12 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC error in test.
Changeset: 8e4c6977a7ff1161f772f22d7f29621da51e0372
comment:13 Changed 8 years ago by Owen Arnold
refs #6247. Fix logic error in test.
Changeset: ab6ddbd096989daa4e9565f884ae862c2b1bead6
comment:14 Changed 8 years ago by Owen Arnold
refs #6247. Fix logic error in test.
Changeset: 7332fefdf9fec0ae1335003891852921bc6281e5
comment:15 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC gmock Locking issue.
Changeset: 5ba50a48f578ae2bdfcdc67b3d56a835472ee479
comment:16 Changed 8 years ago by Owen Arnold
refs #6247. Fix unused var warning.
Changeset: f48f91cc26c2e6f09508a60de5c0ba7ce310d0d1
comment:17 Changed 8 years ago by Owen Arnold
refs #6247 existing PeakTransform -> PeakTransformHKL
Changeset: 8cc1a951ed8dcc04d3a2e493767ed19bba8e1c6a
comment:18 Changed 8 years ago by Owen Arnold
refs #6247. Refactor common code to base class.
Changeset: 207ce99ae1efc34e45d05e15ac33dbe9b39cc0c2
comment:19 Changed 8 years ago by Owen Arnold
refs #6247. Make Factories for PeakTransforms.
Changeset: 903be4780a1141c17de5edb94af780a2bfef64c2
comment:20 Changed 8 years ago by Owen Arnold
refs #6247. Use PeakTransformFactory everwhere.
Will still need a mechanism to select the factory. PeakTransformSelector will do this.
Changeset: 41e2eb49873fce72c11cbd6cc49c3984a1aadcbf
comment:21 Changed 8 years ago by Owen Arnold
refs #6247. PeakTransformSelector created.
Changeset: a0b68dda757dee23e701470e4e1ef210745f5037
comment:22 Changed 8 years ago by Owen Arnold
refs #6247. PeakTransformSelector wired-in.
Vertical stripe through new functionality complete. All that remains is to add and register the new PeakTransforms and factories.
Changeset: b1b134fcfc592e1ea525de8dabeef990f32fc871
comment:23 Changed 8 years ago by Owen Arnold
refs #6247. Specialize for PeakTransformQLab.
Changeset: 08cea9a86723aeb90848d00e9c3bc60b1b33a022
comment:24 Changed 8 years ago by Owen Arnold
refs #6247. Specialize for PeakTransformQSample.
Changeset: 46a7e5bbceb75381d875ade01a92a30b3f84c2bb
comment:25 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC error.
Changeset: d4668438e466ec2d7b85a4a5bdc294231a1a9c9e
comment:26 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC error.
Changeset: 2d03fff9df589d65ed173ff9c626d2f36a75b317
comment:27 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC error in test.
Changeset: ae4df5fb9735e0a30053aee0a8c0b8ac24babebe
comment:28 Changed 8 years ago by Owen Arnold
refs #6247. Fix logic error in test.
Changeset: 5f4e4713c3feb65eb1869ce71cf720c0f895e9ea
comment:29 Changed 8 years ago by Owen Arnold
refs #6247. Fix logic error in test.
Changeset: 0dfde3a8f3ab02ea6431c8c5e2ee98d5c0808957
comment:30 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC gmock Locking issue.
Changeset: bd63a56c7ac6470919edf88e97d5f10208955158
comment:31 Changed 8 years ago by Owen Arnold
refs #6247. Fix unused var warning.
Changeset: 126aedb044e898f1c7d8720b2a7a078b0afc6240
comment:32 Changed 8 years ago by Owen Arnold
Tester: Follow the test instructions in #5167, which utilises Diffraction_Workflow_Test.py . Aside from using the MD Workspace in HKL TOPAZ_3132_HKL, you should be able to also plot the peaks workspaces over the top of the workspaces converted to Lab Q and Sample Q. Such workspaces are also created as part of Diffraction_Workflow_Test.py
comment:33 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
comment:34 Changed 8 years ago by Owen Arnold
refs #6247 existing PeakTransform -> PeakTransformHKL
Changeset: 8cc1a951ed8dcc04d3a2e493767ed19bba8e1c6a
comment:35 Changed 8 years ago by Owen Arnold
refs #6247. Refactor common code to base class.
Changeset: 207ce99ae1efc34e45d05e15ac33dbe9b39cc0c2
comment:36 Changed 8 years ago by Owen Arnold
refs #6247. Make Factories for PeakTransforms.
Changeset: 903be4780a1141c17de5edb94af780a2bfef64c2
comment:37 Changed 8 years ago by Owen Arnold
refs #6247. Use PeakTransformFactory everwhere.
Will still need a mechanism to select the factory. PeakTransformSelector will do this.
Changeset: 41e2eb49873fce72c11cbd6cc49c3984a1aadcbf
comment:38 Changed 8 years ago by Owen Arnold
refs #6247. PeakTransformSelector created.
Changeset: a0b68dda757dee23e701470e4e1ef210745f5037
comment:39 Changed 8 years ago by Owen Arnold
refs #6247. PeakTransformSelector wired-in.
Vertical stripe through new functionality complete. All that remains is to add and register the new PeakTransforms and factories.
Changeset: b1b134fcfc592e1ea525de8dabeef990f32fc871
comment:40 Changed 8 years ago by Owen Arnold
refs #6247. Specialize for PeakTransformQLab.
Changeset: 08cea9a86723aeb90848d00e9c3bc60b1b33a022
comment:41 Changed 8 years ago by Owen Arnold
refs #6247. Specialize for PeakTransformQSample.
Changeset: 46a7e5bbceb75381d875ade01a92a30b3f84c2bb
comment:42 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC error.
Changeset: d4668438e466ec2d7b85a4a5bdc294231a1a9c9e
comment:43 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC error.
Changeset: 2d03fff9df589d65ed173ff9c626d2f36a75b317
comment:44 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC error in test.
Changeset: ae4df5fb9735e0a30053aee0a8c0b8ac24babebe
comment:45 Changed 8 years ago by Owen Arnold
refs #6247. Fix logic error in test.
Changeset: 5f4e4713c3feb65eb1869ce71cf720c0f895e9ea
comment:46 Changed 8 years ago by Owen Arnold
refs #6247. Fix logic error in test.
Changeset: 0dfde3a8f3ab02ea6431c8c5e2ee98d5c0808957
comment:47 Changed 8 years ago by Owen Arnold
refs #6247. Fix GCC gmock Locking issue.
Changeset: bd63a56c7ac6470919edf88e97d5f10208955158
comment:48 Changed 8 years ago by Owen Arnold
refs #6247. Fix unused var warning.
Changeset: 126aedb044e898f1c7d8720b2a7a078b0afc6240
comment:49 Changed 8 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:50 Changed 8 years ago by Vickie Lynch
- Status changed from verifying to closed
Works using TOPAZ peaks
comment:51 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7093
My initial thoughts are
1) That the PeaksWorkspace contains all the information we need to plot in any of the target coordinate systems.
2) That this can largely be handled via Polymorphism around the PeakOverlayTransform.
3) We might need some mechanism to select the right PeakOverlayTransform. I'd prefer a ChainOfResponsibility rather than a Manager class, but i'll not pre-judge until I've taken a better look at the design.