Ticket #6248 (closed: fixed)
Allow Multiple Peak Ws to be displayed by the PlotOverlays
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | major | Milestone: | Release 2.4 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | #5167 | |
Blocking: | Tester: | Vickie Lynch |
Description (last modified by Owen Arnold) (diff)
This is an addition to the SliceViewer.
My initial thoughts are that this can be almost entirely handled by introducing a CompositePeaksPresenter, which can take multiple PeaksPresenters. Adding a new PeaksWorkspace would simply be a case of adding a presenter to the composite.
Remember to update the class diagram for any new additions to the types (#6250).
Change History
comment:3 Changed 8 years ago by Owen Arnold
refs #6248. Make working CompositePeaksPresenter.
Changeset: c1724eaf7a0c4727d4d646c0b8ec16d69e392f7f
comment:4 Changed 8 years ago by Owen Arnold
refs #6248. Swap in CompositePeaksPresenter.
No change in behaviour as a result of putting this in with the current 1 workspace only setup. This is a good position to start now allowing multiple peakspresenters. Also applied minor fix here resulting from not updating the slicing widget pointer.
Changeset: 7d84e6865ca3e2ebcf8eb21ceb86292175a78f9c
comment:5 Changed 8 years ago by Owen Arnold
refs #6248. PeakFactoryOverlay takes colour number
Changeset: e0c2460f9008a9ef3beb965e6edc0e92b124cc98
comment:6 Changed 8 years ago by Owen Arnold
refs #6248. Fully handling multiple peaks workspaces.
Changeset: 45d4574a582c09d5bfdbffd40fc83f7c43ddf13a
comment:7 Changed 8 years ago by Owen Arnold
refs #6248. Fix gcc exception issue.
Changeset: ca2c4a421595beac50360008ff0e7574f194e5a8
comment:8 Changed 8 years ago by Owen Arnold
refs #6248. Make working CompositePeaksPresenter.
Changeset: c5efe0027214c2f7f973ec0ff31499cab4b3fa4f
comment:9 Changed 8 years ago by Owen Arnold
refs #6248. Swap in CompositePeaksPresenter.
No change in behaviour as a result of putting this in with the current 1 workspace only setup. This is a good position to start now allowing multiple peakspresenters. Also applied minor fix here resulting from not updating the slicing widget pointer.
Changeset: df300dc8b89de75e151dd5448bfc7831604c4cee
comment:10 Changed 8 years ago by Owen Arnold
refs #6248. PeakFactoryOverlay takes colour number
Changeset: 59ba3fe99ec2ef7da6f969ca3684ef23fce12213
comment:11 Changed 8 years ago by Owen Arnold
refs #6248. Fully handling multiple peaks workspaces.
Changeset: 3e3c2b01a665118478ed662a35b8eabdee32b8e9
comment:12 Changed 8 years ago by Owen Arnold
refs #6248. Fix gcc exception issue.
Changeset: 006f0bf56537c4b02972702c3b123d2bb717cc5e
comment:14 Changed 8 years ago by Owen Arnold
Updated the wiki page for the new components
comment:15 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester:
Follow the same testing instructions from #5167. However, you'll want to generate more than one peaks workspace to plot. If you are using the script suggested in #5167, then you can do such things as increase the MaxPeaks in FindPeaksMD from 20 to say 30, and/or Change the PeaksRadius in IntegratePeaksMD from 0.12 to say 0.15. Make sure you rename the output PeaksWorkspace before you re-run the script with new parameters, that way you won't overwrite the original workspace, and will end up with a series of input PeaksWorkspaces to use.
When you plot multiple peak overlays, they should each be given a unique colour.
comment:16 Changed 8 years ago by Owen Arnold
refs #6248. Make working CompositePeaksPresenter.
Changeset: c5efe0027214c2f7f973ec0ff31499cab4b3fa4f
comment:17 Changed 8 years ago by Owen Arnold
refs #6248. Swap in CompositePeaksPresenter.
No change in behaviour as a result of putting this in with the current 1 workspace only setup. This is a good position to start now allowing multiple peakspresenters. Also applied minor fix here resulting from not updating the slicing widget pointer.
Changeset: df300dc8b89de75e151dd5448bfc7831604c4cee
comment:18 Changed 8 years ago by Owen Arnold
refs #6248. PeakFactoryOverlay takes colour number
Changeset: 59ba3fe99ec2ef7da6f969ca3684ef23fce12213
comment:19 Changed 8 years ago by Owen Arnold
refs #6248. Fully handling multiple peaks workspaces.
Changeset: 3e3c2b01a665118478ed662a35b8eabdee32b8e9
comment:20 Changed 8 years ago by Owen Arnold
refs #6248. Fix gcc exception issue.
Changeset: 006f0bf56537c4b02972702c3b123d2bb717cc5e
comment:21 Changed 8 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:22 Changed 8 years ago by Vickie Lynch
- Status changed from verifying to closed
Great new feature. I used this to debug CentoidPeaks.
comment:23 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7094