Ticket #6253 (closed: fixed)
Refactor AlignAndFocusPowder
| Reported by: | Peter Peterson | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Wenduo Zhou |
Description
The main point is to make the histogram/event versions more joined and improve logging of what steps are actually being done.
Change History
comment:2 Changed 8 years ago by Peter Peterson
Re #6253. Refactored AlignAndFocusPowder and added lots of logging.
The exec and execEvents were near identical. This consolodates those into a single branch and adds logging. Re #6253. Put the work for LoadCalFile into a centralized function.
Re #6253. Renamed several variables in preparation.
Re #6253. Merged execEvent function into exec
Re #6253. Added more logging statements.
Changeset: 013de6c27eb8cd048f431f330750ad574aea751f
comment:3 Changed 8 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 8 years ago by Peter Peterson
Re #6253. Refactored AlignAndFocusPowder and added lots of logging.
The exec and execEvents were near identical. This consolodates those into a single branch and adds logging. Re #6253. Put the work for LoadCalFile into a centralized function.
Re #6253. Renamed several variables in preparation.
Re #6253. Merged execEvent function into exec
Re #6253. Added more logging statements.
Changeset: 013de6c27eb8cd048f431f330750ad574aea751f
comment:5 Changed 8 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:6 Changed 8 years ago by Vickie Lynch
- Status changed from verifying to reopened
- Resolution fixed deleted
I did accidently try reading a histo nexus file with FilterBadPulses checked and got an error from line 300. Other that that, results matched old results and output from PreserveEvents true and false looked the same. Reduction with histo nexus file worked.
comment:8 Changed 8 years ago by Peter Peterson
Re #6253. Don't run filtering methods if working with histogram data.
Changeset: 8165b7cbb5e392decb0b679be9d36462a7d8c3b4
comment:9 Changed 8 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
comment:10 Changed 8 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester changed from Vickie Lynch to Wenduo Zhou
comment:11 Changed 8 years ago by Wenduo Zhou
- Status changed from verifying to reopened
- Resolution fixed deleted
There is no wiki page for this algorithm. It will be helpful if the workflow of this algorithm can be listed there.
comment:13 Changed 8 years ago by Peter Peterson
Added the wiki page which highlights missing wiki pages http://www.mantidproject.org/AlignAndFocusPowder
comment:14 Changed 8 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
comment:17 Changed 8 years ago by Peter Peterson
Re #6253. Don't run filtering methods if working with histogram data.
Changeset: 8165b7cbb5e392decb0b679be9d36462a7d8c3b4
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7099
