Ticket #6274 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Refactor FilterByLogValueTest to not load a real data file

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 3.0
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

It's quite slow and this should have the effect of speeding it up

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Summary changed from Refactor FilterByLogValue to not load a real data file to Refactor FilterByLogValueTest to not load a real data file

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:4 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:5 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:6 Changed 7 years ago by Russell Taylor

  • Milestone changed from Backlog to Release 3.0

comment:7 Changed 7 years ago by Russell Taylor

  • Keywords Maintenance added

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #6274. Remove test that loaded a file.

I'm satisfied that what's left of the suite tests things just as effectively (more so in fact) than what's I'm removing.

Changeset: 7176d62968456d2e70be9d4660aee0fc1e658fc7

comment:9 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester: Branch is feature/6274_filterbylogvaluetest_dont_load_file

By inspecting the file, satisfy yourself that the algorithm is still adequately tested even after removed test methods. Note that the algorithm is also tested as part of the HYSPECReduction system test.

comment:10 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:11 Changed 7 years ago by Michael Reuter

I agree that the unit test does quite a good job at coverage and data loading didn't add much.

comment:12 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/6274_filterbylogvaluetest_dont_load_file'

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7120

Note: See TracTickets for help on using tickets.