Ticket #6281 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Search for IDF Parameter File for IDF not in instrument Folder in Same Folder First

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description (last modified by Karl Palmen) (diff)

At present if one loads an IDF file from a folder other than the instrument (e.g by LoadEmptyInstrument or a unit test) the parameter file it uses must be in the instrument folder.

It would be convenient if it were to first look for the parameter file first in the same folder as the IDF file and if it does not find any there, go on to the instrument folder as at present.

Related tickets #5635 amd #6154

Change History

comment:1 Changed 8 years ago by Karl Palmen

  • Status changed from new to assigned
  • Owner set to Karl Palmen
  • Description modified (diff)

comment:2 Changed 8 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:3 Changed 8 years ago by Karl Palmen

Put Parameter File Search into separate function re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e1d44cf099c7cfff9449498a53c270100f16724b

comment:4 Changed 8 years ago by Karl Palmen

Implement searching as specified re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 91fc3118b42298b5fd3eac36c6ebaaa92ac53fff

comment:5 Changed 8 years ago by Karl Palmen

Add Unit Test for parameter file of IDF file re #6281

This test loads an IDF not in the instrument folder and checks that it uses a parameter file that is in the instrument folder.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5c4376d4663f932b78040c014999f4631c00955c

comment:6 Changed 8 years ago by Karl Palmen

Add further tests for Parameter File Selection re #5635 re #6281

Changeset: aa0d02c305752c02dbae97f629e2a1107321012c

comment:7 Changed 8 years ago by Karl Palmen

Add 2 more unit tests and remove duplicate code re #5635 re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b3918a6583751723e83056373db828c06079b0de

comment:8 Changed 8 years ago by Karl Palmen

Added One More Test re #5635 re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 97a44fcf130819bb487dafe3448de21fc24626e3

comment:9 Changed 8 years ago by Karl Palmen

Added test IDF file re #5635 re #6281

Changeset: 150dcec1577da8f7906ce9a24d04368c568251c9

comment:10 Changed 8 years ago by Karl Palmen

To test this ticket, I suggest doing the same test as for ticket #5635 but with the IDF file in a folder other than the instrument folder and the parameter files in same folder or the instrument folder in various combinations.

If there is any parameter file in the same folder of an appropriate name it should use the appropriate parameter file from this folder. If there is no such parameter file in the same folder, it should select an appropriate parameter file from the instrument folder.

comment:11 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 8 years ago by Karl Palmen

Improve Unit Test Error Message re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 465e30cba2928f86e0062896763f6173cc0c3b8e

comment:13 Changed 8 years ago by Karl Palmen

Put Parameter File Search into separate function re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 556a38f53f73bba0257914a97634f1adcd5075a9

comment:14 Changed 8 years ago by Karl Palmen

Implement searching as specified re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5266db6a7ad016e518e1fe73e7d1c2b3e1c4b721

comment:15 Changed 8 years ago by Karl Palmen

Add Unit Test for parameter file of IDF file re #6281

This test loads an IDF not in the instrument folder and checks that it uses a parameter file that is in the instrument folder.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 37ec37d42345210110e35c94ab091d8ac937b852

comment:16 Changed 8 years ago by Karl Palmen

Add further tests for Parameter File Selection re #5635 re #6281

Changeset: 4e0adae4426c4dea7aa161cec351708ff2f4fe5d

comment:17 Changed 8 years ago by Karl Palmen

Add 2 more unit tests and remove duplicate code re #5635 re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 48b96e3b3ace374281326bc2d3c62640c9092743

comment:18 Changed 8 years ago by Karl Palmen

Added One More Test re #5635 re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 4467a586c0b7872d86f8efbfc6518f68d5d03069

comment:19 Changed 8 years ago by Karl Palmen

Added test IDF file re #5635 re #6281

Changeset: 3439c55d60b326eb22c79f6a64a23dacb4dc12cc

comment:20 Changed 8 years ago by Karl Palmen

Improve Unit Test Error Message re #6281

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 4f5e5d425eaa44f92449279dc094fef77b16d3c7

comment:21 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:22 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

for test see #5635

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7127

Note: See TracTickets for help on using tickets.