PeakOverlay SpeedUp Part 1 (Investigation)

[Owen Arnold]

The PeakOverlay code has been written to be read. Until now, I've deferred any kind of optimisations. As the SliceViewer is a tool for speed, it is quite important that some effort is provided to ensure that it runs fast and smoothly.

I have a number of ways in which I think I can speed up the PeakOverlay features. However, to keep this process objective, I first need to measure the current performance. This work is therefore being divided into two parts.

1) Extract the heavy-lifting code out of the PeaksOverlayView objects into something that can be measured and benchmarked. I'm going to focus on the physical aspects of drawing sliced peaks, because these are within my control. Details of the rendering (inside the Qt drawing) are not.

2) Once benchmarks have been made, create a separate ticket to start applying the speedups, safe in the knowledge that I know that the original measures were.

This ticket is concerned with (1)

[Owen Arnold]

Upgraded to critical, because it would be very bad if we were to badly affect the performance of the slice viewer and release it anyway.

[Owen Arnold]

refs #6291 PhysicalSphericalPeak created.

Changeset: e99a484bc1f484e336a8ceab503ea659f3463e54

[Owen Arnold]

refs #6291. Separate Spherical Peak Roles.

Physical simulation are now separate from Qt drawing aspects.

Changeset: 1bf71a2c831416a8cb47aed327ed798a5673f06e

[Owen Arnold]

refs #6291. Performance tests added for spherical case.

Changeset: 60afbc73cee61723db25851c2bbf1d11de8fb430

[Owen Arnold]

refs #6291. Implement peak cross equivalent.

Changeset: 4e01a215aabeb05dc1a846f09ca64867df9842cb

[Owen Arnold]

refs #6291. Wire in peak cross.

Changeset: 62553d9acede8f275e4bbb20199828c7f39a1799

[Owen Arnold]

refs #6291. Fix tests and add constraints.

Changeset: 515c894fa7cf5a4d06783750fa157419fcc6a745

[Owen Arnold]

refs #6291. Fix warnings.

Changeset: d6204de970724fff5ac773b22c598fe5c0c6938a

[Owen Arnold]

refs #6291. Fix warning.

Changeset: 0f89f3126d5ca7c16b36fef84ba0f124f1a714b5

[Owen Arnold]

refs #6291 PhysicalSphericalPeak created.

Changeset: 0a283ff188d242d7fb4ce104c3c6411fd63c1436

[Owen Arnold]

refs #6291. Separate Spherical Peak Roles.

Physical simulation are now separate from Qt drawing aspects.

Changeset: d2e62d75beac5e2d1b6da0fefdf6ca25711912e8

[Owen Arnold]

refs #6291. Performance tests added for spherical case.

Changeset: 42044684240019ab4073f0bec55a86425291adf9

[Owen Arnold]

refs #6291. Implement peak cross equivalent.

Changeset: 507f6582b95e28aa7c5a880f1e0f25d97736da04

[Owen Arnold]

refs #6291. Wire in peak cross.

Changeset: 766b2e68598d48c16d9b771364924226da2cff59

[Owen Arnold]

refs #6291. Fix tests and add constraints.

Changeset: adfcfd9acd5d541099279f714eec6cd64025010b

[Owen Arnold]

refs #6291. Fix warnings.

Changeset: dd9900c529c1eac408fe082459b1b7de80c8c93c

[Owen Arnold]

refs #6291. Fix warning.

Changeset: 94b3483c2805a2b62fd9f50b2fcfeda1b314f147

[Owen Arnold]

Tester:

The major output of this exercise was to be able to generate performance tests for benchmarking see:

​http://download.mantidproject.org/jenkins/view/Infrastructure/job/isis_performance_tests/Performance_Tests_Report/?

Other than that, I recommend looking at the code and unit tests, and also checking that the functionality introduced here hasn't broken any of the existing functionality.

The wiki has been updated to contain the new design:

http://www.mantidproject.org/PeakOverlayADD

[Owen Arnold]

refs #6291. Fix RHEL6 pef tests.

Changeset: ebb80f012eb8e8e216b61b34fae9d59a02dc2cdf

[Owen Arnold]

refs #6291. Modify Perf Tests.

Real usage involves multiple setSlicePoint call and multiple draw calls. We need to optimsise the code for this, so the performance tests need to work like that too.

Changeset: d2b60b0dc8a2167f869dcb3ccba606bee64f3f80

[Owen Arnold]

refs #6311 #6291. Increase work in perf tests.

Ive had to increase the work done in the peformance tests, because they are running too fast in the Release-mode build server enviroments to be useful.

Changeset: 79d2a81db39d9742092d647d2bc34b79ade0ccfa

[Owen Arnold]

refs #6291 PhysicalSphericalPeak created.

Changeset: b316b8b286ac7a5c5133121f68fcb881811b93cf

[Owen Arnold]

refs #6291. Separate Spherical Peak Roles.

Physical simulation are now separate from Qt drawing aspects.

Changeset: 770efcde29a0841fb0ed847964d9387a1acd2f7b

[Owen Arnold]

refs #6291. Performance tests added for spherical case.

Changeset: d86d1aee8f0678aa5bab50509149921a7ab037b5

[Owen Arnold]

refs #6291. Implement peak cross equivalent.

Changeset: 45663e4920297872a2c97a10302a07b21af9d73f

[Owen Arnold]

refs #6291. Wire in peak cross.

Changeset: dcbb46421ccb20cb234081757578218b3f9aa681

[Owen Arnold]

refs #6291. Fix tests and add constraints.

Changeset: c444c8638e7154c4dd6594373fdd5e468f9a5651

[Owen Arnold]

refs #6291. Fix warnings.

Changeset: 7ee4a628ca5b8b0844ed0ce3875dd1ec4e4c2493

[Owen Arnold]

refs #6291. Fix warning.

Changeset: 1909a5fab77adba4e88bd54f0e398ce4a89ea394

[Owen Arnold]

refs #6291. Fix RHEL6 pef tests.

Changeset: 77046b0f7623dfde96fbfd565cbe84c452f813e8

[Owen Arnold]

refs #6291. Modify Perf Tests.

Real usage involves multiple setSlicePoint call and multiple draw calls. We need to optimsise the code for this, so the performance tests need to work like that too.

Changeset: 66cb5dd968735dde33bd31ff9e42de23688dfdd2

[Owen Arnold]

refs #6311 #6291. Increase work in perf tests.

Ive had to increase the work done in the peformance tests, because they are running too fast in the Release-mode build server enviroments to be useful.

Changeset: 1323e8ccc9dd33afd114a45fc10ee627b1ca5e4f

[Nick Draper]

Performance tests in place and running. Peak display performance is good

[Stuart Campbell]

This ticket has been transferred to github issue ​7137