Ticket #6294 (closed: fixed)
Investigate and fix the performance degradation caused by change in box splitting procedure
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | Release 2.4 |
Component: | VATES | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Vickie Lynch |
Description
Recent changes according to #5697 have substantially decreased the performance of the box splitting procedure. This should be fixed.
Change History
comment:2 Changed 8 years ago by Alex Buts
refs #6294 fixed stupid warning.
Changeset: 07a09e347ac6fac987bf2eb86679b1bcef191d09
comment:3 Changed 8 years ago by Alex Buts
refs #6294. Actually this is correct boxing procedure.
The previous one was wrong
Changeset: 9406392df2146ea8aac7edd6932a114e16a28f6d
comment:4 Changed 8 years ago by Alex Buts
refs #6294 Correct boxing again
Changeset: 73ba4e3ebe8ae3287322451dee304b1ac82e8351
comment:5 Changed 8 years ago by Alex Buts
refs #6294 caching box sizes and min box val for performance.
Changeset: 680207660040596220e664823987a07b958f1ee0
comment:6 Changed 8 years ago by Alex Buts
refs #6294 fixed stupid error
Changeset: 51b2cdf0b0be912eac6afad34d2431756fd1def1
comment:7 Changed 8 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
Easy to test ticket. The tester should look at the graphs at https://builds.sns.gov/job/mantid_performance_tests/Performance_Tests_Report/
MDGridBoxTestPerformance.test_sphereIntegrate_inTheMiddle_largeSphere and couple of tests nearby and see that the performance is again become acceptable
comment:8 Changed 8 years ago by Alex Buts
refs #6294 fixed stupid warning.
Changeset: e91a020d6997cb4b0c51c3615067fc90e6f145d0
comment:9 Changed 8 years ago by Alex Buts
refs #6294. Actually this is correct boxing procedure.
The previous one was wrong
Changeset: d7bebef97f0a4c0b4de15bb02bf60b3c62cc4da5
comment:10 Changed 8 years ago by Alex Buts
refs #6294 Correct boxing again
Changeset: 4d2ba27d97892caddaa5d46bd7c63cfa1c95fca5
comment:11 Changed 8 years ago by Alex Buts
refs #6294 caching box sizes and min box val for performance.
Changeset: ed35845045e80cef35bb31be8b69901a9c23f779
comment:12 Changed 8 years ago by Alex Buts
refs #6294 fixed stupid error
Changeset: f146bf28d63b960711ce976709837a5bd600cb3d
comment:13 Changed 8 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:14 Changed 8 years ago by Vickie Lynch
Hi Alex, I see an increase in the execution time around March 2012, but no decrease 7 weeks ago.
comment:15 Changed 8 years ago by Alex Buts
Hi, Vickie,
the test https://builds.sns.gov/job/mantid_performance_tests/Performance_Tests_Report/
MDEventsTest.MDGridBoxTestPerformance.test_sphereIntegrate_inTheMiddle_largeSphere
Was particularly affected and has big decrease in speed from 12.12.05 to 12.12.10. This is what was fixed. There were recent decrease in functionality too, but these things are less critical and I have already had a ticket and understanding to deal with.
comment:16 Changed 8 years ago by Vickie Lynch
- Status changed from verifying to closed
Do see decrease at that time.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7140