Ticket #6343 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Merge get3pointsFor3pointMethod and getPeaksForNSlitsMethod of tube_calib.py

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 2.4
Component: Mantid Keywords: calibration
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

To enable the python code of Mantid/scripts/calibration to be organised as required in the attached document

Calibration of Position Sensitive Detectors in Mantid.doc ,

the functions get3PointsFor3pointMethod and getPeaksForNslits of tube_calib.py need to be merged into a single generalised function in the manner suggested in the decument.

Attachments

Calibration of Position Sensitive Detectors in Mantid.doc​ (32.5 KB) - added by Karl Palmen 8 years ago.

Change History

Changed 8 years ago by Karl Palmen

comment:1 Changed 8 years ago by Karl Palmen

  • Owner set to Karl Palmen
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:3 Changed 8 years ago by Karl Palmen

Put Functional Form into Ideal Tube re #6343

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5de76ab8e48fbbf271e2d84cce770dc48e51831e

comment:4 Changed 8 years ago by Karl Palmen

Replaced two function with getPoints() re #6343

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 688b85d3fd3fd024598c3bf1cad7f1c76cfd8e13

comment:5 Changed 8 years ago by Karl Palmen

Tidy up demo programs re #6343

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a5115558faa0d22aeaf81a9e2939591286f205cc

comment:6 Changed 8 years ago by Karl Palmen

To test, check that the functions the functions get3PointsFor3pointMethod and getPeaksForNslits of tube_calib.py no long exist in tube_calib.py and instead there is a getPoints function.

Verify the the code works by running so of the examples or your variation of them.

comment:7 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Karl Palmen

Put Functional Form into Ideal Tube re #6343

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 2adf89ff22a29eb60e043cfdef70ecf0e7d6e77f

comment:9 Changed 8 years ago by Karl Palmen

Replaced two function with getPoints() re #6343

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 02287dd3a02dcfceddb5fe65d596bdd8ee300a8d

comment:10 Changed 8 years ago by Karl Palmen

Tidy up demo programs re #6343

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b1ee715005f45ab97ada675f3bb5e198a1f8e8a4

comment:11 Changed 8 years ago by Karl Palmen

For testing I suggest you also modify the ideal tube for the WISH test and check that a corresponding change occurs in the bands in the instrument view. Fail if changing the ideal tube decisively produces no change.

comment:12 Changed 8 years ago by Karl Palmen

For the part of the test just mentioned, I suggest you run TubeCalibDemoWish0.py, then run a copy of this but with line 32 modified so the numbers are still in order and in the same range but otherwise quite different. You should then see a change in the positions of the stripes on the instrument view.

comment:13 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:14 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to verify
  • Tester Peter Peterson deleted

comment:15 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:16 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Confirmed replacement of two functions with one and seeing different calibration results with different input numbers.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7189

Note: See TracTickets for help on using tickets.