Ticket #6345 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Various changes for building on Mac

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: owen.arnold@… Blocked By: #6592
Blocking: Tester: Michael Reuter

Description

This is a general ticket to capture changes required to make life better on the mac. It is intended to cover stuff for different compilers and std libs.

Change History

comment:1 Changed 8 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Stuart Campbell

Made syntax match C++ standards.

This was an error picked up by clang. It only matters for dependent templates. refs #6345

Changeset: 605c4f72ae60daed4a3d7387df578499a98de8cb

comment:3 Changed 8 years ago by Stuart Campbell

Made syntax match C++ standards.

This was an error picked up by clang. It only matters for dependent templates. refs #6345

Changeset: 605c4f72ae60daed4a3d7387df578499a98de8cb

comment:4 Changed 8 years ago by Stuart Campbell

  • Cc owen.arnold@… added

comment:5 Changed 8 years ago by Stuart Campbell

Quiet compiler warnings on gcc. refs #6098

This also related to getting compilation working for clang on the mac. refs #6345

Changeset: 6c18c625198c3a2407c61eafd5c2fed0fd185f38

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:7 Changed 8 years ago by Stuart Campbell

Fix error for clang compiler. refs #6345

Changeset: 2d1462acee4968f78c227b656b43f657101e26f7

comment:8 Changed 8 years ago by Stuart Campbell

  • Blocked By 6592 added

comment:9 Changed 8 years ago by Stuart Campbell

Moved PRAGMA() define outside openmp block.

This means that our code base will now compile on non-openmp compilers. refs #6592 & #6345

Changeset: 308c3c89e8fdffb12d3be7f2ff8b62606bd72089

comment:10 Changed 8 years ago by Stuart Campbell

Don't try to use emplace_back for clang compiler.

refs #6345

Changeset: 47047af741d2ed65b01164704ce7632265517066

comment:11 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:12 Changed 7 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Milestone changed from Release 2.6 to Release 2.5

Closing for end of release. Will open new ticket in next release if needed.

Nothing really to test.

comment:13 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:14 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

These changes have already been in place on master for a while now.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7191

Note: See TracTickets for help on using tickets.