Ticket #6592 (closed: invalid)

Opened 8 years ago

Last modified 5 years ago

Comply with C++11 syntax

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #6345 Tester: Russell Taylor

Description

This is mainly minor changes to comply with compilers that follow the C++11 syntax requirements strictly (aka clang).

Change History

comment:1 Changed 8 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Stuart Campbell

C++11 syntax fixes for API. refs #6592

Changeset: de03ceaf594f408c7d06542a547dc02b0d1e1edc

comment:3 Changed 8 years ago by Stuart Campbell

C++11 syntax fixes for Crystal. refs #6592

Changeset: 4ea0917ef39d0d6b3118f5779fe817b38f24479e

comment:4 Changed 8 years ago by Stuart Campbell

C++11 syntax fixes for CurveFitting. refs #6592

Changeset: f886d4de197976b6cb3c8e249a88affde7a362ac

comment:5 Changed 8 years ago by Stuart Campbell

C++11 syntax fixes stream >> confusion in DataHandling. refs #6592

Changeset: a84f0329f0a2a0b0447078802eacf1b137f1ce13

comment:6 Changed 8 years ago by Stuart Campbell

C++11 syntax fixes for MDEvents. refs #6592

Changeset: 3de44e81a4461a327a54a0aa61fa0b5517c39fc0

comment:7 Changed 8 years ago by Stuart Campbell

C++11 syntax fixes for PythonAPI. refs #6592

Changeset: 22798904c5b956394d045fc46ff5879dd7287872

comment:8 Changed 8 years ago by Stuart Campbell

C++11 syntax fixes for PythonInterface. refs #6592

Changeset: d4ff809d43737816c0f68adca9ebd57a46a297df

comment:9 Changed 8 years ago by Stuart Campbell

C++11 syntax fixes for ICat. refs #6592

Changeset: 526dd6c3dde68f95e2e02f218db71fe75641d26c

comment:10 Changed 8 years ago by Stuart Campbell

Moved PRAGMA() define outside openmp block.

This means that our code base will now compile on non-openmp compilers. refs #6592 & #6345

Changeset: 308c3c89e8fdffb12d3be7f2ff8b62606bd72089

comment:11 Changed 8 years ago by Stuart Campbell

C++11 syntax fixes for MDAlgorithms. refs #6592

Changeset: 2d8b0cb1c6757abceb32ea8d6e7a32d5b54e8edc

comment:12 Changed 8 years ago by Stuart Campbell

  • Cc owen.arnold@… removed
  • Status changed from accepted to verify
  • Resolution set to invalid

comment:13 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:14 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

This turned out to be a mistake where clang wasn't getting up the --std=c++0x (or --std=c++11) flag that cmake sets for the gcc & intel compilers. The changes then reflect the fact that pre-c++11 the space was required between brackets in nested template (the opposite of what the ticket title & commits say).

I agree that there's no particular need to revert the commits as the changes still work and we have plenty of legacy examples where the space remains.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7438

Note: See TracTickets for help on using tickets.